From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F13D2F360A for ; Wed, 22 Jul 2026 08:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784708509; cv=none; b=L1Qg2JcJdCfaBf/9x5pusiYXIhRqlBQk0o+6WLy3f4x7f6VSWyeYnkD58rKU95RlVj8hZS2BZeA4phR4be2OxKa2uyvDg6ygWyWVjFTFa416w7B7JgQVnHTjoPYD5KVD+xDSm3jB3m9OWXdNcrs/hNOaqROXg9o/SjMbiSY/wdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784708509; c=relaxed/simple; bh=/IVqxM0aX7zPyUcIZbTda2GMsn8LN+JpCLz75h95efU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PbA9nuuwY2BP/5f0eCTxowl1OWHvcN09oNP+6Zc+EpZ1HuLt0Aq67v7rgXASxW8BtGJ980o3J07GWZo32S9N8z15WQUM3R3tnq5nnC5NMKutUtVuLVwxgiIeYIBKaQp33rVBRz8nan/13vCK14rYBu+pMEV85FJTJH/MgEMkkgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bjpK3QtR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fvW7aq5g; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bjpK3QtR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fvW7aq5g" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M53pJH3787369 for ; Wed, 22 Jul 2026 08:21:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qHQZ/CWxA22Mv/04aBv8o7hR+RlYHT5Vmjk9Hg5QZ2U=; b=bjpK3QtRveDeMCC2 K/RlkmR6v7hFM4AQ4nfyr5xKqFXdjAqgAQ4PpbQXMDBqjqGDS6LR/4s7nVJn5VXt IeGtUyLCV0Ht/eAgcnkSCpeWFkeEFXxS1KFTbDtmI3ahSEGXPI000LLSh2kXpbwE Pf+h2TGWfwXP4YJT5JWwjuJuxsEvinU05sqBfiU7ohAGo220zrImzGxyTO7WZMPP yZ5jDkqz0Tj9g74QLlidBioGgJ1yaiXUrq07o2WKoC2aGR4St7MpVuqn/GJOihyS akS+zBYi38aF4sP5vCdGEQpcYxx35z1aJUNws17dFDPOpu1HEoLpdGIY+NHJO2A+ pLZpFA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj9aecerh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 08:21:44 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1d30035dso155708521cf.2 for ; Wed, 22 Jul 2026 01:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784708504; x=1785313304; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=qHQZ/CWxA22Mv/04aBv8o7hR+RlYHT5Vmjk9Hg5QZ2U=; b=fvW7aq5gP0NVAzxqRjWPRkgB1TdEpfy5wJsYeS+t/UbpEbAhgJSSTO2UN6tN39wCAd j7DGIOx/L/jENLOgr4UOZ104teIRimpzewB7ROa9LxRpMYRAFUCu1mXsl6yKAhDuqbfS THLQTq1tQjxteD+xJQEqLisxDPMMg74T502XnUAdAQ4C3IRoy/APl5/iPbD8xvV0mCOd Gdj0z/u8+Id3SU0z9vzv2hzNzLe08RykPoYHku+g1zPcPx1k1+F4QWmHAbz0vRztTyy9 YcRrD+CzIlVBUroHA6G0twVjFFOBIt6jCbGJu79NZpBn0Hw/jggEzzqXiEn3ZvmvafCH 3gPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784708504; x=1785313304; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qHQZ/CWxA22Mv/04aBv8o7hR+RlYHT5Vmjk9Hg5QZ2U=; b=lMrz8Im/WxPAKWt1aSM6WhBk7S/b6alIFYo5AnNatt4FFi2vTvTOddeeGoyCFRJ8E4 ky90wFTqHFW0yGDoJpS5IEUkcXYSNKDdSMG7fVcLFTQfKf/PJRGCl9MK7zxespSAZjZI JZMsnzoiPrDeWJZfPDKFsHG5basydpNgKOF7JreWH9pA+53VjhBW1+odGRadfbOz1ntz t3vVycTCS+YLizEs7Rbvbk7DlOMVJmjaMH+hmbxEYyxLehsE/UnIGJ3MUrUP75b1IVG0 OKqa/2lnLV9K1cVj3MCT2gB7gsf/TPBSUCwhicerUjivOTDbQB8EoX4CJDSki8qdG1fR kTKQ== X-Forwarded-Encrypted: i=1; AHgh+Rq4gj7BxjPrtrPZVa5MyP5Z5iz+Bk0yMeLWQ1DFX+r36jkYJMCtAVmEI+I5A7bmht37zGxldrCY5FlvpeU=@vger.kernel.org X-Gm-Message-State: AOJu0YzWvat6RLUU4GCkErofzXg2BNknFM8VHM5CzgslmL5VgFo1AruF yGEtOhc2tdVW8ULw4nbCvbqD4BNRXMG3L+ARviGBfhZbUrQNym7uoRfs4Zi9EnwhMNV0QSyELCc rpN+0ukI+jh+igPnq2JmGW4CfQ5CkEorartDxge9xoloJF9MyjIfSxUSHdvtIw/2PnSo= X-Gm-Gg: AR+sD12NxJIAZoT4MbFdZc/D0w5mY/VkZlM3iqT+lsaohYu8mJYe+VmFSWBjouu1as3 mg9a4aeDNCgvvoIrsLpg3jtH8TE4nFYisDqujA1CxmujPcgQmeZeFhnnAqmwNEFzKPZcgBdXu4/ Ax6rWnoDWtOJpNI5xQ83fuEekJa8c+KLn077P3YRfWVBYs5LdVJKga0q65d/9HjibapVIgiPPIg pjBE/w0Mn2mFW6aonLPgFIoGPsbdxlzn9mkF56Cro37Dbk7hyhR/SCpx6GYdDnfnI3bqyJmZR11 xfi/UDVykHT5BAnoObnuqfA4JO8tQHyEsNy76G999Qr0h7HPAec4wovySDUVySBU/6VwIIi7iy2 cXPAdacvxOAy6gaa0iKni6efV7jzZPA== X-Received: by 2002:a05:622a:1a94:b0:51c:1bb9:137f with SMTP id d75a77b69052e-5213c20160cmr208790881cf.24.1784708503676; Wed, 22 Jul 2026 01:21:43 -0700 (PDT) X-Received: by 2002:a05:622a:1a94:b0:51c:1bb9:137f with SMTP id d75a77b69052e-5213c20160cmr208790591cf.24.1784708503220; Wed, 22 Jul 2026 01:21:43 -0700 (PDT) Received: from [192.168.1.110] ([178.197.223.174]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85bb57cfsm3735346f8f.11.2026.07.22.01.21.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2026 01:21:42 -0700 (PDT) Message-ID: <3523fefc-8ba8-4512-b088-7a94a2df73f8@oss.qualcomm.com> Date: Wed, 22 Jul 2026 10:21:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC To: Andrew Jeffery , Jacky Huang , joel@jms.id.au, robh@kernel.org, conor+dt@kernel.org, andrew@lunn.ch Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org References: <20260710054849.3178747-1-jackyhuang@nvidia.com> <20260710054849.3178747-3-jackyhuang@nvidia.com> From: Krzysztof Kozlowski Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: oy6rmDa3rWWtIVmjEMrctzmXX9bjbExb X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDA3NyBTYWx0ZWRfXzE2IbkjaE0KC 0yKoMvfuyN6/mMtiliVJFt4KgtKBL8Zlz9uqbPOFuH4tQOYakrKX0g/h0RtYCFWRPV8ycUUmCJS A0NTVyeScSS0CFieIPVhpLh5NJvcL+A= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDA3NyBTYWx0ZWRfX7tFq1+RoivUY nPt8eSRMbAbMNGHIvrS8YEYOV3BlZjOyJyq7PRoDAICTbX5qsWrTeNgnOnH2JOChoVy42gBbYaO CjVwZf/ksCeGOSKunEJ76Ef1wTKgdeMwWAcqCaDAk5koy3IF6a+9L4XRuH5KvpKPSAIYO5567Xx mpVIaJBaW6jIdYvzVRkrdn3VVYPFcCBS2e3etkUvROvePBeyBziRw1jYfKdZzu/xWdnNNZjh2DH ZR4N/evlEmwjFIGGRjd8qerSuTOlob/l27j8gzsiWMlFMAOWQzz3ZzNJYBx18DU7Ug9jRATW+mx UnCm+X7cbUMfQgPKrAzty80W23o8H2/UirAELThXgcJCLUaByeHLMzwnz5JHIRY3GahYn/um6Gx hUVjoZqV1EWg86eDD3cs/HEVa10JuGdgr9VlzyMHW8Stm6piYzYndmvS9fmYu9jXYz1pOqGNlrp M/hjzU+PzOAkokclegw== X-Proofpoint-GUID: oy6rmDa3rWWtIVmjEMrctzmXX9bjbExb X-Authority-Analysis: v=2.4 cv=Cr6PtH4D c=1 sm=1 tr=0 ts=6a607d98 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=N6niishs+lR9UBL1FN3Qrw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=Ikd4Dj_1AAAA:8 a=aghwDrSpn70jpU0UxqMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_02,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220077 On 22/07/2026 09:45, Andrew Jeffery wrote: > Hi Jacky, > > On Fri, 2026-07-10 at 14:46 +0900, Jacky Huang wrote: >> Add the device tree for the Aspeed AST2600 BMC for NVIDIA's Vera >> Rubin NVL compute platform. >> >> MAC0 uses phy-mode = "rgmii-id" because the on-board PHY supplies >> both RGMII internal delays.  The matching U-Boot device tree does not >> enable SoC-side MAC clock delays, leaving the MAC internal delay at >> zero so the PHY-provided delay is not doubled by the MAC controller. >> >> The corresponding U-Boot change has been submitted to openbmc/u-boot: >> Link: https://lore.kernel.org/all/20260629105202.1417679-1-jackyhuang@nvidia.com/ >> >> Reviewed-by: Andrew Lunn >> Signed-off-by: Jacky Huang >> --- >> v3: reword the &mac0 comment per Andrew Lunn's feedback. >> >>  arch/arm/boot/dts/aspeed/Makefile             |   1 + >>  .../aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts   | 901 ++++++++++++++++++ >>  2 files changed, 902 insertions(+) >>  create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts > > We now have scripts/dtc/dt-check-style, and going forward I'm asking > that all new devicetree submissions pass in strict mode. Thanks! > > Currently: > > $ ../scripts/dtc/dt-check-style --mode strict ../arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-nvl-bmc.dts 2>&1 | wc -l > 152 > > Can you please address those? Just a note: --strict might not be ready yet. It reports some false positives which need addressing (I have plans for this, but busy with other things...), so expectation currently is: 1. No warnings from standard mode 2. Review and investigate warnings from 'strict' mode, but do not fix them automatically without thinking Best regards, Krzysztof