From: Alexandre Torgue <alexandre.torgue@st.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: <kernel@pengutronix.de>,
Arnaud Pouliquen <arnaud.pouliquen@st.com>,
<devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] ARM: dts: stm32: support child mfd cells for the stm32mp1 TAMP syscon
Date: Tue, 17 Nov 2020 12:18:42 +0100 [thread overview]
Message-ID: <352478be-cd69-2089-baaf-6f796cfc6cfd@st.com> (raw)
In-Reply-To: <20201021102855.18026-2-a.fatoum@pengutronix.de>
Hi Ahmad
On 10/21/20 12:28 PM, Ahmad Fatoum wrote:
> The stm32mp1 TAMP peripheral has 32 backup registers that survive
> a warm reset. This makes them suitable for storing a reboot
> mode, which the vendor's kernel tree is already doing[0].
>
> The actual syscon-reboot-mode child node can be added by a board.dts or
> fixed up by the bootloader. For the child node to be probed, the
> compatible needs to include simple-mfd. The binding now specifies this,
> so have the SoC dtsi adhere to it.
>
> [0]: https://github.com/STMicroelectronics/linux/commit/2e9bfc29dd
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2:
> - Dropped simple-bus. simple-mfd is all that's needed
> - reworded commit message
> ---
> arch/arm/boot/dts/stm32mp151.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
> index 842ecffae73a..662c2408d41b 100644
> --- a/arch/arm/boot/dts/stm32mp151.dtsi
> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
> @@ -1542,7 +1542,7 @@ i2c6: i2c@5c009000 {
> };
>
> tamp: tamp@5c00a000 {
> - compatible = "st,stm32-tamp", "syscon";
> + compatible = "st,stm32-tamp", "syscon", "simple-mfd";
> reg = <0x5c00a000 0x400>;
> };
>
>
Series applied on stm32-next.
Regards
Alex
next prev parent reply other threads:[~2020-11-17 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 10:28 [PATCH v2 1/2] dt-bindings: arm: stm32: add simple-mfd compatible for tamp node Ahmad Fatoum
2020-10-21 10:28 ` [PATCH v2 2/2] ARM: dts: stm32: support child mfd cells for the stm32mp1 TAMP syscon Ahmad Fatoum
2020-11-17 11:18 ` Alexandre Torgue [this message]
2020-10-26 14:36 ` [PATCH v2 1/2] dt-bindings: arm: stm32: add simple-mfd compatible for tamp node Rob Herring
2020-10-26 21:30 ` Ahmad Fatoum
2020-10-27 12:15 ` Rob Herring
2020-11-10 10:27 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=352478be-cd69-2089-baaf-6f796cfc6cfd@st.com \
--to=alexandre.torgue@st.com \
--cc=a.fatoum@pengutronix.de \
--cc=arnaud.pouliquen@st.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®