From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7C5234E779 for ; Mon, 23 Feb 2026 07:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771830307; cv=none; b=bMHl8X3/HySMd/hdhyzJCqLGELPmOah8XywfPrnpfgThfN/Ssa0Y5RbpnF0gj1dTlHlUbArJ42XWGVBhC+gOsNwYCMbJwtHQJ+13q6E/83fWZfT4GapX4MWOQXvX/Z0bjf4BSoJoPLEHcRPrdSW5UPmUJyVKKe+c8ZTEgpsE9/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771830307; c=relaxed/simple; bh=ea4iA5nlwgN+CFTzjyIou+eBChaZJ3B2VNlr77gxrsY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Vl5Ei9mjV+5Yj0yyVCqCwdXVG8T2NXWHEDtcJiURwl/+YW6/iCLw7nNZ+FBbqYV5gRCnd+oZmb5WPsdqGIqRumJOUeOlsE0GP8C9C/YvKUC392eN+3s3BDFKYM3+80aY7SmzhAmqv34lipFJF3KoSnwIdtr5DDi12BxPrQWY/Vc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=je3w3GSQ; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="je3w3GSQ" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-354c0234c1fso3766972a91.2 for ; Sun, 22 Feb 2026 23:05:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771830304; x=1772435104; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=29bxp0SrERjlT2nttg/iVluHBRhM/KYKZg8jrRhN0Y0=; b=je3w3GSQoCU+0acbqtQWtBrzOqtRPaSjXu1hWW8XIk9qkdODHGWfe0WpZOjhsYHAL+ k5ahNSwIOQrm+lJH/nmA7bOEjtYYLuLluijZd2Yr0jmd1l1j3kxNAjKqab2Z1123jjY+ wA/n52FEfu/geyjv+Tr1Bm9H5gYf2bjqMWgs9ZU0MU+2144dIJECaBvgp4duskBby2bE QzCZq4SVgq3fusFu1Fpov0//XzkVqNjBQbJgJjYX2DvefE4DC/lPJeoy0HcNWVNi3kje +T3KHXxZprkzY62UH3EboFg2CpXshkaYsaYQU+BKSjrm/OYmy0hZxXbL40lZ/4wEW9Pt khOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771830304; x=1772435104; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=29bxp0SrERjlT2nttg/iVluHBRhM/KYKZg8jrRhN0Y0=; b=WLuJ71L8Rz/YC4jxCW2cCbN0Lar4sfGs7kqUptC6SomVpARKtMgJSebJbTWdSoEdXl MyWxUl6LrEXxb121YZrBejygRNmkrFGJdbE1JfwugTC5F9yrcT9pZwXccjtR9Dy1REGL Fg5i1CuZy1Nmk8cYqkKKCXCjXJdOJkk9WD5nGO63umqUO2qBjnNCb2h4+mRmqgetkKMO V6rCnY+75bjQo9q5+0J8p+iGGK0D01HquRehm2K+A+Sw7lqoQRkziYBmOHPHJJ+15ADb BIvjeiEgD4FWtDGecDn0PBgS3xQPnjhUHvyZV/smuNO5BH+ScXHOw7lQs/vR0REXg5V7 rdaQ== X-Forwarded-Encrypted: i=1; AJvYcCX8hqDfLmH+birIbyIf3siqA+Tw1fI2TGkBelD+pdbPYINAK+p6czT1LHq8BE9efNgJT94oZXMS7E/erEI=@vger.kernel.org X-Gm-Message-State: AOJu0YzSChsQSU/gfl2cAqKpPi+tAhQ4aX4Eix34zVxqnz/6BakKPYmA cJeHe04PpV4sf5YJI0tVofa7PS+YLG8CYFiBGcdXe+RgZSwycu9EFJL+huWqjc2MP9uYkVxR2El IQwIdKyUmbA+aud3JCLdza/3lig== X-Received: from pjbtb14.prod.google.com ([2002:a17:90b:53ce:b0:353:3526:238b]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2b8c:b0:356:2c7b:c010 with SMTP id 98e67ed59e1d1-358ae812409mr8015127a91.11.1771830303714; Sun, 22 Feb 2026 23:05:03 -0800 (PST) Date: Mon, 23 Feb 2026 07:04:42 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.53.0.345.g96ddfc5eaa-goog Message-ID: <3525199b4a04f0054566abe90eb99cdd5b9939e4.1771826352.git.ackerleytng@google.com> Subject: [RFC PATCH v1 09/10] KVM: selftests: Wrap fstat() to assert success From: Ackerley Tng To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: akpm@linux-foundation.org, david@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, willy@infradead.org, pbonzini@redhat.com, shuah@kernel.org, ackerleytng@google.com, seanjc@google.com, shivankg@amd.com, rick.p.edgecombe@intel.com, yan.y.zhao@intel.com, rientjes@google.com, fvdl@google.com, jthoughton@google.com, vannapurve@google.com, pratyush@kernel.org, pasha.tatashin@soleen.com, kalyazin@amazon.com, tabba@google.com, michael.roth@amd.com Content-Type: text/plain; charset="UTF-8" Extend kvm_syscalls.h to wrap fstat() to assert success. This will be used in the next patch. Signed-off-by: Ackerley Tng --- tools/testing/selftests/kvm/guest_memfd_test.c | 15 +++++---------- .../testing/selftests/kvm/include/kvm_syscalls.h | 2 ++ 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index 618c937f3c90f..81387f06e770a 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -212,10 +212,8 @@ static void test_mmap_not_supported(int fd, size_t total_size) static void test_file_size(int fd, size_t total_size) { struct stat sb; - int ret; - ret = fstat(fd, &sb); - TEST_ASSERT(!ret, "fstat should succeed"); + kvm_fstat(fd, &sb); TEST_ASSERT_EQ(sb.st_size, total_size); TEST_ASSERT_EQ(sb.st_blksize, page_size); } @@ -303,25 +301,22 @@ static void test_create_guest_memfd_invalid_sizes(struct kvm_vm *vm, static void test_create_guest_memfd_multiple(struct kvm_vm *vm) { - int fd1, fd2, ret; + int fd1, fd2; struct stat st1, st2; fd1 = __vm_create_guest_memfd(vm, page_size, 0); TEST_ASSERT(fd1 != -1, "memfd creation should succeed"); - ret = fstat(fd1, &st1); - TEST_ASSERT(ret != -1, "memfd fstat should succeed"); + kvm_fstat(fd1, &st1); TEST_ASSERT(st1.st_size == page_size, "memfd st_size should match requested size"); fd2 = __vm_create_guest_memfd(vm, page_size * 2, 0); TEST_ASSERT(fd2 != -1, "memfd creation should succeed"); - ret = fstat(fd2, &st2); - TEST_ASSERT(ret != -1, "memfd fstat should succeed"); + kvm_fstat(fd2, &st2); TEST_ASSERT(st2.st_size == page_size * 2, "second memfd st_size should match requested size"); - ret = fstat(fd1, &st1); - TEST_ASSERT(ret != -1, "memfd fstat should succeed"); + kvm_fstat(fd1, &st1); TEST_ASSERT(st1.st_size == page_size, "first memfd st_size should still match requested size"); TEST_ASSERT(st1.st_ino != st2.st_ino, "different memfd should have different inode numbers"); diff --git a/tools/testing/selftests/kvm/include/kvm_syscalls.h b/tools/testing/selftests/kvm/include/kvm_syscalls.h index d4e613162bba9..3f039c34e12e0 100644 --- a/tools/testing/selftests/kvm/include/kvm_syscalls.h +++ b/tools/testing/selftests/kvm/include/kvm_syscalls.h @@ -2,6 +2,7 @@ #ifndef SELFTEST_KVM_SYSCALLS_H #define SELFTEST_KVM_SYSCALLS_H +#include #include #define MAP_ARGS0(m,...) @@ -77,5 +78,6 @@ __KVM_SYSCALL_DEFINE(munmap, 2, void *, mem, size_t, size); __KVM_SYSCALL_DEFINE(close, 1, int, fd); __KVM_SYSCALL_DEFINE(fallocate, 4, int, fd, int, mode, loff_t, offset, loff_t, len); __KVM_SYSCALL_DEFINE(ftruncate, 2, unsigned int, fd, off_t, length); +__KVM_SYSCALL_DEFINE(fstat, 2, int, fd, struct stat *, buf); #endif /* SELFTEST_KVM_SYSCALLS_H */ -- 2.53.0.345.g96ddfc5eaa-goog