From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13187C4167B for ; Wed, 6 Dec 2023 10:19:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377660AbjLFKTg (ORCPT ); Wed, 6 Dec 2023 05:19:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377549AbjLFKTd (ORCPT ); Wed, 6 Dec 2023 05:19:33 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6888E112; Wed, 6 Dec 2023 02:19:39 -0800 (PST) Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 63DB66607337; Wed, 6 Dec 2023 10:19:37 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701857978; bh=mjgfItsOqP4PFb5uiNh38eRZZOSIpCl5Be6d6JwRK6k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=m67S4TBWJGoCE++hlGeXKmjI45cRDdU9lm8iaqdR7ahzfLo6OT6U3LO6cRR9S6bih uCj5BNEvpF3OYNQG3mKAhV3VX09ryyOUFrG8UjOiqK7CCx630PMfCj56NcCJc9zrzQ LBjEthQUPbth6qLOBk2nQEQqt7H0nA4L688Jrvbam9J0HJZ3uAFa4ebvA9qPAZmbCY 3Aluv2rA2Cv199JeYQEg9VW/scxbheo+pDRmgjZ4P2SQW4FV7V4EWLCdqgK3g16pjZ fTpdvPTr6AOr0Z0VoaZGSe0qeF4WIl3McFNXT6CJnTE+93DtnZ4Mi/fQMaWpDBDPIl GULkbwqENveWg== Message-ID: <3528639f-85a3-4756-b04b-c233f6c84276@collabora.com> Date: Wed, 6 Dec 2023 11:19:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] media: mediatek: vcodec: Drop unnecessary variable Content-Language: en-US To: Fei Shao , Hans Verkuil Cc: Andrew-CT Chen , Matthias Brugger , Mauro Carvalho Chehab , Nicolas Dufresne , =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Tiffany Lin , Yunfei Dong , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20231113123049.4117280-1-fshao@chromium.org> <20231113123049.4117280-3-fshao@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20231113123049.4117280-3-fshao@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 13/11/23 13:26, Fei Shao ha scritto: > It's unclear why only mem->size has local copies without particular > usage in mtk_vcodec_mem_alloc() and mtk_vcodec_mem_free(), and they > seem removable. > > Drop them to make the code visually consistent, and update printk format > identifier accordingly. > > Signed-off-by: Fei Shao That's probably just about personal preferences, as mem->size is not expected to change during the flow of those functions. That said, as much as you, I prefer not having this local copy as it's using (a very small amount of) memory for no real reason anyway, so: Reviewed-by: AngeloGioacchino Del Regno