From: Joe Perches <joe@perches.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>,
Petr Mladek <pmladek@suse.com>
Cc: John Ogness <john.ogness@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] printk: More consistent loglevel for continuous lines
Date: Wed, 24 Nov 2021 17:45:57 -0800 [thread overview]
Message-ID: <3530db0aa97eed41553ae94da6c99c8979c41cad.camel@perches.com> (raw)
In-Reply-To: <YZ7enboRQprct49o@google.com>
On Thu, 2021-11-25 at 09:53 +0900, Sergey Senozhatsky wrote:
> On (21/11/24 16:48), Petr Mladek wrote:
> >
> > Anyway, it looks a bit non-practical to update all existing pr_cont()
> > callers:
> >
> > $> git grep "pr_cont" | wc -l
> > 2054
>
> Another question is how many pr_cont()-s are getting compiled with
> the "average" production kernel config. A number of pr_cont() is in
> debugging code - lockdep, kasan, etc. - which is not compiled for prod.
This was Linus' attempt to make KERN_CONT meaningful again when it
was IMO a slightly different issue to fix bare printks.
Linus changed the few bare printks that mattered to him at the time.
So the existing bare printk's should also be inspected.
There are still many hundreds of those bare printks around.
$ git grep -P '\bprintk\s*\(\s*(?!KERN_[A-Z]+)\s*"' | wc -l
6863
But most all of those are in really old and effectively dead code.
To approximately answer to the question of how many pr_cont's and
bare printks are getting compiled in an x86-64 config:
$ make defconfig
$ make clean
$ make
$ find . -name '*.o' | sed 's/\.o$/\.c/' | \
xargs git grep -P '(\bprintk\s*\(\s*(?!KERN_[A-Z]+)|\bpr_cont\b|\bprintk\s*\(\s*KERN_CONT)' -- | \
wc -l
518
next prev parent reply other threads:[~2021-11-25 1:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 15:48 Petr Mladek
2021-11-25 0:53 ` Sergey Senozhatsky
2021-11-25 1:45 ` Joe Perches [this message]
2021-12-06 16:19 ` Petr Mladek
2021-12-06 17:34 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3530db0aa97eed41553ae94da6c99c8979c41cad.camel@perches.com \
--to=joe@perches.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®