mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Bryan O'Donoghue <bod@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Stanimir Varbanov <stanimir.varbanov@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Stephan Gerhold <stephan.gerhold@linaro.org>,
	linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	stable@vger.kernel.org, Daniel J Blueman <daniel@quora.org>
Subject: Re: [PATCH v2 01/12] dt-bindings: media: qcom,venus: Add context bank subnodes to common schema
Date: Thu, 6 Aug 2026 17:50:36 +0530	[thread overview]
Message-ID: <353172fa-8acf-4055-a777-021177761fcc@oss.qualcomm.com> (raw)
In-Reply-To: <nht5phhqatbc35rh4l4r5lbf5bytgb2zmesv433zjscs5ye7rs@6y4bczl23nao>


On 8/6/2026 4:44 PM, Dmitry Baryshkov wrote:
> On Thu, Aug 06, 2026 at 11:50:01AM +0100, Bryan O'Donoghue wrote:
>> On 06/08/2026 11:32, Krzysztof Kozlowski wrote:
>>>> Yes -master.
>>>>
>>>> My issue is how long this will take. Several kernel cycles and the
>>>> debate is ongoing.
>>>>
>>>> Daneil's fix has not been applied which means the replicable system bug
>>>> is out there in the wild, not addressed.
>>>>
>>>> Daniel's fix could have been applied and rolled out to all users in
>>>> mainline and consequently stable.
>>>>
>>>> Instead another architectural level fix is still under discussion, which
>>>> is of no value to end users whose systems can reset in the meantime.
>>>>
>>>> Its just not responsible behaviour. So I feel both of these drivers need
>>>> to be marked as BROKEN unless/until a fix lands.
>>>>
>>>> I'm hoping the vidc team will come up with something else.
>>> I did not object taking a known fix for the problem for the mainline
>>> kernel, regardless if the fix is optimal or not. I only objected the
>>> reason of taking patches because of something in stable kernels or
>>> making backports easier or whatever other semi-expressed reason, which
>>> is not the mainline-kernel reason.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> I'm all in favour of rolling out Daniel's fix.
> 
> The biggest problem with it is that it looks like a hotfix or a hack
> rather than a proper description / solution. From this PoV we will land
> the fixes for all the boards in mainline and then fix the same issue
> _again_.

I would call it as un-optimal than a hack, and certainly i can say it 
would *not* have to be patched again. Its simple enough that it applies 
one reserve region to all, instead of applying it selectively to 
specific stream.

> 
>> I don't want to propose BROKEN but at the same time the timeline on this
>> demands action:
> 
> I think this might be a solution, which everybody dislikes, but in the
> end it is true (for both drivers).
> 
>> - Sub-nodes proposed around December ?
>>    Which means the system resetting bug was known
>>    and understood but not promoted as a bug requiring
>>    resolution as it should have been.
>>
>>    Fine people make mistakes, that's life, lessons learned.
>>
>> - Daniel's fix posted.
>>    Not endorsed or rolled out. Its not "perfect" but
>>    it is certainly "good enough".
>>
>> - Now more debate on sub-nodes
>>    I'm all in favour of that but NOT at the expense
>>    of replicable bugs from real users.
>>
>> TBH, when I start to lay out the timeline on this, I get annoyed. It seems
>> to me qcom has understood this bug for nearly six months more ? and mainline
>> is still waiting on a resolution.
>>
>> So I'll leave it up to the vidc people to decide. But some kind of deadline
>> needs to be put on this.

let me post Daniel's patch as fixes, and then the sub node patches can 
continue separately and drop the fixes tag from sub node patches. I 
would be patching both venus and iris.

>>
>> Close of business GMT Friday - either something mergable lands for sub-nodes
>> or we replicate Daniel's fix to all platforms. Failing both, I will have no
>> choice but to set both drivers to BROKEN.
>>
>> Stability has to come first.
>>
>> ---
>> bod
> 

Regards,
Vikash

  parent reply	other threads:[~2026-08-06 12:20 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 18:22 [PATCH v2 00/12] media: iris: Migrate iommus to iris sub nodes Vikash Garodia
2026-07-31 18:22 ` [PATCH v2 01/12] dt-bindings: media: qcom,venus: Add context bank subnodes to common schema Vikash Garodia
2026-08-01 10:06   ` Bryan O'Donoghue
2026-08-06  5:21     ` Vikash Garodia
2026-08-06  7:54       ` Bryan O'Donoghue
2026-08-06  7:57         ` Vikash Garodia
2026-08-06  9:40           ` Bryan O'Donoghue
2026-08-06 10:07             ` Bryan O'Donoghue
2026-08-06 10:14               ` Krzysztof Kozlowski
2026-08-06 10:24                 ` Bryan O'Donoghue
2026-08-06 10:32                   ` Krzysztof Kozlowski
2026-08-06 10:50                     ` Bryan O'Donoghue
2026-08-06 11:14                       ` Dmitry Baryshkov
2026-08-06 11:19                         ` Bryan O'Donoghue
2026-08-06 12:20                         ` Vikash Garodia [this message]
2026-08-11 12:57                           ` Dmitry Baryshkov
2026-08-05  7:21   ` Krzysztof Kozlowski
2026-08-05 10:37     ` Krzysztof Kozlowski
2026-08-06  8:46       ` Dmitry Baryshkov
2026-08-06  9:11         ` Krzysztof Kozlowski
2026-08-06  9:20           ` Krzysztof Kozlowski
2026-08-06  9:22           ` Dmitry Baryshkov
2026-08-06  9:36             ` Krzysztof Kozlowski
2026-08-06 10:35               ` Dmitry Baryshkov
2026-08-06 11:56                 ` Vikash Garodia
2026-08-06 12:10                   ` Dmitry Baryshkov
2026-08-06  8:49   ` Dmitry Baryshkov
2026-08-06  9:52     ` Vikash Garodia
2026-08-06 10:38       ` Dmitry Baryshkov
2026-07-31 18:22 ` [PATCH v2 02/12] dt-bindings: media: qcom,sm8550-iris: Add context bank subnodes Vikash Garodia
2026-07-31 20:36   ` Rob Herring (Arm)
2026-08-06  8:51     ` Dmitry Baryshkov
2026-08-05  7:21   ` Krzysztof Kozlowski
2026-07-31 18:22 ` [PATCH v2 03/12] media: iris: Add platform hooks for context bank device setup Vikash Garodia
2026-08-06  8:53   ` Dmitry Baryshkov
2026-07-31 18:22 ` [PATCH v2 04/12] media: iris: Add helper to create a context bank device Vikash Garodia
2026-08-06  8:57   ` Dmitry Baryshkov
2026-08-06 10:08     ` Vikash Garodia
2026-08-06 10:18       ` Krzysztof Kozlowski
2026-07-31 18:22 ` [PATCH v2 05/12] media: iris: Route buffers to the matching " Vikash Garodia
2026-08-06  9:03   ` Dmitry Baryshkov
2026-07-31 18:22 ` [PATCH v2 06/12] media: iris: Skip DMA mask setup when the core device has no IOMMU Vikash Garodia
2026-07-31 18:22 ` [PATCH v2 07/12] media: iris: Create pixel and non-pixel context banks on VPU3x Vikash Garodia
2026-08-06  9:07   ` Dmitry Baryshkov
2026-08-06 10:06     ` Vikash Garodia
2026-08-06 10:53       ` Dmitry Baryshkov
2026-07-31 18:22 ` [PATCH v2 08/12] arm64: dts: qcom: hamoa: Add Iris context bank subnodes Vikash Garodia
2026-07-31 18:22 ` [PATCH v2 09/12] arm64: dts: qcom: sm8550: " Vikash Garodia
2026-07-31 18:22 ` [PATCH v2 10/12] arm64: dts: qcom: lemans: " Vikash Garodia
2026-07-31 18:22 ` [PATCH v2 11/12] arm64: dts: qcom: monaco: " Vikash Garodia
2026-07-31 18:22 ` [PATCH v2 12/12] arm64: dts: qcom: sm8650: " Vikash Garodia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=353172fa-8acf-4055-a777-021177761fcc@oss.qualcomm.com \
    --to=vikash.garodia@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=andersson@kernel.org \
    --cc=bod@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel@quora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dikshita.agarwal@oss.qualcomm.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stanimir.varbanov@linaro.org \
    --cc=stephan.gerhold@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®