From: Paolo Abeni <pabeni@redhat.com>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>,
Rasesh Mody <rmody@marvell.com>
Cc: GR-Linux-NIC-Dev@marvell.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Michael Chan <mchan@broadcom.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH v2] bnx2: remove deadcode in bnx2_init_cpus()
Date: Tue, 21 Feb 2023 10:38:52 +0100 [thread overview]
Message-ID: <35332e079ffea4cc91a4d21fdbf9d2ba244ac203.camel@redhat.com> (raw)
In-Reply-To: <20230219152225.3339-1-korotkov.maxim.s@gmail.com>
On Sun, 2023-02-19 at 18:22 +0300, Maxim Korotkov wrote:
> The load_cpu_fw function has no error return code
> and always returns zero. Checking the value returned by
> this function does not make sense.
> As a result, bnx2_init_cpus() will also return only zero
> Therefore, it will be safe to change the type of functions
> to void and remove checking
>
> Found by Security Code and Linux Verification
> Center (linuxtesting.org) with SVACE
>
> Fixes: 57579f7629a3 ("bnx2: Use request_firmware()")
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
I agree with Vadim, this looks like net-next material.
The net-next tree is currently closed. Please re-post when net-next re-
opens, in ~2 weeks, with the Fixes tag stripped.
Thanks!
Paolo
prev parent reply other threads:[~2023-02-21 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 15:22 Maxim Korotkov
2023-02-20 8:31 ` Leon Romanovsky
2023-02-20 16:30 ` Vadim Fedorenko
2023-02-21 9:38 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35332e079ffea4cc91a4d21fdbf9d2ba244ac203.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=korotkov.maxim.s@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rmody@marvell.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®