From: Dan Carpenter <dan.carpenter@linaro.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Boqun Feng <boqun.feng@gmail.com>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] rcu: mollify sparse with RCU guard
Date: Mon, 25 Mar 2024 21:28:32 +0300 [thread overview]
Message-ID: <35355d02-3eef-4860-847b-b7bbf05f4a31@moroto.mountain> (raw)
In-Reply-To: <055111792727869a98c1fa693014e0b6f5d256ea.camel@sipsolutions.net>
On Mon, Mar 25, 2024 at 05:41:22PM +0100, Johannes Berg wrote:
> Also __acquire()/__release() are just empty macros without __CHECKER__.
> So not sure the indirection really is warranted for this special case.
>
> I can add a comment in there, I guess, something like
>
> /* sparse doesn't actually "call" cleanup functions */
>
> perhaps. That reminds me I forgot to CC Dan ...
>
These are Sparse warnings, not Smatch warning... Smatch doesn't use any
of the Sparse locking annotations. Smatch handles cleanup basically
correctly at this point.
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-25 18:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 10:16 Johannes Berg
2024-03-25 16:35 ` Boqun Feng
2024-03-25 16:41 ` Johannes Berg
2024-03-25 17:33 ` Boqun Feng
2024-03-25 18:28 ` Dan Carpenter [this message]
2024-03-25 18:43 ` Johannes Berg
2024-03-26 7:39 ` Dan Carpenter
2024-03-26 7:53 ` Johannes Berg
2024-03-26 8:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35355d02-3eef-4860-847b-b7bbf05f4a31@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®