From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 843E2EE642D for ; Fri, 15 Sep 2023 07:30:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231679AbjIOHam (ORCPT ); Fri, 15 Sep 2023 03:30:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230454AbjIOHak (ORCPT ); Fri, 15 Sep 2023 03:30:40 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB35819A0; Fri, 15 Sep 2023 00:30:30 -0700 (PDT) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38F5ojZZ027770; Fri, 15 Sep 2023 07:30:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=0aoJQXs5a5YpMC9TB/mzvmcpBsQ1TKgx4DzZPRCsOgs=; b=LoGyzvll83UFWLAz3ModENzqRJPPIKwSZFAdCRnMQvzkwdvprXgAPwvqneR0uGYRsZJR QILpTic3nCTUjtrLFlAfdzMkWECAGIMbdXqPGCuu21xjb4AjmfP/xXV20l+dZz0gqc7L ZOlXqy8/HNe5gH8OytzCanhJCj+2ENYJQcmZeFw4dH2EOXG9t34zrdUO29W4VpMMPQ28 QC2xLNflb4md1mb5Lb2i1Dx7878+jO82eNU0zC0+Eq2uQW/D3MjLAV1/tTfvq3VXA94U 2pQlX/Y4xfkaoEu/jTIpIYdNEsP4pKbssT1iht7Gd1PvDJLNa7IBRt7Pdk/P4LJruIny fA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t4g3grc6d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 07:30:27 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38F7UQY2024463 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 07:30:26 GMT Received: from [10.239.132.204] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Fri, 15 Sep 2023 00:30:19 -0700 Message-ID: <35371580-8e5a-4f72-aec2-951268c296a3@quicinc.com> Date: Fri, 15 Sep 2023 15:30:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl To: Krzysztof Kozlowski , , , , , , , CC: , , , , , , , , , , References: <20230915015808.18296-1-quic_tengfan@quicinc.com> <20230915015808.18296-2-quic_tengfan@quicinc.com> <6f40ee72-b763-c58d-44df-ea40d1309820@linaro.org> From: Tengfei Fan In-Reply-To: <6f40ee72-b763-c58d-44df-ea40d1309820@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: EqlzQTQnyulRjQvO_Zf0EtJ954qEv6h6 X-Proofpoint-ORIG-GUID: EqlzQTQnyulRjQvO_Zf0EtJ954qEv6h6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-15_05,2023-09-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 mlxlogscore=698 phishscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309150064 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 9/15/2023 3:04 PM, Krzysztof Kozlowski 写道: > On 15/09/2023 03:58, Tengfei Fan wrote: >> Add device tree binding Documentation details for Qualcomm SM4450 >> TLMM device. >> >> Signed-off-by: Tengfei Fan > > ... > >> + >> +patternProperties: >> + "-state$": >> + oneOf: >> + - $ref: "#/$defs/qcom-sm4450-tlmm-state" >> + - patternProperties: >> + "-pins$": >> + $ref: "#/$defs/qcom-sm4450-tlmm-state" >> + additionalProperties: false >> + >> +$defs: >> + qcom-sm4450-tlmm-state: >> + type: object >> + description: >> + Pinctrl node's client devices use subnodes for desired pin configuration. >> + Client device subnodes use below standard properties. >> + $ref: qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state >> + unevaluatedProperties: false >> + >> + properties: >> + pins: >> + description: >> + List of gpio pins affected by the properties specified in this >> + subnode. >> + items: >> + oneOf: >> + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9])$" > > This is still wrong. How many GPIOs do you have? Please open existing > bindings for recent device (e.g. sm8550) and look how it is done there. yes, will update to "^gpio([0-9]|[1-9][0-9]|1[0-2][0-5])$". > > ... > > >> + >> +examples: >> + - | >> + #include >> + tlmm: pinctrl@f100000 { >> + compatible = "qcom,sm4450-tlmm"; >> + reg = <0x0f100000 0x300000>; >> + gpio-controller; >> + #gpio-cells = <2>; >> + gpio-ranges = <&tlmm 0 0 137>; >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + interrupts = ; > > Missing example pieces. Again, please base your work on other recent files. yes, will reference other platform, and update > >> + }; >> +... > > Best regards, > Krzysztof > -- Thx and BRs, Tengfei Fan