mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Schwarz <eas@sw-optimization.com>
To: Chengfeng Ye <dg573847474@gmail.com>
Cc: yuyunbo519@gmail.com, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, christophe.jaillet@wanadoo.fr,
	vkoul@kernel.org, logang@deltatee.com
Subject: Re: [PATCH v2] dmaengine: plx_dma: Fix potential deadlock on &plxdev->ring_lock
Date: Mon, 28 Aug 2023 18:18:07 +0200	[thread overview]
Message-ID: <3545b782-756a-3d2a-d192-8b224a783c13@sw-optimization.com> (raw)
In-Reply-To: <20230729175952.4068-1-dg573847474@gmail.com>

Hello,

Am 29.07.2023 um 19:59 schrieb Chengfeng Ye:
> This flaw was found by an experimental static analysis tool I am developing
> for irq-related deadlock.

Just out of curiosity, did/could
- Linux kernel config checks like CONFIG_DEBUG_SPINLOCK option or
- Smatch [1]
find that issue too?

I have also found an article from Dan Carpenter on the net about lock 
checking capability of Smatch which relates IMHO to what you are doing [2].

The question is, whether the checks/algorithm what you have developed 
already exists in form of other tools or they might be added to an 
already existing one, which is already spread across the community and 
used accordingly.

Many thanks for your reply in advance.

[1] https://github.com/error27/smatch
[2] https://blogs.oracle.com/linux/post/writing-the-ultimate-locking-check

Cheers
Eric

  parent reply	other threads:[~2023-08-28 16:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-29 17:59 Chengfeng Ye
2023-07-30 23:50 ` Logan Gunthorpe
2023-08-28 16:18 ` Eric Schwarz [this message]
2023-08-29  3:10   ` Chengfeng Ye
2023-08-29 11:05     ` Eric Schwarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3545b782-756a-3d2a-d192-8b224a783c13@sw-optimization.com \
    --to=eas@sw-optimization.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dg573847474@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=vkoul@kernel.org \
    --cc=yuyunbo519@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®