From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16743C04EB9 for ; Mon, 3 Dec 2018 23:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF5542073D for ; Mon, 3 Dec 2018 23:57:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PNVH2UHa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF5542073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726112AbeLCX5N (ORCPT ); Mon, 3 Dec 2018 18:57:13 -0500 Received: from mail-yb1-f193.google.com ([209.85.219.193]:38277 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbeLCX5N (ORCPT ); Mon, 3 Dec 2018 18:57:13 -0500 Received: by mail-yb1-f193.google.com with SMTP id u103-v6so6091533ybi.5; Mon, 03 Dec 2018 15:57:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oCbKmDJcpfxiThOcPgBo21OxlYQOzcrLXTNLDi5lHTo=; b=PNVH2UHaETaIpZttZsQJCbG90h4J9Lb9/7wesnvwUXGPg663TIAKJoBMur8cqm+X5D /GLb+1f8MNaLx4aRCawMtmcyFTvb5GaHJ7PEf3zKbg8bzqoSZR5Mox06rGv+ipQNV1Fq gjQ9l1C0Rj2Q1IkHCXWwU90mcIDQ7nveUHhhvUj+GeiSBAOnDbYO8X6+3wrgiaVPzZYN RkKj9dw76x4OYGn8cG6XUzNl+B3g6B/NuAVpd9fEqpJ2jd9IXIHz/5j9ALWTln5S0mzn cH7BQWZ4v1bmuWUP67Yeqcm0n/SJPmNhm0XAjFr5v1ykVw4g2MPSJJZvcasQjukvFicP EjTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=oCbKmDJcpfxiThOcPgBo21OxlYQOzcrLXTNLDi5lHTo=; b=B54+ZB80HbL6SWevq1OwzADDY+KO8fFdP3dgXn0D3oINi46+Asx8UAaUs6yyaDbctP oYj+M1Zj1sIsd9NGJAUQtszE4SLe3pL5lL4oZvZBX4Li2QwCCBwT/vOkEtlLmFqObYu3 EGxCmFT58Gz3vOhuckdJlAEq/Q0LJWsZj10gz0iPYqkHozjHg/buU0jGAZnl4MrUjBd6 BNa9TuZ1QWbvThsdWN5B/BELRGO5gOuzDto8IaSQtgjz5P+nqmI09IAHkaGB3KNx//po qARnyWQm0pIWZNQ7qve/q9rt+SeqiROdx/yOEarzi6pKD+XDKib4ta0zFMRaZUXRqN1Z 6EGQ== X-Gm-Message-State: AA+aEWYdr1Gr1Dx5WyPxp5YVFRjvpyFzkPfu96aMIEX3+j9jeOWVDZvj 9/tkbZO0qzWnkgxyxRHZbp8= X-Google-Smtp-Source: AFSGD/XcGpGBXIIHbukcsjYLCjC6qF3VaAVxxsmVQoPbPjLetJ/gHvfCfGfw+mqpMCEXGptvb+5fRA== X-Received: by 2002:a25:46c5:: with SMTP id t188-v6mr17578118yba.108.1543881431369; Mon, 03 Dec 2018 15:57:11 -0800 (PST) Received: from [10.67.49.9] (igp-prod-emp-gw.vpn.broadcom.com. [192.19.223.250]) by smtp.googlemail.com with ESMTPSA id x82sm3614662ywb.34.2018.12.03.15.57.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Dec 2018 15:57:10 -0800 (PST) Subject: Re: [RFC PATCH net-next 2/5] net: 8021q: vlan_dev: add vid tag for uc and mc address lists To: davem@davemloft.net, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jiri@mellanox.com, andrew@lunn.ch References: <20181203184023.3430-1-ivan.khoronzhuk@linaro.org> <20181203184023.3430-3-ivan.khoronzhuk@linaro.org> <20181203235119.GF23230@khorivan> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: <35479973-2d2d-d673-f7ab-54d6369ce3d1@gmail.com> Date: Mon, 3 Dec 2018 15:57:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181203235119.GF23230@khorivan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/3/18 3:51 PM, Ivan Khoronzhuk wrote: > On Mon, Dec 03, 2018 at 02:17:00PM -0800, Florian Fainelli wrote: >> On 12/3/18 10:40 AM, Ivan Khoronzhuk wrote: >>> Update vlan mc and uc addresses with VID tag while propagating address >>> set to lower devices, do this only if address is not synched. It allows >>> on end driver level to distinguish address belonging to vlans. >> >> Underlying driver for the real device would be able to properly identify >> that you are attempting to add an address to a virtual device, which >> happens to be of VLAN kind so I am really not sure this is the right >> approach here. >> >> From there, it seems to me that we have two situations: >> >> - each of your network devices expose VLAN devices directly on top of >> the real device, in which case your driver should support >> ndo_vlan_rx_add_vid and ndo_vlan_rx_kill_vid to know when VLAN devices >> are create and maintain a VLAN device to VID correspondence if it needs >> to when being called while setting the addresses >> >> - you are setting up a bridge that is VLAN aware on one of your bridge >> ports, and there you can use switchdev to learn about such events and >> know about both addresses as well as VIDs that must be programmed into >> your real device > No limits to have any "middle" device between real end device and > virtual one, not only a bridge, but also other kind. And as it's generic > change, it should cover all such cases, the simplest example is: > real_dev/macvlan/vlan. It is not generic if the additional information is a VLAN ID, that construct does not apply to all types of virtual devices, that is part of my issue with the extra VID that is being added. If this was a void * priv and any virtual device could pass up/down information that might be more acceptable. > >> >> It seems to me that what you need may be something like either: >> >> - notifications on slave devices when addresses are added via >> ndo_set_rxmode() >> >> or >> >> - dev_{uc,mc}_sync() should be augmented with a "source net_device" >> argument which allows you to differentiate which network device is the >> source of the address programming. That way, no need to "hash" the MAC >> address with a VID, any network device specific information can be >> provided and in the real device driver you can do: if >> (netif_is_vlan()... etc.) > No issue to retrieve vlan dev if it's directly on top of real dev. > Issue is to get it when it's not directly connected as it's not in > vlan_info group list. Who knows what else can be "structed" on top of > real dev till the vlan device. Please look on reply for cover letter, > as it seems requires similar response. In that case, there are notifications generated that you must be listening to determine whether you have something like a VLAN device on top of a bond, which is a port member of a bridge, on which one of your real device port is enslaved (yes, it can be that type of stacking). > >> >> Hopefully someone else will chime in. >> >>> >>> Signed-off-by: Ivan Khoronzhuk >>> --- >>>  include/linux/if_vlan.h |  1 + >>>  net/8021q/vlan_core.c   | 10 ++++++++++ >>>  net/8021q/vlan_dev.c    | 26 ++++++++++++++++++++++++++ >>>  3 files changed, 37 insertions(+) >>> >>> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h >>> index 4cca4da7a6de..94657f3c483a 100644 >>> --- a/include/linux/if_vlan.h >>> +++ b/include/linux/if_vlan.h >>> @@ -136,6 +136,7 @@ extern struct net_device >>> *__vlan_find_dev_deep_rcu(struct net_device *real_dev, >>>  extern int vlan_for_each(struct net_device *dev, >>>               int (*action)(struct net_device *dev, int vid, >>>                         void *arg), void *arg); >>> +extern u16 vlan_dev_get_addr_vid(struct net_device *dev, const u8 >>> *addr); >>>  extern struct net_device *vlan_dev_real_dev(const struct net_device >>> *dev); >>>  extern u16 vlan_dev_vlan_id(const struct net_device *dev); >>>  extern __be16 vlan_dev_vlan_proto(const struct net_device *dev); >>> diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c >>> index a313165e7a67..5d17947d6988 100644 >>> --- a/net/8021q/vlan_core.c >>> +++ b/net/8021q/vlan_core.c >>> @@ -454,6 +454,16 @@ bool vlan_uses_dev(const struct net_device *dev) >>>  } >>>  EXPORT_SYMBOL(vlan_uses_dev); >>> >>> +u16 vlan_dev_get_addr_vid(struct net_device *dev, const u8 *addr) >>> +{ >>> +    u16 vid = 0; >>> + >>> +    vid = addr[dev->addr_len]; >>> +    vid |= (addr[dev->addr_len + 1] & 0xf) << 8; >>> +    return vid; >>> +} >>> +EXPORT_SYMBOL(vlan_dev_get_addr_vid); >>> + >>>  static struct sk_buff *vlan_gro_receive(struct list_head *head, >>>                      struct sk_buff *skb) >>>  { >>> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c >>> index b2d9c8f27cd7..c05b313314b7 100644 >>> --- a/net/8021q/vlan_dev.c >>> +++ b/net/8021q/vlan_dev.c >>> @@ -250,6 +250,14 @@ void vlan_dev_get_realdev_name(const struct >>> net_device *dev, char *result) >>>      strncpy(result, vlan_dev_priv(dev)->real_dev->name, 23); >>>  } >>> >>> +static void vlan_dev_set_addr_vid(struct net_device *vlan_dev, u8 >>> *addr) >>> +{ >>> +    u16 vid = vlan_dev_vlan_id(vlan_dev); >>> + >>> +    addr[vlan_dev->addr_len] = vid & 0xff; >>> +    addr[vlan_dev->addr_len + 1] = (vid >> 8) & 0xf; >>> +} >>> + >>>  bool vlan_dev_inherit_address(struct net_device *dev, >>>                    struct net_device *real_dev) >>>  { >>> @@ -481,8 +489,26 @@ static void vlan_dev_change_rx_flags(struct >>> net_device *dev, int change) >>>      } >>>  } >>> >>> +static void vlan_dev_align_addr_vid(struct net_device *vlan_dev) >>> +{ >>> +    struct net_device *real_dev = vlan_dev_real_dev(vlan_dev); >>> +    struct netdev_hw_addr *ha; >>> + >>> +    if (!real_dev->vid_len) >>> +        return; >>> + >>> +    netdev_for_each_mc_addr(ha, vlan_dev) >>> +        if (!ha->sync_cnt) >>> +            vlan_dev_set_addr_vid(vlan_dev, ha->addr); >>> + >>> +    netdev_for_each_uc_addr(ha, vlan_dev) >>> +        if (!ha->sync_cnt) >>> +            vlan_dev_set_addr_vid(vlan_dev, ha->addr); >>> +} >>> + >>>  static void vlan_dev_set_rx_mode(struct net_device *vlan_dev) >>>  { >>> +    vlan_dev_align_addr_vid(vlan_dev); >>>      dev_mc_sync(vlan_dev_priv(vlan_dev)->real_dev, vlan_dev); >>>      dev_uc_sync(vlan_dev_priv(vlan_dev)->real_dev, vlan_dev); >>>  } >>> >> >> >> --  >> Florian > -- Florian