From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tingguo Cheng <quic_tingguoc@quicinc.com>,
quic_fenglinw@quicinc.com, quic_tingweiz@quicinc.com,
kernel@quicinc.com, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs615: Adds SPMI bus, PMIC and peripherals
Date: Mon, 14 Oct 2024 12:45:31 +0200 [thread overview]
Message-ID: <354b544e-3799-4421-aeb3-8401dffb34d6@kernel.org> (raw)
In-Reply-To: <20241014-adds-spmi-pmic-peripherals-for-qcs615-v1-1-8a3c67d894d8@quicinc.com>
On 14/10/2024 12:08, Tingguo Cheng wrote:
> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> index 4ef969a6af150933c72a7a83374a5a2657eebc1b..b79c22730920e3097425e1d1933e744205b3c18e 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> @@ -6,6 +6,7 @@
>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include "qcs615.dtsi"
> +#include "qcs615-pmic.dtsi"
> / {
> model = "Qualcomm Technologies, Inc. QCS615 Ride";
> compatible = "qcom,qcs615-ride", "qcom,qcs615";
> diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> index ac4c4c751da1fbb28865877555ba317677bc6bd2..9793161db515a2ef1df6465c8d0a04a11e71ffc1 100644
> --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
> @@ -517,6 +517,29 @@ sram@c3f0000 {
> reg = <0x0 0x0c3f0000 0x0 0x400>;
> };
>
> + spmi_bus: qcom,spmi@c440000 {
Please do not send your downstream code... Don't just copy and paste
that stuff.
Rewrite it from scratch or use the upstream as template. I find it waste
of time to comment or fix the same issue over and over again. The
problem is the way you work - copying and sending downstream at us. This
must stop.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-14 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 10:08 Tingguo Cheng
2024-10-14 10:45 ` Krzysztof Kozlowski [this message]
2024-10-22 8:34 ` Tingguo Cheng
2024-10-14 10:53 ` Dmitry Baryshkov
2024-10-22 8:26 ` Tingguo Cheng
2024-10-22 9:38 ` Dmitry Baryshkov
2024-10-23 10:25 ` Tingguo Cheng
2024-10-23 16:34 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=354b544e-3799-4421-aeb3-8401dffb34d6@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_fenglinw@quicinc.com \
--cc=quic_tingguoc@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®