From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751196AbdK0EAl (ORCPT ); Sun, 26 Nov 2017 23:00:41 -0500 Received: from ale.deltatee.com ([207.54.116.67]:52842 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbdK0EAk (ORCPT ); Sun, 26 Nov 2017 23:00:40 -0500 To: Joe Perches , Julia Lawall Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft References: <20171126054037.9743-1-logang@deltatee.com> <1511676085.20482.18.camel@perches.com> <5c0a2778-8e8f-9fbb-b13f-1d880acb949b@deltatee.com> <1511735382.20482.27.camel@perches.com> From: Logan Gunthorpe Message-ID: <355029d1-48f5-095e-0d99-bb726d2d56e5@deltatee.com> Date: Sun, 26 Nov 2017 21:00:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1511735382.20482.27.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 68.147.191.165 X-SA-Exim-Rcpt-To: apw@canonical.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr, joe@perches.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/11/17 03:29 PM, Joe Perches wrote: > This proposal has a very high false positive rate. The only actual false positive you've pointed out is the one that is just incorrect in the wrong way (the author should have used a KERN_CONT but did not). I could easily do something similar to what Julia proposes and produce a different warning if the string ends in a space. But I don't see any bullet proof way for any script to deduce what the author actually meant. > Keep at it though. > Maybe something useful will be produced with more effort. Unless there's more actually constructive criticism I don't think I'll be getting any further with this. Logan