From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbdFNKzG (ORCPT ); Wed, 14 Jun 2017 06:55:06 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:46639 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbdFNKzD (ORCPT ); Wed, 14 Jun 2017 06:55:03 -0400 X-AuditID: b6c32a36-f79446d000002bcd-50-594116058d53 From: Bartlomiej Zolnierkiewicz To: Christophe JAILLET Cc: khoroshilov@ispras.ru, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] sm501fb: Silence a coccinelle script warning. Date: Wed, 14 Jun 2017 12:54:58 +0200 Message-id: <3551083.sIQ6JeN0q9@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170508061116.31471-1-christophe.jaillet@wanadoo.fr> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPIsWRmVeSWpSXmKPExsWy7bCmri6rmGOkwd37bBZbD85ltdh6S9pi x7qd7BYn+j6wWlzeNYfNgdVjxr+pjB6fN8l5fL67njWAOYrLJiU1J7MstUjfLoEr48KcdWwF K/kqGl5MZmlgvMXdxcjJISFgItE46SwrhC0mceHeerYuRi4OIYEdjBJLjt5hhnA+M0ocvzWb Babj1rcljBCJtYwS57/ugHK+Mkrs+HCcCaSKTcBKYmL7KkYQW0TATGJu321mEJtZoFzi87tj YPuEBZwkpqxZBRZnEVCVaH6zFayXV0BTYsKRZ2C9ogJeElv2tYPFOQWcJZ7db2aFqBGU+DH5 HgvETHmJffunskLYOhJnj60DO0hC4DubxMy1XexdjBxAjqzEpgPMEB+4SBzau4IJwhaWeHV8 CzuELSXR+PIhVHw6o8T23xIQczYzSqzaPQGqyFri8PGLUMv4JN597WGFmM8r0dEmBFHiIbHp wQY2CNtRYt+6VdBgnMYo8f7YRtYJjPKzkPwwC8kPs5D8sICReRWjWGpBcW56arFhgZFecWJu cWleul5yfu4mRnCy0DLbwbjonM8hRgEORiUe3o639pFCrIllxZW5hxglOJiVRHglzjtECvGm JFZWpRblxxeV5qQWH2KU5mBREucVXX8tQkggPbEkNTs1tSC1CCbLxMEp1cAosOBP7e1DL6c1 tL/tmPSrY/KJcwWPS9wKErbdefncRpBFc32rquhJzXWfRNof31aV1l+4ld+I500Oc7C395HQ qXVat7bEf3qfn3dJ8ZZWzdR+ny37p+6dmXf50/mNcf4P+KvfW794+PlI31/p2FmyTbaHZFew H1S/8H9jtqn8jL72PVpZ79N/KrEUZyQaajEXFScCAJnERdYSAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsVy+t9jQV0WMcdIg7ubDCy2HpzLarH1lrTF jnU72S1O9H1gtbi8aw6bA6vHjH9TGT0+b5Lz+Hx3PWsAc5SbTUZqYkpqkUJqXnJ+SmZeuq1S aIibroWSQl5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMi7MWcdWsJKvouHFZJYG xlvcXYycHBICJhK3vi1hhLDFJC7cW8/WxcjFISSwmlHi08E1LBDOV0aJdS8vsoBUsQlYSUxs XwXWISJgJjG37zYziM0sUC5xdfIpVhBbWMBJYsqaVWBxFgFVieY3W5lAbF4BTYkJR56B9YoK eEls2dcOFucUcJZ4dr+ZFWLZDEaJ+Zeb2CEaBCV+TL7HArFAXmLf/qmsELaWxPqdx5kmMArM QlI2C0nZLCRlCxiZVzFypRYU56bnFhsVGG5iBEbItsNa/jsYf5yNPsQowMGoxMP74L19pBBr YllxZe4hRgkOZiURXonzDpFCvCmJlVWpRfnxRaU5qcWHGE2BfprILCWanA+M3rySeEMTSyMT AzMzQyMDYzMlcd4JgV8ihATSE0tSs1NTC1KLYPqYODilGhiL84+1B3hzNB+cmf1dsuYdU8aL bfO/92lseulgeUXo1Nf9+7xvWW20yLs+JWdHWMOuH/NWs1zeEXdmtXJ5ta5r/NLS8Bv+9qlt B47ddRWuvXtP0vTEqss3tPh/W/2Uf1F2xkxXZNrsL0wlL7O/vLn6xfaSXW3+5YAvyzmuBJnG lPHlxHFNidNRYinOSDTUYi4qTgQAtg9eVKYCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170614105500epcas1p10945960a81e451c75af70790a283d5bd X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170508061141epcas3p4d89f8f964dbe8a327de1abf80da94e6a X-RootMTR: 20170508061141epcas3p4d89f8f964dbe8a327de1abf80da94e6a References: <20170508061116.31471-1-christophe.jaillet@wanadoo.fr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday, May 08, 2017 08:11:16 AM Christophe JAILLET wrote: > According to surrounding goto, it is likely that 'goto err_probed_panel' is > expected here. > This change is just done in order to silence some coccinelle scripts > which try to detect wrongly ordered goto. > > If 'info->fb[HEAD_PANEL]' and' 'info->fb[HEAD_CRT]' are both NULL, this > means that no 'framebuffer_alloc' has been performed, so 'goto err_alloc' > looks fine. > Anyway, it is also harmless in this case to call 'framebuffer_release'. > The code looks more straight forward. > > Signed-off-by: Christophe JAILLET It seems that the code for supporting only selected framebuffers (only HEAD_PANEL fb or only HEAD_CRT fb) is broken anyway as at least the suspend/resume support assumes that both framebuffers are always present. Also all sm501fb driver users always try try to initialize both framebuffers. Therefore I would prefer the removal of non-working individual framebuffers support (the code that your patch modifies would be removed as well). Could you please look into it? > --- > drivers/video/fbdev/sm501fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c > index 67e314fdd947..4d89b045ce40 100644 > --- a/drivers/video/fbdev/sm501fb.c > +++ b/drivers/video/fbdev/sm501fb.c > @@ -1990,7 +1990,7 @@ static int sm501fb_probe(struct platform_device *pdev) > info->fb[HEAD_CRT] == NULL) { > dev_err(dev, "no framebuffers found\n"); > ret = -ENODEV; > - goto err_alloc; > + goto err_probed_panel; > } > > /* get the resources for both of the framebuffers */ Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics