From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756015AbdKCQXq (ORCPT ); Fri, 3 Nov 2017 12:23:46 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:42921 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752688AbdKCQXp (ORCPT ); Fri, 3 Nov 2017 12:23:45 -0400 Subject: Re: [PATCH 3/6] hugetlb: expose hugetlbfs_inode_info in header To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, aarcange@redhat.com, hughd@google.com, nyc@holomorphy.com References: <20171031184052.25253-1-marcandre.lureau@redhat.com> <20171031184052.25253-4-marcandre.lureau@redhat.com> <30bfff65-4cb9-a6b6-ab31-73d767a4b8ae@oracle.com> <1675520780.35881890.1509725683143.JavaMail.zimbra@redhat.com> From: Mike Kravetz Message-ID: <3551915a-93bb-35ef-0062-e462357c9098@oracle.com> Date: Fri, 3 Nov 2017 09:23:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1675520780.35881890.1509725683143.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/2017 09:14 AM, Marc-André Lureau wrote: > Hi > > ----- Original Message ----- >> On 10/31/2017 11:40 AM, Marc-André Lureau wrote: >>> The following patch is going to access hugetlbfs_inode_info field from >>> mm/shmem.c. >> >> The code looks fine. However, I would prefer something different for the >> commit message. Perhaps something like: >> >> hugetlbfs inode information will need to be accessed by code in mm/shmem.c >> for file sealing operations. Move inode information definition from .c >> file to header for needed access. > > Ok, Does the patch get your Reviewed-by tag with that change? > > thanks > Yes, you can add Reviewed-by: Mike Kravetz with an updated commit message. -- Mike Kravetz