From: Joe Perches <joe@perches.com>
To: Kai Ye <yekai13@huawei.com>,
gregkh@linuxfoundation.org, linux-accelerators@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
zhangfei.gao@linaro.org, wangzhou1@hisilicon.com
Subject: Re: [PATCH] uacce: add print information if not enable sva
Date: Fri, 04 Jun 2021 00:57:00 -0700 [thread overview]
Message-ID: <3556ef50697435a04d8bbbc4a9201f3a2323476d.camel@perches.com> (raw)
In-Reply-To: <1622792769-28017-1-git-send-email-yekai13@huawei.com>
On Fri, 2021-06-04 at 15:46 +0800, Kai Ye wrote:
> Add print information necessary if user not enable sva.
[]
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
[]
> @@ -387,15 +387,22 @@ static void uacce_release(struct device *dev)
>
>
> static unsigned int uacce_enable_sva(struct device *parent, unsigned int flags)
> {
> + int ret;
[]
> + ret = iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_IOPF);
> + if (ret) {
> + dev_err(parent, "failed to enable IOPF feature! ret = %d\n", ret);
Perhaps use %pe, ERR_PTR(ret) to get descriptive error output
> + dev_err(parent, "failed to enable SVA feature! ret = %d\n", ret);
here too
prev parent reply other threads:[~2021-06-04 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 7:46 Kai Ye
2021-06-04 7:51 ` Greg KH
2021-06-08 1:39 ` yekai(A)
2021-06-09 9:52 ` Greg KH
2021-06-04 7:57 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3556ef50697435a04d8bbbc4a9201f3a2323476d.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=yekai13@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®