mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jeongjun Park <aha310510@gmail.com>
Cc: linux-wireless@vger.kernel.org,
	 syzbot+81cd9dc1596563141d19@syzkaller.appspotmail.com,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: mac80211: fix NULL pointer dereference in ieee80211_mesh_build_beacon()
Date: Tue, 20 Jan 2026 09:12:31 +0100	[thread overview]
Message-ID: <35581fc687d151b2b4fabccb6952d567cac65240.camel@sipsolutions.net> (raw)
In-Reply-To: <20260119150031.201832-1-aha310510@gmail.com> (sfid-20260119_160223_485174_E37F681D)

On Tue, 2026-01-20 at 00:00 +0900, Jeongjun Park wrote:
> NULL pointer dereference bug occurs because ieee80211_mesh_build_beacon()
> does not check the return value of ieee80211_get_sband().
> 
> Therefore, we need to add a return value check to prevent this.

No we don't, please try to understand the code, and why it can even get
here when the mesh interface isn't operating.

johannes

      reply	other threads:[~2026-01-20  8:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 15:00 Jeongjun Park
2026-01-20  8:12 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35581fc687d151b2b4fabccb6952d567cac65240.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=aha310510@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=syzbot+81cd9dc1596563141d19@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®