From: Reinette Chatre <reinette.chatre@intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>,
"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>,
"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Babu Moger <babu.moger@amd.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 6/8] selftests/resctrl: Make benchmark command const and build it with pointers
Date: Thu, 31 Aug 2023 14:25:47 -0700 [thread overview]
Message-ID: <3558a06f-a6c0-9a60-a0f2-c8cedfb7f763@intel.com> (raw)
In-Reply-To: <20230831110843.26719-7-ilpo.jarvinen@linux.intel.com>
Hi Ilpo,
On 8/31/2023 4:08 AM, Ilpo Järvinen wrote:
> Benchmark command is used in multiple tests so it should not be
> mutated by the tests but CMT test alters span argument. Due to the
> order of tests (CMT test runs last), mutating the span argument in CMT
> test does not trigger any real problems currently.
>
> Mark benchmark_cmd strings as const and setup the benchmark command
> using pointers. Because the benchmark command becomes const, the input
> arguments can be used directly. Besides being simpler, using the input
> arguments directly also removes the internal size restriction.
>
> CMT test has to create a copy of the benchmark command before altering
> the benchmark command.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
next prev parent reply other threads:[~2023-08-31 21:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 11:08 [PATCH v4 0/8] selftests/resctrl: Rework benchmark command handling Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 1/8] selftests/resctrl: Ensure the benchmark commands fits to its array Ilpo Järvinen
2023-08-31 21:25 ` Reinette Chatre
2023-09-01 9:18 ` Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 2/8] selftests/resctrl: Correct benchmark command help Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 3/8] selftests/resctrl: Remove bw_report and bm_type from main() Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 4/8] selftests/resctrl: Simplify span lifetime Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 5/8] selftests/resctrl: Reorder resctrl FS prep code and benchmark_cmd init Ilpo Järvinen
2023-08-31 21:25 ` Reinette Chatre
2023-08-31 11:08 ` [PATCH v4 6/8] selftests/resctrl: Make benchmark command const and build it with pointers Ilpo Järvinen
2023-08-31 21:25 ` Reinette Chatre [this message]
2023-08-31 11:08 ` [PATCH v4 7/8] selftests/resctrl: Remove ben_count variable Ilpo Järvinen
2023-08-31 11:08 ` [PATCH v4 8/8] selftests/resctrl: Cleanup benchmark argument parsing Ilpo Järvinen
2023-08-31 21:26 ` Reinette Chatre
2023-09-01 5:28 ` [PATCH v4 0/8] selftests/resctrl: Rework benchmark command handling Maciej Wieczór-Retman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3558a06f-a6c0-9a60-a0f2-c8cedfb7f763@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome