From: hpa@zytor.com
To: David Laight <David.Laight@ACULAB.COM>,
"'Brian Gerst'" <brgerst@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Sedat Dilek <sedat.dilek@gmail.com>,
stable <stable@vger.kernel.org>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"kernelci . org bot" <bot@kernelci.org>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Ilie Halip <ilie.halip@gmail.com>,
the arch/x86 maintainers <x86@kernel.org>,
Marco Elver <elver@google.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Daniel Axtens <dja@axtens.net>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"clang-built-linux@googlegroups.com"
<clang-built-linux@googlegroups.com>
Subject: RE: [PATCH] x86: bitops: fix build regression
Date: Thu, 07 May 2020 01:38:26 -0700 [thread overview]
Message-ID: <3559DCF4-0E59-48DF-8500-D4BA2852975D@zytor.com> (raw)
In-Reply-To: <ef7d077424554abebbd0d46738c90163@AcuMS.aculab.com>
On May 7, 2020 1:35:01 AM PDT, David Laight <David.Laight@ACULAB.COM> wrote:
>From: hpa@zytor.com
>> Sent: 07 May 2020 08:59
>> On May 7, 2020 12:44:44 AM PDT, David Laight
><David.Laight@ACULAB.COM> wrote:
>> >From: Brian Gerst
>> >> Sent: 07 May 2020 07:18
>> >...
>> >> > --- a/arch/x86/include/asm/bitops.h
>> >> > +++ b/arch/x86/include/asm/bitops.h
>> >> > @@ -54,7 +54,7 @@ arch_set_bit(long nr, volatile unsigned long
>> >*addr)
>> >> > if (__builtin_constant_p(nr)) {
>> >> > asm volatile(LOCK_PREFIX "orb %1,%0"
>> >> > : CONST_MASK_ADDR(nr, addr)
>> >> > - : "iq" (CONST_MASK(nr) & 0xff)
>> >> > + : "iq" ((u8)(CONST_MASK(nr) & 0xff))
>> >>
>> >> I think a better fix would be to make CONST_MASK() return a u8
>value
>> >> rather than have to cast on every use.
>> >
>> >Or assign to a local variable - then it doesn't matter how
>> >the value is actually calculated. So:
>> > u8 mask = CONST_MASK(nr);
>> > asm volatile(LOCK_PREFIX "orb %1,%0"
>> > : CONST_MASK_ADDR(nr, addr)
>> > : "iq" mask
>> >
>> > David
>> >
>> >-
>> >Registered Address Lakeside, Bramley Road, Mount Farm, Milton
>Keynes,
>> >MK1 1PT, UK
>> >Registration No: 1397386 (Wales)
>>
>> "const u8" please...
>
>Why, just a waste of disk space.
>
> David
>
>-
>Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes,
>MK1 1PT, UK
>Registration No: 1397386 (Wales)
Descriptive.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2020-05-07 8:39 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 17:44 Nick Desaulniers
2020-05-05 18:07 ` hpa
2020-05-05 18:22 ` Nick Desaulniers
2020-05-07 11:34 ` Peter Zijlstra
2020-05-07 14:00 ` Brian Gerst
2020-05-07 19:19 ` Nick Desaulniers
2020-05-07 22:29 ` Nick Desaulniers
2020-05-08 1:57 ` Brian Gerst
2020-05-08 17:21 ` Nick Desaulniers
2020-05-08 17:31 ` H. Peter Anvin
2020-05-08 18:05 ` [PATCH v3] " Nick Desaulniers
2020-05-08 18:08 ` Nick Desaulniers
2020-05-08 18:22 ` Brian Gerst
2020-05-08 18:28 ` [PATCH v4] " Nick Desaulniers
2020-05-08 18:32 ` [PATCH v5] " Nick Desaulniers
2020-05-08 20:28 ` Nathan Chancellor
2020-05-08 23:47 ` Jesse Brandeburg
2020-05-09 4:44 ` Sedat Dilek
2020-05-09 12:20 ` Andy Shevchenko
2020-05-09 15:43 ` Brian Gerst
2020-05-11 17:22 ` Nick Desaulniers
2020-05-10 13:54 ` David Laight
2020-05-11 18:52 ` Brian Gerst
2020-05-14 23:47 ` Nick Desaulniers
2020-05-10 11:59 ` [PATCH] " David Laight
2020-05-10 12:33 ` hpa
2020-05-07 19:29 ` hpa
2020-05-06 4:30 ` Nathan Chancellor
2020-05-06 9:22 ` Sedat Dilek
2020-05-06 15:41 ` Nathan Chancellor
2020-05-06 16:37 ` Nick Desaulniers
2020-05-06 16:55 ` Ilie Halip
2020-05-06 17:05 ` [PATCH v2] " Nick Desaulniers
2020-05-07 6:18 ` [PATCH] " Brian Gerst
2020-05-07 7:02 ` hpa
2020-05-07 13:32 ` Brian Gerst
2020-05-07 15:09 ` David Laight
2020-05-07 19:31 ` hpa
2020-05-07 19:29 ` hpa
2020-05-07 7:44 ` David Laight
2020-05-07 7:59 ` hpa
2020-05-07 8:35 ` David Laight
2020-05-07 8:38 ` hpa [this message]
2020-05-07 9:17 ` Andy Shevchenko
2020-05-07 19:22 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3559DCF4-0E59-48DF-8500-D4BA2852975D@zytor.com \
--to=hpa@zytor.com \
--cc=David.Laight@ACULAB.COM \
--cc=andriy.shevchenko@intel.com \
--cc=bot@kernelci.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dja@axtens.net \
--cc=elver@google.com \
--cc=ilie.halip@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=sedat.dilek@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®