From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C745C4338F for ; Sun, 1 Aug 2021 09:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67C10610A1 for ; Sun, 1 Aug 2021 09:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231664AbhHAJ7c (ORCPT ); Sun, 1 Aug 2021 05:59:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:54716 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231527AbhHAJ7b (ORCPT ); Sun, 1 Aug 2021 05:59:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2BB4A610A0; Sun, 1 Aug 2021 09:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627811964; bh=bhp36r6obC2nEqhj0ex5uPhGv2lmRu4DIPjP5sNYcU4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=VusSK5uPj1qQADT0NSKF3MYzdWiB0iyhG83Xt7Z+qNBVUe5pw6IfG1mEZNOtxiHJK Koy+P3ZLTORCedQlOK5p3oHDVVQU4qnwAl3ak2TekEEaaMjgQ9OFht8qV0WQ3Okg73 TOVptpTN+yrFIY3EkJ4HsKhLfhErOqi+ba4Z05emBpxWaQ/bGo3D9jT3g7yh7WkO8o HOs4ndcQ//asBPSG443pF3Pc/qQbHX6oYJYKC8wmWUIqzUCbo1lWVPZrzV1kS/+4Ck 3yj4KOcTwi/bYeTbQhB4sMJH+Hf8iH7CRbr/+QyotuzII78aB0lBvY2DmsowSxuO+i 2ELCskaXwt8aQ== Subject: Re: [f2fs-dev] [PATCH] f2fs: reset free segment to prefree status when do_checkpoint() fail To: Jaegeuk Kim Cc: Yangtao Li , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20210427082106.2755-1-frank.li@vivo.com> <12ae52df-bc5e-82c3-4f78-1eafe7723f93@huawei.com> <5f37995c-2390-e8ca-d002-3639ad39e0d3@kernel.org> <8d2e3a63-72f9-bcb2-24e5-dddd84136001@kernel.org> From: Chao Yu Message-ID: <355ac2ff-f1f1-b9ea-bd8c-139cb24a03fb@kernel.org> Date: Sun, 1 Aug 2021 17:59:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/7/31 6:18, Jaegeuk Kim wrote: > On 07/20, Chao Yu wrote: >> On 2021/7/20 2:25, Jaegeuk Kim wrote: >>> On 07/19, Chao Yu wrote: >>>> On 2021/4/27 20:37, Chao Yu wrote: >>>>> I think just reverting dirty/free bitmap is not enough if checkpoint fails, >>>>> due to we have updated sbi->cur_cp_pack and nat/sit bitmap, next CP tries >>>>> to overwrite last valid meta/node/data, then filesystem will be corrupted. >>>>> >>>>> So I suggest to set cp_error if do_checkpoint() fails until we can handle >>>>> all cases, which is not so easy. >>>>> >>>>> How do you think? >>>> >>>> Let's add below patch first before you figure out the patch which covers all >>>> things. >>>> >>>> From 3af957c98e9e04259f8bb93ca0b74ba164f3f27e Mon Sep 17 00:00:00 2001 >>>> From: Chao Yu >>>> Date: Mon, 19 Jul 2021 16:37:44 +0800 >>>> Subject: [PATCH] f2fs: fix to stop filesystem update once CP failed >>>> >>>> During f2fs_write_checkpoint(), once we failed in >>>> f2fs_flush_nat_entries() or do_checkpoint(), metadata of filesystem >>>> such as prefree bitmap, nat/sit version bitmap won't be recovered, >>>> it may cause f2fs image to be inconsistent, let's just set CP error >>>> flag to avoid further updates until we figure out a scheme to rollback >>>> all metadatas in such condition. >>>> >>>> Reported-by: Yangtao Li >>>> Signed-off-by: Yangtao Li >>>> Signed-off-by: Chao Yu >>>> --- >>>> fs/f2fs/checkpoint.c | 10 +++++++--- >>>> 1 file changed, 7 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c >>>> index 6c208108d69c..096c85022f62 100644 >>>> --- a/fs/f2fs/checkpoint.c >>>> +++ b/fs/f2fs/checkpoint.c >>>> @@ -1639,8 +1639,10 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) >>>> >>>> /* write cached NAT/SIT entries to NAT/SIT area */ >>>> err = f2fs_flush_nat_entries(sbi, cpc); >>>> - if (err) >>>> + if (err) { >>>> + f2fs_stop_checkpoint(sbi, false); >>> >>> I think we should abuse this, since we can get any known ENOMEM as well. >> >> Yup, but one critical issue here is it can break A/B update of NAT area, >> so, in order to fix this hole, how about using NOFAIL memory allocation >> in f2fs_flush_nat_entries() first until we figure out the finial scheme? > > NOFAIL is risky, so how about adding a retry logic on ENOMEM with a message > and then giving up if we can't get the memory? BTW, what about EIO or other > family? How about this? From ffb50d9a8220be7d9e159b8555533adcf11957a8 Mon Sep 17 00:00:00 2001 From: Chao Yu Date: Mon, 19 Jul 2021 16:37:44 +0800 Subject: [PATCH v2] f2fs: fix to stop filesystem update once CP failed During f2fs_write_checkpoint(), once we failed in f2fs_flush_nat_entries() or do_checkpoint(), metadata of filesystem such as prefree bitmap, nat/sit version bitmap won't be recovered, it may cause f2fs image to be inconsistent, let's just set CP error flag to avoid further updates until we figure out a scheme to rollback all metadatas in such condition. Reported-by: Yangtao Li Signed-off-by: Yangtao Li Signed-off-by: Chao Yu --- fs/f2fs/checkpoint.c | 12 +++++++++--- fs/f2fs/node.c | 9 ++++++++- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 6c208108d69c..f3f66871ae42 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -1639,8 +1639,11 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) /* write cached NAT/SIT entries to NAT/SIT area */ err = f2fs_flush_nat_entries(sbi, cpc); - if (err) + if (err) { + f2fs_err(sbi, "f2fs_flush_nat_entries failed err:%d, stop checkpoint", err); + f2fs_stop_checkpoint(sbi, false); goto stop; + } f2fs_flush_sit_entries(sbi, cpc); @@ -1648,10 +1651,13 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) f2fs_save_inmem_curseg(sbi); err = do_checkpoint(sbi, cpc); - if (err) + if (err) { + f2fs_err(sbi, "do_checkpoint failed err:%d, stop checkpoint", err); + f2fs_stop_checkpoint(sbi, false); f2fs_release_discard_addrs(sbi); - else + } else { f2fs_clear_prefree_segments(sbi, cpc); + } f2fs_restore_inmem_curseg(sbi); stop: diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 5840b82ce311..7162836d71c1 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -141,13 +141,20 @@ static struct page *get_next_nat_page(struct f2fs_sb_info *sbi, nid_t nid) void *src_addr; void *dst_addr; struct f2fs_nm_info *nm_i = NM_I(sbi); + bool retried = false; dst_off = next_nat_addr(sbi, current_nat_addr(sbi, nid)); +retry: /* get current nat block page with lock */ src_page = get_current_nat_page(sbi, nid); - if (IS_ERR(src_page)) + if (IS_ERR(src_page)) { + if (PTR_ERR(src_page) == -ENOMEM && !retried) { + retried = true; + goto retry; + } return src_page; + } dst_page = f2fs_grab_meta_page(sbi, dst_off); f2fs_bug_on(sbi, PageDirty(src_page)); -- 2.22.1