From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753564AbcLGETV (ORCPT ); Tue, 6 Dec 2016 23:19:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37704 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbcLGETT (ORCPT ); Tue, 6 Dec 2016 23:19:19 -0500 Subject: Re: [PATCH 07/10] vsock/virtio: add a missing __le annotation To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org References: <1481038106-24899-1-git-send-email-mst@redhat.com> <1481038106-24899-8-git-send-email-mst@redhat.com> Cc: Stefan Hajnoczi , "David S. Miller" , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org From: Jason Wang Message-ID: <356375b7-ccf3-d28f-7a53-90fe9f9a508a@redhat.com> Date: Wed, 7 Dec 2016 12:19:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481038106-24899-8-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 07 Dec 2016 04:19:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年12月06日 23:40, Michael S. Tsirkin wrote: > guest cid is read from config space, therefore it's in little endian > format and is treated as such, annotate it accordingly. > > Signed-off-by: Michael S. Tsirkin > --- > net/vmw_vsock/virtio_transport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c > index 936d7ee..90096b9 100644 > --- a/net/vmw_vsock/virtio_transport.c > +++ b/net/vmw_vsock/virtio_transport.c > @@ -336,7 +336,7 @@ static void virtio_vsock_reset_sock(struct sock *sk) > static void virtio_vsock_update_guest_cid(struct virtio_vsock *vsock) > { > struct virtio_device *vdev = vsock->vdev; > - u64 guest_cid; > + __le64 guest_cid; > > vdev->config->get(vdev, offsetof(struct virtio_vsock_config, guest_cid), > &guest_cid, sizeof(guest_cid)); Reviewed-by: Jason Wang