From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11F62290DBB for ; Thu, 4 Jun 2026 13:41:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780580490; cv=none; b=W0cZQriimfBMZlmmjVtQlhQYW4FOlaqo1KsiUoyNyali5W1uPlOI0JuXz3z4hCgVJxw225jqXte+AK/BBi8mGf1UEGDWqsM5ab59jiiBADd+b8AgSB3DDFdHFP0tMwNm2jQndTlw9Pl9nIGjLiQwB3sWFtt6mumA+JDMYliuV+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780580490; c=relaxed/simple; bh=mqSvrNs6qutA/iyIvRXQBm8ztoMR0I7alP4oXFMUOaE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mS8PAy9Ik3bPNPe6JsPEYavRcw2EYU3n+Htrj3vy+IOrY9SLNgOC29OlVxFRNNuGh1sGNO6EoWqy1d9Cgv0nQU6WcX7T2VMTkOz1AKsvFM6HCngvfauL2SL1hqIuOR3sY97wkNV0aqohEULfOUydPA12s6NssUCa5eke3VJBXUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WIoWbiON; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=QZjIXEnn; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WIoWbiON"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="QZjIXEnn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780580488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=maUWokqTyjYG2hZH87ZqeSI6FwjBdDWqODEJObqKpzg=; b=WIoWbiONtjRCLkbkmuO9EqQ36XMO0k0lKk3uBvKX3O0oQDstMB089SzQ7W/OvK2f1T+weX mFYrI7IADC97sIJnSoU4YTDFFevtHA67/kEHQWk90LwcHpo98f2tNSRPx2D1BZw0UN+mI9 JiAcGr7FjBlIFoYJBtSL39daBqrQOtE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-685-xyijHZDjP4KKFXgXyWdgSg-1; Thu, 04 Jun 2026 09:41:25 -0400 X-MC-Unique: xyijHZDjP4KKFXgXyWdgSg-1 X-Mimecast-MFC-AGG-ID: xyijHZDjP4KKFXgXyWdgSg_1780580484 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4600cf05f07so632516f8f.2 for ; Thu, 04 Jun 2026 06:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780580484; x=1781185284; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=maUWokqTyjYG2hZH87ZqeSI6FwjBdDWqODEJObqKpzg=; b=QZjIXEnnsvvDhI1sFeUCaDftjiPMCNyKzgQI7+1dqAyjGZQuGyApnIu9Nf25eDvDe5 w6Gc0OB1gszMWDytgEz+0jtmmUb5ccIyqQITVASOcp7O6TAaQWdvSXIiEwgRXH1GPt+i rrBNd7G+546FeJDx/VBnBXs/3pQCJqSgL4zm2X/dhdM+oy13taveLVz0c+OBDqFP+jg7 0N1oXvWNjKonhukj/MFlOoCSIVxacobVJiwcWDLeSSS5pjjD8+v0P+v5/T8sboxkCkBk PJEG0Oajo1SAcNYnquZ8gY5hjuRjS9Arlvgz+ZdxYxTRFclh6Bjus72VXrohYDPc1/no mA0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780580484; x=1781185284; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=maUWokqTyjYG2hZH87ZqeSI6FwjBdDWqODEJObqKpzg=; b=TCxD4dVpmBsEB3jUsQ0Vm7KmgYTDBaJTaynANSzcn9LCdYE/2L5fL3scrVMh7ic+2O OqSCJ7PEBKujkxYKlQg1Ljm2AN7L7mxzp9/ryYLF+LSddUNl8KMaWW3p2h1S8MzASED6 54ASZaJv17StmOZWYgPjTRBBMhHT8jBW3ErtKI110ZW6H6IKYc7v6g201BE3WwPHBNv2 Y8HlIEhg79c3qFK5MiKrvGtjQ3tfDqnVyPF+jFektyCC5/jsVrw1ZhpqKph7HcBqhuzV uEge/zWlLLcAY/lOz8ryhr/Cau8xnWzkREwJQILVLJA1nGd9PecQ00D0tzBNPa930eO5 IHog== X-Forwarded-Encrypted: i=1; AFNElJ9Zy4uOeZaGR/59upgSuXGKRooqGrBeaI2J/n+NR4UXqvd7wYQ3W6ePLTVR2B5EiimlVVJkgJk1x9LEQuM=@vger.kernel.org X-Gm-Message-State: AOJu0YyKoniSJspammI2e9rpk7H3Hdbuh9eLc2+3+uwxHN1HwPib3m/d 5icm07sCr1JtlTJmBY4C7LsknnhXm7BSd7nbZ2pP7n4nDDKOTuE+ieBX1etxdvNs50IBGKmdwxY qMxYRieyeZp+CbeTfrk9cgp8BuGzTmPIVRO2exSKXhFOVKtTGjp5ilGPQYa8au0F61P1GM8SNoA == X-Gm-Gg: Acq92OGAmtd6lQPpzBCheHL87V0ksPSzHTnjy/iGYMwupjwhy6n+oeqeMM3p2CaGNEU Z/2mUIgaDRJ7gIK1QfdgeP/ta1IOvSm5uZwCav/xxgHRjv/pIFX22WvD/GDMdJozo+DpmKPEdeY 23ekt3II4f2phjfAQanc9yFFNt0Nja7+cUBZtpJgOzZszzDyOpatxa/sw7RMUuXWtJ8x1ATv8B/ yYfpUvROxMK08rOtSb1NLoFlWqj1wDYlJqPokspUAqDyELWtOhpgEf/zFbE6wpjZT5phZH2d9aQ ANeSYnkUxWEHxF9ijTr4gbF3hSI1MXWN+M0CVyYtTT1v+syKSnAHcuoAVpenCEt2BAO9/h1I59B UjdW1fIgzkDIM4jnVplsMg1/eL5PpCa1123VMoQwp1KoIvOtSF2ZEMLxWhpew+HQCqeI= X-Received: by 2002:adf:e00a:0:10b0:43f:e272:edff with SMTP id ffacd0b85a97d-4602178ae52mr8881785f8f.4.1780580483754; Thu, 04 Jun 2026 06:41:23 -0700 (PDT) X-Received: by 2002:adf:e00a:0:10b0:43f:e272:edff with SMTP id ffacd0b85a97d-4602178ae52mr8881742f8f.4.1780580483348; Thu, 04 Jun 2026 06:41:23 -0700 (PDT) Received: from [192.168.88.32] ([212.105.155.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46028a6dce6sm8104724f8f.30.2026.06.04.06.41.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 06:41:22 -0700 (PDT) Message-ID: <3564485c-0969-40bf-8f18-c9eb36c4065e@redhat.com> Date: Thu, 4 Jun 2026 15:41:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9] l2tp: fix double dst_release() on sk_dst_cache race To: Mikhail Lobanov , "David S . Miller" Cc: Eric Dumazet , Jakub Kicinski , Simon Horman , David Bauer , James Chapman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org References: <20260601213302.18761-1-m.lobanov@rosa.ru> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260601213302.18761-1-m.lobanov@rosa.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/1/26 11:33 PM, Mikhail Lobanov wrote: > +static int l2tp_xmit_ipv4(struct sock *sk, struct sk_buff *skb, struct flowi *fl) > +{ > + struct inet_sock *inet = inet_sk(sk); > + struct net *net = sock_net(sk); > + struct ip_options_rcu *inet_opt; Since a repost is needed, please additionaly fix the variable declaration order above ... > + struct flowi4 *fl4; > + struct rtable *rt; > + __u8 tos; > + int err; > + > + rcu_read_lock(); > + inet_opt = rcu_dereference(inet->inet_opt); > + fl4 = &fl->u.ip4; > + tos = READ_ONCE(inet->tos); > + > + rt = dst_rtable(sk_dst_check(sk, 0)); > + if (!rt) { > + __be32 daddr = inet->inet_daddr; > + > + if (inet_opt && inet_opt->opt.srr) > + daddr = inet_opt->opt.faddr; > + > + rt = ip_route_output_ports(net, fl4, sk, > + daddr, inet->inet_saddr, > + inet->inet_dport, > + inet->inet_sport, > + sk->sk_protocol, > + tos & INET_DSCP_MASK, > + READ_ONCE(sk->sk_bound_dev_if)); > + if (IS_ERR(rt)) { > + rcu_read_unlock(); > + IP_INC_STATS(net, IPSTATS_MIB_OUTNOROUTES); > + kfree_skb_reason(skb, SKB_DROP_REASON_IP_OUTNOROUTES); > + return -EHOSTUNREACH; > + } > + > + sk_setup_caps(sk, &rt->dst); > + } > + > + skb_dst_set_noref(skb, &rt->dst); > + rcu_read_unlock(); > + > + err = ip_queue_xmit(sk, skb, fl); > + return err; > +} > + > /* Queue the packet to IP for output: tunnel socket lock must be held */ > static int l2tp_xmit_queue(struct l2tp_tunnel *tunnel, struct sk_buff *skb, struct flowi *fl) > { > int err; > + struct sock *sk = tunnel->sock; ... and here, too. Thanks, Paolo