From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293C4E7737D for ; Sat, 30 Sep 2023 17:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234665AbjI3RZb (ORCPT ); Sat, 30 Sep 2023 13:25:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234658AbjI3RZ3 (ORCPT ); Sat, 30 Sep 2023 13:25:29 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B13EE3 for ; Sat, 30 Sep 2023 10:25:27 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50435ad51bbso21440604e87.2 for ; Sat, 30 Sep 2023 10:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696094725; x=1696699525; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K3/pQc7G9YXn5ECWFLpWUyohMguEa9gLmKEtRixcmtc=; b=S77KD6BGqbGLE3Ikhiq0IdVL9tYiYQDuuGg2WY/ikBieqQFlFHNbh9/mtZ1i757krJ 1MEg979yPpUNma09//qR9HqO1lBkO2QD/0fveshtL52nt8ppftZ9iiGiG4nUC5u05i4c wJK55KXnVVPxOIFcQI+4p4KFKYiD6b7a2LsqBM07k92avaepfpx8omnK/h0WTcAxmnOp loCCBzdoccSY4dODBD6nEQ5lng//50DFPuyKCnml3j6e08k69oKhFfvTqM3LaLDC3kco vw777LAlUOQH9V4VvqtEfSJz7F5S8DSc6n+Fyd9HYKBL/XVQQ9lWizeFQ2+TeDRNwgcY Rk3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696094725; x=1696699525; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K3/pQc7G9YXn5ECWFLpWUyohMguEa9gLmKEtRixcmtc=; b=JXOzJlSmPtw3YP8AfIUkfCicUCkLOHlHe4PqMJxD+1/G5iNeSCEguP3Zlqvk0Z026R 2JKskqUF3pv4CKeczk2O4jO+ygFrvGObADhEUC9c+Fm0XJic56R7kCem3g8vIjNNXRy6 XcXTy2iflSd7s6X4YqdKFZdy6TVrq+93DfmLLLwtyOf4gv6FTazDkKBVwMln/sstq52Q GoyJn2+oJ6OU2aI4os4Vb+ZYH3DZq9rGnB4j9xsYMRzfPPG4MtgHoaSNeipAWaHqyiCU 6TiipCEBa7LuTlMiHiL7zPk6AocsoVmMekooj7eStHmCsunZxBtNXsiKp2L43IE0ZgjV HZ/Q== X-Gm-Message-State: AOJu0YzVdzpaKIz5oPJBhIFl6yjklQL+HCMzwCgamyEoQWWIeUELJ/3M WINi/pjquK3K+rRAZcmSzpu7dg== X-Google-Smtp-Source: AGHT+IHk9azgmfZgCNdAFYq2Dl2bXcIZ52kyt8A/dpLS9o+udZJ2qDbPgdpuMwMxbDEVb3AxRgL35Q== X-Received: by 2002:a05:6512:3f7:b0:503:3680:6722 with SMTP id n23-20020a05651203f700b0050336806722mr4914648lfq.46.1696094725336; Sat, 30 Sep 2023 10:25:25 -0700 (PDT) Received: from [192.168.246.189] (85-76-98-178-nat.elisa-mobile.fi. [85.76.98.178]) by smtp.gmail.com with ESMTPSA id z8-20020ac25de8000000b00500ba43a43asm3994414lfq.86.2023.09.30.10.25.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Sep 2023 10:25:24 -0700 (PDT) Message-ID: <356a4f97-a483-4202-a6da-b48351d9b209@linaro.org> Date: Sat, 30 Sep 2023 20:25:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] arm64: dts: qcom: ipq5332: Add clocks for USB Super-Speed Content-Language: en-GB To: Praveenkumar I , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, arnd@arndb.de, neil.armstrong@linaro.org, nfraprado@collabora.com, u-kumar1@ti.com, peng.fan@nxp.com, quic_wcheng@quicinc.com, quic_varada@quicinc.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: quic_kathirav@quicinc.com, quic_nsekar@quicinc.com, quic_srichara@quicinc.com References: <20230929084209.3033093-1-quic_ipkumar@quicinc.com> <20230929084209.3033093-6-quic_ipkumar@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <20230929084209.3033093-6-quic_ipkumar@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2023 11:42, Praveenkumar I wrote: > Add aux and lfps clocks in USB node for Super-Speed support. > > Signed-off-by: Praveenkumar I > --- > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index b08ffd8c094e..1813b9fa4bb5 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -336,11 +336,16 @@ usb: usb@8af8800 { > clocks = <&gcc GCC_USB0_MASTER_CLK>, > <&gcc GCC_SNOC_USB_CLK>, > <&gcc GCC_USB0_SLEEP_CLK>, > - <&gcc GCC_USB0_MOCK_UTMI_CLK>; > + <&gcc GCC_USB0_MOCK_UTMI_CLK>, > + <&gcc GCC_USB0_AUX_CLK>, > + <&gcc GCC_USB0_LFPS_CLK>; This looks like a strange change. Usually the DTB is considered to be the ABI, so older DTBs should continue to work with newer kernels. Is there a reason why the AUX and LFPS clocks were not a part of the original submission? > + > clock-names = "core", > "iface", > "sleep", > - "mock_utmi"; > + "mock_utmi", > + "aux", > + "lfps"; > > resets = <&gcc GCC_USB_BCR>; > -- With best wishes Dmitry