From: Atish Patra <atish.patra@wdc.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"Patrick Stählin" <me@packi.ch>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Jason Cooper" <jason@lakedaemon.net>,
"Alan Kao" <alankao@andestech.com>,
"Dmitriy Cherkasov" <dmitriy@oss-tech.org>,
"Anup Patel" <anup@brainfault.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Michael Clark" <michaeljclark@mac.com>,
"Palmer Dabbelt" <palmer@sifive.com>,
"Andreas Schwab" <schwab@suse.de>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Zong Li" <zongbox@gmail.com>
Subject: Re: [PATCH v2 8/8] RISC-V: Assign hwcap only according to current cpu.
Date: Thu, 17 Jan 2019 18:13:04 -0800 [thread overview]
Message-ID: <356b919c-c025-8993-e5ef-2b010bed0b56@wdc.com> (raw)
In-Reply-To: <20190115135639.GH28946@infradead.org>
On 1/15/19 5:56 AM, Christoph Hellwig wrote:
> On Tue, Jan 08, 2019 at 01:38:38AM -0800, Atish Patra wrote:
>> Currently, we set hwcap based on first valid cpu from
>> DT. This may not be correct always as that CPU might not
>> be current booting cpu.
>>
>> Set hwcap based on the current cpu instead of first
>> valid CPU from DT.
>
> This is generally the right thing to do. But can the kernel even cope
> with different hwcaps per hart?
I don't think so.
I know arm land and I think x86 as well
> don't, so we might want to add a sanity check that they match or reduce
> them to the common subset.
>
I will add a sanity check that they match and throw a warning if they
don't.
Regards,
Atish
prev parent reply other threads:[~2019-01-18 2:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 9:38 [PATCH v2 0/8] Various SMP related fixes Atish Patra
2019-01-08 9:38 ` [PATCH v2 1/8] RISC-V: Do not wait indefinitely in __cpu_up Atish Patra
2019-01-15 13:51 ` Christoph Hellwig
2019-01-18 2:35 ` Atish Patra
2019-01-18 7:20 ` Christoph Hellwig
2019-01-08 9:38 ` [PATCH v2 2/8] RISC-V: Move cpuid to hartid mapping to SMP Atish Patra
2019-01-15 13:52 ` Christoph Hellwig
2019-01-18 2:08 ` Atish Patra
2019-01-08 9:38 ` [PATCH v2 3/8] RISC-V: Remove NR_CPUs check during hartid search from DT Atish Patra
2019-01-08 11:48 ` Anup Patel
2019-01-15 13:52 ` Christoph Hellwig
2019-01-08 9:38 ` [PATCH v2 4/8] RISC-V: Allow hartid-to-cpuid function to fail Atish Patra
2019-01-08 11:49 ` Anup Patel
2019-01-15 13:53 ` Christoph Hellwig
2019-01-08 9:38 ` [PATCH v2 5/8] RISC-V: Compare cpuid with NR_CPUS before mapping Atish Patra
2019-01-08 11:49 ` Anup Patel
2019-01-15 13:53 ` Christoph Hellwig
2019-01-08 9:38 ` [PATCH v2 6/8] RISC-V: Add required checks during clock source init Atish Patra
2019-01-08 11:56 ` Anup Patel
2019-01-18 2:10 ` Atish Patra
2019-01-15 13:54 ` Christoph Hellwig
2019-01-08 9:38 ` [PATCH v2 7/8] RISC-V: Check and continue in case of an invalid cpuid Atish Patra
2019-01-08 11:59 ` Anup Patel
2019-01-18 2:10 ` Atish Patra
2019-01-15 13:55 ` Christoph Hellwig
2019-01-08 9:38 ` [PATCH v2 8/8] RISC-V: Assign hwcap only according to current cpu Atish Patra
2019-01-08 10:33 ` Atish Patra
2019-01-08 12:01 ` Anup Patel
2019-01-15 13:56 ` Christoph Hellwig
2019-01-18 2:13 ` Atish Patra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=356b919c-c025-8993-e5ef-2b010bed0b56@wdc.com \
--to=atish.patra@wdc.com \
--cc=alankao@andestech.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=daniel.lezcano@linaro.org \
--cc=dmitriy@oss-tech.org \
--cc=hch@infradead.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=me@packi.ch \
--cc=michaeljclark@mac.com \
--cc=palmer@sifive.com \
--cc=schwab@suse.de \
--cc=tglx@linutronix.de \
--cc=zongbox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®