From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AB3C1B4156 for ; Thu, 30 Jan 2025 22:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738275188; cv=none; b=WQsdc4FRPvSBjx0YDcgop98xiYkMNgbdbm2Hzs3HRCpW3jleHauV0EkvQXNo/APJc8k7EOuh87GPC8oRoEAWIpTFqClOd6YZdKPn3Us7dwQYAAbaqzlwPvGCKeiRCcXP0T9bCbsLue5IHjNLbitDwfirEUZYU9plFtvuI3yuKYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738275188; c=relaxed/simple; bh=ZV6FlMXD2252vz0OBq25tRE9rjj2v6FTayK5muBz2Nc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=osanaQ3/QG0J/pyDp7xZwv7z0scmnXhe/oYPblkYj8hCZcIT0o2FK2cDY1vjjy5gfToWk+CQyE5rjSdWvlyseO2Vr42e0ZYooSh1KXVu4DHewAIzCHsLUgaWyiN6ZDemhmyVL4QVRfiub9h8pa95g8413sSmAqcEDYlq39BZtqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Wut1mONI; arc=none smtp.client-ip=209.85.161.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Wut1mONI" Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-5fc13355a5bso455190eaf.3 for ; Thu, 30 Jan 2025 14:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738275186; x=1738879986; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=M3RknPmbAgH7Zo71GAVzAj0fabQZcf9EFTBkp1G+LJ0=; b=Wut1mONIFZ/PLmlb6mRYJmTNMTkZV1ui+WXvSJsaHJN5H2QMEUYzPAWuaIZ4O5OYfZ MrDwBb4ZpEIW219rRrujGSQNZUEFj1NJ5fFoMR2JcU76BPKS57hZ/Q+TNnKhR3JZYqen n7XLf3OCUTsnII+FKEE0m/rgsXs+b8a13m0M4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738275186; x=1738879986; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M3RknPmbAgH7Zo71GAVzAj0fabQZcf9EFTBkp1G+LJ0=; b=XMkqWqzNXx46mD+4S18DNaNTGprfQwLG9d9Aztmadp8f2QDk6C+4tCTjKaYzf0yM6j 7SPt4UPJJA7bk0+gnU6ET851unUIvi3ekDcVMzurt8d2xgp/f+9OWZN0F4BWm3c064mo nchgsjRhNtVhuKoX40da4/+u6rk9KtKSjq416Z12bxQEcWV79YxctKo4p+yuTeCEsqD6 hnJNBRy+MJNwm9t4amKqWAip1YkGXq/ETaUNK+mNiFCwlr3bDJ4u9SG5UhLja9xdPhNo nJ4ohM1/07g3Mesf34HmpGPz+graM5X4nVcea3yyy9CobKldRRq9qWWM4KmINJs9Gkx9 lNBg== X-Forwarded-Encrypted: i=1; AJvYcCXweaU0fN+j16JOVd0Vt4Wqwc1pzqWL+OV/Pn2GWiR/fpod4j3YgQPi0dAeq8W3mQqOG9+ZgQhn/CZxfPc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj/vX6cjHB5qgSSDfZccmy3hkLQZUUBmblSweH5FYHiliLofXy Mm6hZbKqaVIHLdyT/m6reu2GvM8jVnCtIplxsyO2rc8IniMjyeDD5hrsILnjOA== X-Gm-Gg: ASbGncvhDQoWwl0v6IBXnVyxXEB7wDek4YrAGwS8n/Wxwzj5+r41EAtlZTtoDZRLtRf bAJStV+yypr9tUutBEW7puELIPsHT9uzoWps75mFF2ZjGcGjI/iS+xs9hTnmX0uZ2NLyKEch8E2 yxV2gQZSceAZhVUiYFDq25dmPSo+6Yt5wJo2gQyCwczf157vZi2dOwqxMNm3lWBkbGXhlulA0Ed NiQmeRoBHsGitq+AN2S1Aichblkk2qxxmX8pNSlHUbCAxlpFXOlWOI00nnTk2cFCx7mCY2p76nO yhJ1WSw5MvW0EfftYHSfVdtxfP6UCNzSSdTfqHLszC2xIFbMO7OjoxI= X-Google-Smtp-Source: AGHT+IGEOfUHHL4aDQshI1kV0F2HcWh2MzgUSVtxSrQ5ZrGN+EAiOGyR9TNTrD4etw5eNv69qLkhog== X-Received: by 2002:a4a:e90a:0:b0:5fa:840b:19aa with SMTP id 006d021491bc7-5fc0031b4a8mr6402835eaf.4.1738275186130; Thu, 30 Jan 2025 14:13:06 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cb804sm528520a34.15.2025.01.30.14.13.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 14:13:04 -0800 (PST) Message-ID: <356d5a78-85ee-45ef-90a4-b88dc1a3448c@broadcom.com> Date: Thu, 30 Jan 2025 14:13:02 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] gpio: bcm-kona: Make sure GPIO bits are unlocked when requesting IRQ To: Artur Weber , Ray Jui , Broadcom internal kernel review list , Linus Walleij , Bartosz Golaszewski , Scott Branden , Markus Mayer , Tim Kryger , Matt Porter , Markus Mayer , Christian Daudt Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20250130-kona-gpio-fixes-v1-0-dd61e0c0a9e7@gmail.com> <20250130-kona-gpio-fixes-v1-2-dd61e0c0a9e7@gmail.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20250130-kona-gpio-fixes-v1-2-dd61e0c0a9e7@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/30/25 09:10, Artur Weber wrote: > The settings for all GPIOs are locked by default in bcm_kona_gpio_reset. > The settings for a GPIO are unlocked when requesting it as a GPIO, but > not when requesting it as an interrupt, causing the IRQ settings to not > get applied. > > Fix this by making sure to unlock the right bits when an IRQ is requested. > To avoid a situation where an IRQ being released causes a lock despite > the same GPIO being used by a GPIO request or vice versa, add an unlock > counter and only lock if it reaches 0. > > Fixes: 757651e3d60e ("gpio: bcm281xx: Add GPIO driver") > Signed-off-by: Artur Weber Reviewed-by: Florian Fainelli -- Florian