From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC5BF4C040A for ; Thu, 2 Jul 2026 09:58:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782986313; cv=none; b=EWUZO4pVct62IO5OZP4/R0gOh2OKV1OBuBvirfrtq3taUSvnqt+h5Ib1piCln/CrDrWUxSHIS916/odwM0kjhmouEYka38mVnluJMv4vNTJBgFhXMxqQ8vZssQ2rPUoidHATP6SZeZJ4D7pl9iJv9x/aMsSmC9bo9WTg5ZLuqWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782986313; c=relaxed/simple; bh=0z0VmTlpDffbSTeTh7CAA+SlXObRzIn6jI1fTJvKuhc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NSUJ1kncIDHV4Ewfl7qe8JDMtmRcNywN/6tHo4wNCA5cGWiJTtnrg/brcHRbhXVqd1Jd+2DcDgZy7tYY8nSNdfYgC4CCmvAjlrRhmpPem/pbwkmO7t9BS0SkiF5v/xdr89BoEpjgJubw8AFGkmgc32e8yKVwEZqf9ba44bxD4hA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ItdqmxN4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N5sq4kxC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ItdqmxN4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N5sq4kxC" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6629nXCC4139672 for ; Thu, 2 Jul 2026 09:58:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3n/tqMXFg8NhtwicFe5DWNVRWaMKnyeWYxknUpUMFLA=; b=ItdqmxN4LfRI3RcM A87rK3gWhIZ4uxSvqDs/YmC2xneQvwotlg0vRUOKHaMitWD9ux2CSDDpjoml/96Z IFG4ZO+IWv/U6ENt+13CghZg5M/gOT+UDoFnjYwhjzoH7n4DsN68oof98mZoLEys WwrNI1vB+BMEWWWpcTPHusOmLxIKERAO60n1lk8DzZXGeQOoomKTZ/+uQAIfLx6G PbHciOIlr9HXzR8Karj2JgATHa3Ym5ZLPA977VLrLXoj7N6eD//jZguM7sas8e2U a962VvOnHTFh1HQBuqmTW+7pOwLwxZOXBfttJRHyJ2NX2HrtUp7ibi9oSgTQI2JU Tek/7w== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f5npr8193-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 09:58:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c267931ebso6501521cf.2 for ; Thu, 02 Jul 2026 02:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782986310; x=1783591110; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3n/tqMXFg8NhtwicFe5DWNVRWaMKnyeWYxknUpUMFLA=; b=N5sq4kxCmhNfEmSmYqwnoCZElb9J73jOLyezj4Sh9TtPaPEU9WEvlbFwQuUSfHiYHw noyCwBedPRUm3LOp4IZT0NAFVvjszZ9VNZ0Ww1qGE2r+2wWF1Sv0Y9BEOrPpFiL2R1dC VnVgl9w0VAyXD/SnO2ddROpO/3Y54rI2y6OOSH0JnBBXjleMjsAE5FPykd5+Xr4dmmyw F1YwYsd1KEnu28/zrK6+Gcy5dEksNJcJqmfksNK9rfX9xZLBhYQSwSjSNreuR5e2l0oj xbQueYNWxRaC/8KdmqIMo7G9y4F6/kzRmULWNinrIaauwW0bHixGnfkM6o3SR0xSz7fe /3kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782986310; x=1783591110; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3n/tqMXFg8NhtwicFe5DWNVRWaMKnyeWYxknUpUMFLA=; b=LWiDLgj1UizsyZV3oCL0hk0feXAZK5+upjL7ImFXaixOmpzuQoV1zeqFczLA32tBNX yHXUpWGYBQ5u2TTedSIFnwk7CvW0MfutPKTkv+OYFYX/PrYhceyaLOn0sii5muRGvmJc nfvBN1kG6ik0Ie34HH4yEfeUNUESzj1AzhiO7jSz12lpjhb/rEI+mheeqfjTuVQqOcqr 4DvnyayWtdrLvwaUBnDLJGZMHh/UDVIc9PlbsZ1F7x6YsvLsuHr86imeTJZIGKkUbDTa Jz2UGHy34L+NDhi107j76+5vqqiuZ/0tiSqTNLLjUpIurWUZYrIEMa26TZP7FSBpmXcQ ixEw== X-Forwarded-Encrypted: i=1; AFNElJ+AJduoJUDawDogZxaHqbkvt/xQzyHZTDXI20i5cA4EPA1Vo7H210ASvNVr4nBcKDZkdB3iFfYznGFR5cw=@vger.kernel.org X-Gm-Message-State: AOJu0YziEsmIXEBVvwPxVGQfahSs+GfzNFvAtCnLCLp/ljq52VEP6vN4 o5I+yy+0LAnFHIIcQRUrTfrSbDaN6duAnOMMe02lQL6ibdZBwthy0cpFHlvg4qA8hMc9achIfAL TbFbN56kMErKQklpzbO/nthJUKOrsFF0f9AR73AlhnwHtuoXl/nuswL4o7NDl/jDIce/XqudSYf c= X-Gm-Gg: AfdE7cmZuJj6EMWARBu0yZrv2zQjcMH+Py69qlmkWtmf8RUXbYe26PTJZMZLcRD9ssF UeekMdzEK3C8zxisPT9xPXBS8qkFMj1aJdv4s/P1yrC/hlEWnbP2rdkVXDi1u9dBhn2ALmPXxEh H4c0QCubrU83jwE7FXf4GLKSvDUa6QVSCUe/fnOaDqChhROv/XktIUo5mxCFiD3lFQQcVqXoOFw daBvdZVbpiNyZw+MQoHVVhxAwCMcaJ2Tt7OMv6mk0OEgnGg455qeVAdD+fQJ82YX+ywypqf8u09 butZHx1qzlmbZL/j2foVZwKGQ4K16T4Iyh7qcU0IET+JGIgJ763+PqrLiE7Q7/zluVuBGAYBZH6 5SR2A30mqg3WK0s5kXIf8LidW7epJ85iKJjs= X-Received: by 2002:ac8:7d83:0:b0:50b:2875:5782 with SMTP id d75a77b69052e-51c26b03d36mr50584211cf.6.1782986310080; Thu, 02 Jul 2026 02:58:30 -0700 (PDT) X-Received: by 2002:ac8:7d83:0:b0:50b:2875:5782 with SMTP id d75a77b69052e-51c26b03d36mr50584041cf.6.1782986309610; Thu, 02 Jul 2026 02:58:29 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b628efefsm103164566b.32.2026.07.02.02.58.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 02:58:28 -0700 (PDT) Message-ID: <356df014-62ae-42b1-9745-673db02abcc9@oss.qualcomm.com> Date: Thu, 2 Jul 2026 11:58:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] firmware: qcom: scm: introduce qcom_scm_clk class for clock management To: Bartosz Golaszewski , Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260701-qcom-scm-code-shrink-v1-0-02f5ce02c95a@oss.qualcomm.com> <20260701-qcom-scm-code-shrink-v1-3-02f5ce02c95a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260701-qcom-scm-code-shrink-v1-3-02f5ce02c95a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: cokupnrFmZF6JnBb8_NMDLCUxpVKfLYS X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDEwMyBTYWx0ZWRfX5pKSJaZ45NaE EzqAn3WzrMoIzGjjXzZCR6O3vESQuMtRoqibAMdbNPjtpA6ryoY1lf9q2e5i21xbeiMHZyAboTD l3ybHqLe7T0JaJH4GPNsH74koi5i02s= X-Authority-Analysis: v=2.4 cv=NsvhtcdJ c=1 sm=1 tr=0 ts=6a463648 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=UWT-nxUxJpYvPzTNZu4A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: cokupnrFmZF6JnBb8_NMDLCUxpVKfLYS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDEwMyBTYWx0ZWRfX5SB5LdWzgLD0 kcFXAzuOR07xbV9/CLTPZMWkAEO0NBF4ClxweIGhIgwHtTBactGSeqeWPCAeawNkoircBS2aWto kgcQy1aKrlRuoTESdogE8saymVQCXMv0L58GQ3PYh/VNiKx1+XKP1PJ5xFxzCfLHkIB/eBsopaX fdWy36r0qFN79qhVwUbZagOMr4RVjr7oowcsvviw0Dw5Uxfa8kzq+HuRjCXjsKjSQ8gvlu8/ial TBuWPm6pinK8yx7HEa2mg83/HNCPEIxlXS6AGOoZ+HEYV0RSHQTAUm4QHeezBvEc1H7OS7+1S4p 2XaPp3fIsTI/y6MAOhAMj59RIxNUdjO+dP6MJIJWjbHHkdjLwZgu+e+K3uKXGMTGnTDcxNOuZQ+ CaQrcYNZZJfnHUlIyHXGmDIxHfL2nHjHSik+vjsQcMUkWqn+HA7FK9aTFT50hqo19zIat8qCk3O Fd+Q87IW8GWHFAMNGEQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020103 On 7/1/26 3:38 PM, Bartosz Golaszewski wrote: > Define DEFINE_CLASS(qcom_scm_clk) that calls qcom_scm_clk_enable() on > construction and automatically calls qcom_scm_clk_disable() at scope exit > *if* the enable succeeded. > > This allows us to convert all call sites to using > CLASS(qcom_scm_clk, clk)() instead of the manual enable/check/disable > pattern and to remove the associated goto labels. > > Signed-off-by: Bartosz Golaszewski > --- Reviewed-by: Konrad Dybcio Konrad