Re: [PATCH -next] ASoC: sti: fix missing clk_disable_unprepare() on error in uni_player_start()

[Arnaud Pouliquen <arnaud.pouliquen@st.com>]

Hello Wei,

Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>

Thanks!

On 09/17/2016 03:34 AM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix the missing clk_disable_unprepare() before return
> from uni_player_start() in the error handling case.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  sound/soc/sti/uniperif_player.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sti/uniperif_player.c b/sound/soc/sti/uniperif_player.c
> index 645e415..1bc8ebc 100644
> --- a/sound/soc/sti/uniperif_player.c
> +++ b/sound/soc/sti/uniperif_player.c
> @@ -893,8 +893,10 @@ static int uni_player_start(struct uniperif *player)
>  	SET_UNIPERIF_SOFT_RST_SOFT_RST(player);
>  
>  	ret = reset_player(player);
> -	if (ret < 0)
> +	if (ret < 0) {
> +		clk_disable_unprepare(player->clk);
>  		return ret;
> +	}
>  
>  	/*
>  	 * Does not use IEC61937 features of the uniperipheral hardware.
>