From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752356AbdJEVyv (ORCPT ); Thu, 5 Oct 2017 17:54:51 -0400 Received: from mail-co1nam03on0072.outbound.protection.outlook.com ([104.47.40.72]:18160 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751932AbdJEVys (ORCPT ); Thu, 5 Oct 2017 17:54:48 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=igor.mitsyanko.os@quantenna.com; Subject: Re: [PATCH] mwifiex: Use put_unaligned_le32 To: Himanshu Jha , Brian Norris Cc: Kalle Valo , amitkarwar@gmail.com, nishants@marvell.com, gbhat@marvell.com, huxm@marvell.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1507141686-5178-1-git-send-email-himanshujha199640@gmail.com> <874lre5a86.fsf@codeaurora.org> <20171005083433.GA11485@himanshu-Vostro-3559> <87zi963s1p.fsf@codeaurora.org> <20171005152233.GA6250@himanshu-Vostro-3559> <20171005180248.GA94139@google.com> <20171005190730.GA8043@himanshu-Vostro-3559> From: Igor Mitsyanko Message-ID: <357bb728-f324-5c9f-c92c-08c57f22ce75@quantenna.com> Date: Thu, 5 Oct 2017 14:54:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171005190730.GA8043@himanshu-Vostro-3559> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [12.131.200.68] X-ClientProxiedBy: BN6PR1301CA0006.namprd13.prod.outlook.com (10.174.84.147) To CY1PR0501MB2042.namprd05.prod.outlook.com (10.164.3.16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 408e68c9-d360-451e-7e29-08d50c3bb14e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0501MB2042; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0501MB2042;3:Mo3S7CBrISc6QyFPrP/2XlpjGxzb/mqEJQD9NJWTNy/ySZwzeeOtf7+SqN/3undKKg3r/V3UmN3gCsFgQS64ErWNhwcq/V9uDSgh8/mwDJ8C9C8N9WHVxfCRFE0ccBLgN3hmqlqUDAeeHmpKoLRZyp0MPMIG6unyCWkX+VZmgUPslUb5BQhxilFgtudjpDxf6VmUjpqj6F278PzJNpxrIUZZabwJJt3QBQwjB9QQZOcl/anB5K12pjZ04/RdZx2a;25:nhtf4z5HzmUSO0rKSfc/zwIwyQpRdLMeEWyALsOzXS+oFFMLnHWkOc3DqVA2+CqpmCKw7YkGuq2P5kqvwG4WS9rCnoIKC1G2NMSYjq5eidVSRSTvl1PAa3nczRFLW2YcUBLr4r2W40DgBB1iNDZEvwbvUTpVIblAWdmdWS63gI0m+BQ4kFMM5mL/nFLPPFX3w0TzyMw9eJPHhl4fV/ysy7Bl2NJJKf5LEby3R+7eoS5Db+8t6ipHmzJsq+61iBgKwb7GPkA0lnX3ltcmDv2GtNhYfcikIDmDKb061PPeUTynLrCv1Wo/o6tKhb4Lm7uUikm947Do0tVtyDP/65jdDg==;31:Yf7coxGxBUYve3YGaDzVep9lSdjxWqYHBKXlbkfDpt/9NhSfboFv8xW1dPbUmh5M3aBwwYTJUWiqRz2eZSpe7wY+2IHHLm2JGE7uVG1NLCY98vYEwvLIg33YduTYoEyRmA9AAGerJa8DjjoO5AbvdzQmXoQqYguXQ+NldvPfbOAQap+Q9VxE+60q2NlLN6hoyoz0xWfvNeGpl4p1CX1TLiJWRaZ/3uBzrQgS7eDcfto= X-MS-TrafficTypeDiagnostic: CY1PR0501MB2042: X-Microsoft-Exchange-Diagnostics: 1;CY1PR0501MB2042;20:ADGyo8WnPk6Nuf9DoVIoQQ5RyvOgh7OI6InxUcPKqnzzJ4cTtxPGaYwSO7XjA0Ev0CsMlsiMQuwzFSlTt0yNN9T/hjCefbE+lgufDxRYJd70CfgZP2WDtfv68WqS4N42L33CzsCPxfcdgrEDEox8NmpSgdxA2nBGtVpESqdb9/4De57Fr5LR0yXGJnxTdj+DKayaum5dKJw8hgS9WOsuPs2pFVLrh2mtfgaXqkCBjOyGDvAEtr2reIJQwvhS7rIyeUiKqu8wRrZ4A8Ck/m3evK0f93vAvCF1vSYz1mm+wTioOkQXoZSI+uxmRwP5Gxdrx160EP3FocTSb5dnd+09uu0j1eVinXAW11OcS0UoSLr7H8etBjl5M96tqChkSz5kN9em+thnLAbGL2bTkavfmZXMkPdjd+Zvv3x/RUDVjdKcSL1pGPkSRR9gKRQqp4M6Efgr8tNWax1fr9gpiCuBlSL1/510nl542ha+FlOvrSMFU7KLKvpnHD4elOmwbHI3mSBxhtyR+sGieEHRzTNGlMK/VaSEHPlBrg2WKXhb99mZwDJnkabRnRmF6rwBYlaCyHiKahIxzedcM5CGTr9YU+UILisYpMJYKiQkJsdILsI=;4:G3rjnhRd8clJ8BGdzA2Y3dN4cRGVDrIkj1s1GNTJ9QwyW74yfnH+L1kNICnx7kNdaRKbjA5FFLQAQZDmjO2Q0zj3N1CMonT4inn51wyLpfdPDmEp5AR0SwfAv3epj6w2qqCDeejBBveION53iUQDXeD+4J2pVGniaQPUkuT8ASm1hsKO9EAAJkApbDJjDg/OloUpM4Ch4LO1Z79dSr8dRCP+nYrhJ2T0RKv9YO3mEhZ6OGVQrOhvXae/yo0qwyfP X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6041248)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0501MB2042;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0501MB2042; X-Forefront-PRVS: 04519BA941 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(346002)(39830400002)(376002)(189002)(199003)(377454003)(24454002)(2906002)(478600001)(6486002)(6116002)(53546010)(65826007)(81166006)(65956001)(66066001)(65806001)(6666003)(68736007)(77096006)(2950100002)(7736002)(81156014)(305945005)(8676002)(31686004)(6246003)(106356001)(90366009)(7416002)(25786009)(4326008)(16526018)(83506001)(47776003)(229853002)(8936002)(105586002)(5660300001)(33646002)(23676002)(64126003)(230700001)(110136005)(93886005)(39060400002)(316002)(16576012)(31696002)(101416001)(36756003)(50466002)(58126008)(53936002)(76176999)(97736004)(189998001)(54356999)(3846002)(50986999)(86362001)(15760500002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0501MB2042;H:[10.10.121.34];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjA1MDFNQjIwNDI7MjM6SkRFa3J3dlMyS1ZyVXJPM3dSb09EWVVG?= =?utf-8?B?ZXpXT3VMdFRLeXhDR0lGcGFpcUVSM3FuNVZYdDlkeTFRYUlWTUpQdWlwVE8v?= =?utf-8?B?TDlpSnlDUk9SZHlKcFVkMlB4L3ZrSzFOcHdzcDVMVDZWYytja3lQYlZPSmYw?= =?utf-8?B?S0x2aTd4azdiZXZpVVhPSTFZNm1kYXJxTU4vTC9RanU2V1BtOHlEbTBvaGxU?= =?utf-8?B?eEh5cC80NkRJNVR3RjlqaTBEaXRMb2UwbUJBL3JzbzJKekFJOFNtWUx0ejNi?= =?utf-8?B?S1MraVY3Qjh2ODk4R2RyUEx4M21Vemd6Tlc5RW5qSmtPM04zS2JGOXNTSmpn?= =?utf-8?B?c0c4Z1FKNDY0RisxOTBFbWhFNnZVS3B4VndLN1YxWTJjSVNadGs3SFhHV3d3?= =?utf-8?B?bFE5NlRsWG8vWXk3aGhxMis1YWliRWxQY3QyMGYxdXcvNnVSYVpuMlVXd2ZO?= =?utf-8?B?V3ZCZTlzVDNtTGhHT3JUejh2N1QzbThRVlNETldiYzZxVVoyN2dELytqVUpp?= =?utf-8?B?Y1N5WUwvRDU0UThDZEE2VW81R0JaVjJSU3VYOXhkRjdQTjVHR3BhRCtNSk0x?= =?utf-8?B?WEc2RUpPRnZVdzlHcnMvNlNTL0xGM0VjSTJMOCsrc01RYWN2RjRJSEFRNDhU?= =?utf-8?B?dXIzSXZqdnJNTHB3MHVVTExCUXRvZG5tQkViS0ZocG5JeVoyZmhKeTlhNWNF?= =?utf-8?B?QnlvU3c2aTNIc0d1REc0ZlNMT29ybEFhTTI3NmFQUmhMVVN6eElkQSs4YUNW?= =?utf-8?B?dWd6dE91clJKQzBrYjcvSnYzdGVqZmFWbEpmOVBYNkNOQTkyZW5FQW5hd2hn?= =?utf-8?B?R2RsT3laV1NpOWRUUC9Bd1U4SnVPVHJRSXkwKy9lemZvUjBWOXo0WDR0Mkcr?= =?utf-8?B?TXhtcDBxVXNoWjREYk1uTTU3MTJtS0V1UncwVVB2cTROTC91MmNvUU1KdTgz?= =?utf-8?B?MjI4aVBiKzBLSTNLM1plTWFTWXRSd1ZuTU83VXZOMU83ZmY2VEtadHFuOTFI?= =?utf-8?B?UlZScnNYOEx3dEF6T0lzdWxIeUhrSmpDOThQL2kvUCs5RHo5Mkx6Q00vRFJX?= =?utf-8?B?VWtyQ2YzWU5pZGtRQWtKMVpWQmJKcHE1Zkx5T1A1WkFUa1lZRktkTTVTQktl?= =?utf-8?B?aEw5bFozdUp2czRhbzBGWTlOUEVpTndEY1gwb0toSmtCeHBOTjNRdjZ2VHFm?= =?utf-8?B?b3NEbGd3K1BNSEdQQ0luWjd2c3NoMUE5dzhrMERuL2lUVkUvRFl4S3k2dWJn?= =?utf-8?B?ZzZUeFBKaklyWlkyNEVSbHhmZW1vZGlldDcxWnBlQmxxc3YvdWpHamhVdkNU?= =?utf-8?B?OUpjQ3oyT3ZYUzFNamwvNHZtWWxEZmIwMlE3azdmVDdQbUwzMC9YSjFTa3Np?= =?utf-8?B?UHRxS3pnL1hPbjNLanJGakZTUlJSL0ovZ0xNbnE1UVgxSko1bDh3akxFVGVE?= =?utf-8?B?SDJIMG5VWThuaVNsWjFJdXhiaHQ4dmE5NzcxbFJBS0VxM3EzYVVrSVBIR0hC?= =?utf-8?B?ODk5VVNLejRxaExVajJkMUhhTERMalRQV2VlSWVieGpRejlJQmQzcTBpcnFI?= =?utf-8?B?bnpRelhWR0lrcjJFY2oveElhaW0zNGRsK2trT1JoWi9MOThjTzRvakxZa2Q5?= =?utf-8?B?a3d2L001SmZpaGs1cXJiZFFlRG1ObWo0bk9kUkpDd3BwaDRIOXNwMWdTUkI5?= =?utf-8?B?bXNuMFRSQUNvWFphdGhXYmZzaWFXUlNvVkNSUVlZVGNYQzRQUlBQQUwrUTdP?= =?utf-8?B?M29KbURsNFJUbEdUSHJ5Z1ltTnN3RjF2UDJ6RHU0Q01OTHFwMmc1d2FSMXFj?= =?utf-8?B?b3dPWDMzcEZNdlhFemp4Yis1NHdSOURjNG9EMkFCRUVmNnppREJQUWx0RjVK?= =?utf-8?B?dDBWN0I5ZEVMbXpHdGVTb0FiV2NITlNESUVSRWV2WTBYbVBocFZLeHU0MjVI?= =?utf-8?B?WmdMcllJS3JWR2ZGL3lXUXo0T3JMU1BvME41ZldiMCtINzhXMjNndjE5OXl1?= =?utf-8?B?Y3JNT0FPMFd3R0xVS2x6MVFrRncyZWczV0sxVHJnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0501MB2042;6:A2n4yjl4ZyLTqYXrBKdx6YaSEplD43FECds70+6gl8KplkjVwBpcqSG36tzSAsNspch4ZfF6czC3GRzU5yHtXUmPaQA2yjvGOcmI2aCOwJyMUGqLHN4Qil5ibXg7Hj2ojhcXe85WEJ4K44GCEZ6LFQUK0dcW6L185w7016egEPxyRC04rl6hNxxJYoxQvV5mxzBhOzVMaqDRtjOHatJRFgt2eojExFplGtR6gc3MMmscUeVFy5HaRL2/24Ic/HmIXTuFWXgl4VzqL3wG1QWJmK+6SWUrPqe8nTgd9a0E7x+Q8x1xCWMz4Ckehjm/UcDDUeIPdKnJbYLlIQOz3rvyvg==;5:goQdC0O6a6MRiCKUDy1f2NUJX9CqmNsF3AvQ4uHp342q0MFRnubr8ljo7YvAGjB6tNGD+l8tinidH/jn5arkuIoipY1e4SKHUgLVZolmgbxFRJOSUeJDJdoX0MkidyCwGIpc4a+eVktmrKFEFiViSQ==;24:dMJm7XgUXYHgTUvkQE7i7Hc77TwpBP1EpVCwZSrp1t6Gd1+FYEcooRYYusQlWsO0ArS0DmFGarX+O30yP1dfw2zKzTQzPaQ0TO9RNF+wptU=;7:9FO9Zfu+lHFgge/CoNVr8nHwTelmejAJiEAMR9kOpo732zqAUAKRdG0eRPjYMJzpT3LROqAF1l+NBep5ZYcx/rasBpUV6GcdfM7YRYGShycjgnkcMYaN9mdz16kVSSnVEFEZENEeu25ZyAXJdCgx8CqdsxFsRII+3KB62j6pUlwtibERyhZrrbndGp3EJjSlzRthea8rxi3hp1Ji4XGj4RL3JQq5jTyVYaqi/+jwhwI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2017 21:54:43.5419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a355dbce-62b4-4789-9446-c1d5582180ff X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0501MB2042 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2017 12:07 PM, Himanshu Jha wrote: >> >> In this case, the key is CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. It >> seems that asm-generic/unaligned.h is set up to include different >> headers, based on the expected architecture behavior. >> > Yes, asm-generic/unaligned.h looks more appopriate and is most generic > implementation of unaligned accesses and arc specific. > Probably the idea is that each ARCH knows exactly what is the best way to do unaligned access, so common code (like drivers) should include ARCH-specific asm/unaligned.h only. It will then decide how to do that and will include asm-generic/unaligned.h itself, if required.