mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: David Virag <virag.david003@gmail.com>
Cc: Lee Jones <lee@kernel.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: sec: Remove PMICs without compatibles
Date: Thu, 2 Feb 2023 12:24:55 +0100	[thread overview]
Message-ID: <35911bc7-6973-d4b0-18d4-22e93962f3c5@linaro.org> (raw)
In-Reply-To: <20230131183008.4451-2-virag.david003@gmail.com>

On 31/01/2023 19:30, David Virag wrote:
> The S5M8751 and S5M8763 PMIC chips have no corresponding compatible
> values, so since board file support was removed for this driver, there
> is no way to specify these PMICs as present in boards anymore.
> Remove leftovers of these chips since it's dead code.
> 
> Signed-off-by: David Virag <virag.david003@gmail.com>
> ---

Thank you for your patch. There is something to discuss/improve.

>  int sec_irq_init(struct sec_pmic_dev *sec_pmic)
>  {
>  	int ret = 0;
> @@ -448,9 +362,6 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic)
>  	}
>  
>  	switch (type) {
> -	case S5M8763X:
> -		sec_irq_chip = &s5m8763_irq_chip;
> -		break;
>  	case S5M8767X:
>  		sec_irq_chip = &s5m8767_irq_chip;
>  		break;
> diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/core.h
> index f92fe090473d..07aae649a86f 100644
> --- a/include/linux/mfd/samsung/core.h
> +++ b/include/linux/mfd/samsung/core.h
> @@ -36,7 +36,6 @@
>  struct gpio_desc;
>  
>  enum sec_device_type {
> -	S5M8751X,
>  	S5M8763X,

Drop also S5M8763X

>  	S5M8767X,
>  	S2MPA01,
> diff --git a/include/linux/mfd/samsung/s5m8763.h b/include/linux/mfd/samsung/s5m8763.h
> deleted file mode 100644


Best regards,
Krzysztof


  reply	other threads:[~2023-02-02 11:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 18:30 [PATCH 0/2] Remove SEC S5M MFDs with no compatibles David Virag
2023-01-31 18:30 ` [PATCH 1/2] mfd: sec: Remove PMICs without compatibles David Virag
2023-02-02 11:24   ` Krzysztof Kozlowski [this message]
2023-02-02 12:11     ` David Virag
2023-02-02 11:28   ` Krzysztof Kozlowski
2023-03-16 15:11   ` Lee Jones
2023-01-31 18:30 ` [PATCH 2/2] rtc: s5m: Drop S5M8763 support David Virag
2023-02-02 11:28   ` Krzysztof Kozlowski
2023-02-23 14:15   ` Lee Jones
2023-02-23 14:18     ` Lee Jones
2023-02-23 15:03       ` Alexandre Belloni
2023-02-23 15:11         ` David Virag
2023-02-23 15:22           ` Krzysztof Kozlowski
2023-03-06 20:58   ` Alexandre Belloni
2023-03-16 15:12   ` Lee Jones
2023-03-16 15:13 ` [PATCH 0/2] Remove SEC S5M MFDs with no compatibles Lee Jones
2023-03-17  8:06 ` Immutable branch between MFD and RTC due for the v6.4 merge window Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35911bc7-6973-d4b0-18d4-22e93962f3c5@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=virag.david003@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®