From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013016.outbound.protection.outlook.com [40.93.196.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA1352F3C27 for ; Fri, 5 Dec 2025 19:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.16 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764963343; cv=fail; b=KbAtN+v/vVzQJJDh8dND2YTBveYJ5JRUfDjSeRGozNz1qjxq2Qw0yTHYZkhfDgh40wSK2s7v/6QGHuzlytEb/Mkt6fEKkdDfNxSndUrxy8a6mtELGfAfW9Q619Z2O1Qnoq463k96eKyYOETHWSngbbo6wfFLp4biObqSAFlc/2k= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764963343; c=relaxed/simple; bh=h+I+EFfdhlBh8GjZkLpBSE+YBLCnkvpXTjY3xw2YtMQ=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=gQqt6i/0L++Ah+bGHpxiRAZEKJzRJPaPgX6Cyq3FE2g+xHGwMs0cepMP/A+2FIKA/GnJUdBI8Tt+lnbMlMsGQGRHAUQDODVfKTmtLE89sBIfkQWpH6+i04/u+PeWO5/gGE0QYTvkrzU6GKs2FzS0d/CKVkbUHAcVfh6dTyy2s0Y= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=w65akFWE; arc=fail smtp.client-ip=40.93.196.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="w65akFWE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pTVmeUHDw1vNj3fj7PBmHg+cmhpn0zWRot42puUw+9UXp+zOb9SysH7Cg5JFi11pgFYPwe8c+f5aY2lDpSJ3jpAa4ZU/m+4tDeIyan4icF0YVuMM0viT6yZqZ0ELc/o4u/zvvs1doesKyMnIhWviUogcMT/F25kBvY+q6kZgRRWR7M0TkKGGhpkAipZpZehLjjbcdw8O0jf7bvhyAvdg3LnqDsPiCEDIqgyULFFkmRMWuXMfMfXNFisnlNSb0lH14hbiAlE53EdNlxXIl1XL0f6EdpZQR4GZrPk2r+JVmRPqhpxs6JtkXl4wFms2y1FuHFwYQSFQsDxpryb+Zm850A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BwlJdb/gTS7TJt/47+Vm9fsFyzxplO1BGjj347AxJzs=; b=JS8aFMeBaPI7LqkywaxJ7gfctcVkP5xdkKkwcvpyQxDB6vXosM+e6f2W7RB2BFNTBWVaJqZqt+aOXIWnCEX6k0LaNNz0F4OU4P4yWhVjAvnplvL1REP4Ofzu5C53WVVipvdewwA7K+Y4E4IIDEiDfebg3YVr8Pf6QLe0XWLpFeYoiCFmzwgTPsSUmHTCa90rXEs8PUqok+FUeyb4AAhLwhWUhfEmQ7NjX9IJKEh9WZ28mHMWv6AGcu2FPFGp/6qsO3yyndXLgOBD3adyGQ9SIQZTadQlxkefMoVTNWEryhyYmsytWrctHs1PHInhPZykw2LlHFloMK0H97SS3xGgug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BwlJdb/gTS7TJt/47+Vm9fsFyzxplO1BGjj347AxJzs=; b=w65akFWE68YFJLcGE/0h/ygDn0IESJP9OmEqc5IPSdZ0xqSZL/tWVilJg6st9DcYv2GmdMZF8JgIKovZia5gS9c9SToRripiaSw5cmh7YIpR0Ag1jwGHp9Cd7fJMWYWcTIJqh+Yjq/bSjgYl7Za0+RCci3P5XvvQt3nyPjtOClw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from IA0PPF9A76BB3A6.namprd12.prod.outlook.com (2603:10b6:20f:fc04::bdc) by PH0PR12MB999090.namprd12.prod.outlook.com (2603:10b6:510:38c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.9; Fri, 5 Dec 2025 19:35:39 +0000 Received: from IA0PPF9A76BB3A6.namprd12.prod.outlook.com ([fe80::8d61:56ca:a8ea:b2eb]) by IA0PPF9A76BB3A6.namprd12.prod.outlook.com ([fe80::8d61:56ca:a8ea:b2eb%8]) with mapi id 15.20.9388.011; Fri, 5 Dec 2025 19:35:39 +0000 Message-ID: <35929970-84d0-430b-8952-377dae6edd9b@amd.com> Date: Fri, 5 Dec 2025 13:35:37 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] fs/resctrl: Add helpers to check io_alloc support and enabled state To: Aaron Tomlin , tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Cc: sean@ashe.io, linux-kernel@vger.kernel.org References: <20251126171653.1004321-1-atomlin@atomlin.com> <20251126171653.1004321-2-atomlin@atomlin.com> Content-Language: en-US From: "Moger, Babu" In-Reply-To: <20251126171653.1004321-2-atomlin@atomlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA1P222CA0167.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c3::15) To IA0PPF9A76BB3A6.namprd12.prod.outlook.com (2603:10b6:20f:fc04::bdc) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PPF9A76BB3A6:EE_|PH0PR12MB999090:EE_ X-MS-Office365-Filtering-Correlation-Id: d2dcda72-27da-4039-ffb0-08de34357865 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|921020|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YnBYdjJOb0FrdEwxOXJLcE0wSnNqVTQ4bnZlamhxODI0OUV1MFVPQmczbWtV?= =?utf-8?B?MmQ1RnhoSVFiQmdiK0ZzeEtzL3VDSitoZEtVQ1ZicUErTzVKd000SVA0WWo3?= =?utf-8?B?L3ljU1Z4Vlg3SHhVMVRXZTBkeGtiTnZncGxSc09KUCtaT3VOaVBFaUV6QlZJ?= =?utf-8?B?M0pJc1lrajNWNUdiMjdNeUJvR2lrdDN6T09ON010V0N1M3hiNXhCRjhwK0p5?= =?utf-8?B?SkFHRDk1RW9EdStPREY1TFV2QXNwcnMxRlVBZC9xSHFKanJkTnFJcFRjVnRz?= =?utf-8?B?MndYOHlIazB0UmJCa004cEp5SFc2SXJNVGpTQlBjaXFjeHlEcm5QWGo1VVFp?= =?utf-8?B?Zm10MGNJRjEyWVNrUGpDOHlUa0IzZHE0bTB5MW1ES2tjVHFuRzY5c2Z3dUFO?= =?utf-8?B?Y2MwV1U0ZGdCd2p5bkVmM3Jyd21BamZTRElpMXhwUVZ0WlBmalczejFNWmxY?= =?utf-8?B?cXpOU2RxaEczdjhzNWpOcE9LN2FMOUVsUForU2NuN0dhQzJIK0FVVFBhQTBq?= =?utf-8?B?bXVLZVcydGg4cCtrMXBhQktBeGFoeG1pWGh0TzlsdHVQVjJjT2MxZFZjUHpC?= =?utf-8?B?Rkd6Y0NBdFF2L2xzOEF2MGYrV0tVSnBOeUJ5NERqVEdvM0VDUENQc3M3RHN1?= =?utf-8?B?b0h6S1RtSmE4Uk9ybkpqaVZrdjl3OVdCZnF4RU93dnhJdGxkeHVQZG1ab2FX?= =?utf-8?B?R0pmL1N5dkhCWGRHNGxneFVoQ1FOc25KK1htemVFNVpRREhteldsV0FZeVd4?= =?utf-8?B?UzFtREMrM1lTYzdJTFdFVkdaaXRJMm1IMWZ4VW9waW41c3JuY1dxVS9LQmNH?= =?utf-8?B?Z2lqcm56ek9jWTVmT0ErNjlWeXloNWZjR3YyRDBUeHJ6NnRHZzlOTmlSNmly?= =?utf-8?B?TEowZkNwTDRYN0VKWDJDRFgwMEw1eXRjbUx5QjhVUTJ4UG5ZdnVwalZQV3NH?= =?utf-8?B?ZEh5TmwvZlhBYkNyVUphUXVKaFdGWFJyaFdzZFJyWThhcFdpVXZ5QkJzYXhh?= =?utf-8?B?c2oxdU9hcVh2R2VhSmpic1JSRE9zVWhwVTltRUNLQVE1UFlZYUpEKzV5RVpG?= =?utf-8?B?WFphSFZXWWpMSzREY1c0SllDdURQaVFvV1ZVcFpEcHpaQkRnL0NjbHBIM0JN?= =?utf-8?B?SUZVRmN2d2t4K0d6djdBMVlMZ3VNN2FIV0dWZ0E0NnJhc3NrakU2WkdhYWxX?= =?utf-8?B?aTdVeFlLSmYvdm8ydVJqVTBPYlJXQktNWWlJOUhrYmVDcUd6VFZ4OFBCeGVT?= =?utf-8?B?YTAxU3ppSXZoNUZUTVdLYU8zSVUyYUJ6QzBhUU9QWTh4ZWVBTmdsYmozUTlU?= =?utf-8?B?MmZEZVRkU245VktOU0dJZ1JzM1VUUXMvMGhPdTk5ekpTWFdXVTAwcng5dmdR?= =?utf-8?B?aENWbERFd2JvbkdwK3FmZHA3TWZQMkc1OTBLdkNDdForejNCM256YkhxblVT?= =?utf-8?B?czZNcG9vVmZ6NVBTaDcvTzZHWlVPNXdhR3duZjRUMGx2T09kR1JWNmpkdlpK?= =?utf-8?B?MEZWQnV3MVZHalFGeTM0N2RIVndIRWZ0bDRIK0JVdE8xUU0wSHhiZG94TGlh?= =?utf-8?B?WkVwMmFVSG9uTCsrcFY4WkVFVHU4NE1aWXNxV2pJYXFpQ1hEa2hMdW1xcGtn?= =?utf-8?B?SzRzMk90a1JTU3FTdHVhOVRQQnNzREwzRzk3TlJjdG10MDZwMVJpZHJwM09i?= =?utf-8?B?YWJZa1hxQmJXbFBrYzgrUzVUeXZRTllzN2JFS21Wc0ZkN1NXME1zamJvcXln?= =?utf-8?B?SXdYVFhYNUd6UUFjdVFHZGQ5UHJaTXJYdkprSnlYUTNtNVhhUEZlbU8xZ2t5?= =?utf-8?B?enB6V0l0QzdNUFkwTFozZmNmL1BpZWpSZjJqZGFrVXlaaDNsWnlOWEhzd25M?= =?utf-8?B?a2k4QnNlZFVFMlc0c1pRVzhaZG5ISGVzVEwrVkRxYkFwUWVNWEFuZGFmNVRL?= =?utf-8?B?SjhSQUxJZ1RsazFKZVc0Yi96ampwUGorRkM1Wk0ySmhVbkxmbHAzSnQ3NEM0?= =?utf-8?Q?dO5x49GuE2FzSYoxz412v5c/nTRRBA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PPF9A76BB3A6.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(921020)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkRTcTU3SmcwRHpLVDZNVk1vbmg3RzZ3Z1VpTzMwVWphK0YxWGxKcDJCWDdN?= =?utf-8?B?NTVucVlkTHJXLzhqbEN6STBtdWZSajYyc2htT1J0bXBZOE1yK2xmZGFRMkk5?= =?utf-8?B?bTRoWFpoYlJoMmlQQkJlejFQN3hvRUk5VFJjWHZOREJMRWZwUDh1aHpqb3dy?= =?utf-8?B?YW83b25DTFZCVUlGbVlXZU1zbFNuRFlDWUYvTngzVVpRa0d0ZWVKOGpodnRK?= =?utf-8?B?ZFdpMTdxVGd5Sld5MHZFbW14bFh2K3NMZU1IL2M2SWVHM1BLdm9jSmhVZzk1?= =?utf-8?B?YkU4bEdiRmM2TUhHZCtnT210UE9xK1QrVUk5a0dzNTZZbC9RL2oveTFwYnVP?= =?utf-8?B?UzkzK1pYdUlac3BGS2FFUFdXRURRMERCM2kyQTBWaExPZDEwUGNpTlNVV0lv?= =?utf-8?B?eWFZUXlyMmJ4MHpTOGpvWm9lRGZXMEk5NWZQcUZDUExOMjIxNDNzSVU1eUNS?= =?utf-8?B?Q3gyUkQ1Sk9VbWJOOTJFdEVuTHB6dzJ5UWRCa1R5ZjdkYmRMRnY5MjV6emZr?= =?utf-8?B?TVJFMzl3cDZHa0JuL1JsOFdhSEpPRXZDZEE1MnB0UGpYMU1TMHlBbS83R3Fa?= =?utf-8?B?cHdSNTJ5ZEFXN2ZMSkdJOVVQemhHNC94SjA2V0g1NUFOc29NbklzZWtnalEr?= =?utf-8?B?S01nOUF0Q2ltT25sRXB5Q3I5TFhvR21tWVFWM3l2MnEvV3paaHF0MEhBa3lK?= =?utf-8?B?WUN6QmZFTlZhNVkrZHNkZ3g1V281SHgvWDA5MCtBY0toQml3ZlZHcFF1bSs4?= =?utf-8?B?cnQ0d3FPYzQzTmFZOEczZllUbS91WndWelFZL1ZrZ3g0TFZhaXZnYnVyeVZK?= =?utf-8?B?M0kvam5aaTl0TVE3N1FKKzlreHN1bkIwQWtQaFlQbW1PeGEzNHFjWnphKzZH?= =?utf-8?B?SjlPTUpiYlJvRS9pZmpJREE0SzRJRFpkcGJTUnB5WWt4eGNwRytlUGhZZm1i?= =?utf-8?B?aURzdHI0S3lFUEFxUDJicjRFWkQydDh5OU5RMFg4UUlQVURFUnVDemhTZDJl?= =?utf-8?B?VlB5Umh1QUxHSmpzNjd5ZExBeElXT0prbzNTVHEwa1JtaldEN29WczZPZmd1?= =?utf-8?B?eDd3dGx3TjQrYzVqQTIvalZxb0VqZ2ZrK3RJL0wzZ3g5eUFMUVNub01HZXZV?= =?utf-8?B?c1JOaGJObk80VmZwWXRuUm1ZeE01NGV2eTJyUGZ5b1hyM2N6eTJRUGhoMzlO?= =?utf-8?B?eENRbHVNanB4T2VkYWdoVzZYQTAxYWN3TXRNVXJFM3NGU3NEaHhLbERDUEFs?= =?utf-8?B?dDBDQXo0dlQvc3cxVG9mVHlqMFAyRWdVR0pRS2J5U0Z5ZHBUenpQZXV2SlNt?= =?utf-8?B?R0JxcGd2MkR3alkvQS9Ic3BzRGpLWThlWUNKK2VsRUJyYWdPN0xxTlNkaEUw?= =?utf-8?B?UFV1MUJIZGpSY003R3NRcEErNUtyZUNCaW9HaW1WVUtwRCs1bUhtb0hvWFpa?= =?utf-8?B?a0RKQStwR05QU0ZpK0JjbXltK2cyOTFESFFFSlJpbzl6cHhwUWQ5L012YUFE?= =?utf-8?B?YVhTSXR6WGs4QkxCM3lJWmduK2ovOEx5ODZBRzMvQ3JCUVRUSllYOTZlTWdV?= =?utf-8?B?RkFDSUwycjRsK0p2dU96NGNVVVdNOEI3bDNITXcyQ3BxZ3lhWTVpaEdWZ0J4?= =?utf-8?B?TFZoTTBjbmN4OEg4anFCa3hHbEVFblp2M2JIZGp4SFoyaFUvajR0N1FyM1NW?= =?utf-8?B?UWpuNXM5YlBGemtpVDNNbFFoWGw2Wk1UZVp1Zzh6UnZvTWl1TFdSZ0wvMEVE?= =?utf-8?B?V0R6TG1OcXdGYjY2ZW1Xb2Erei9vT2wyOWhXaGIrclM1dTBMSjhMWitJUWlm?= =?utf-8?B?RlVJRm5YQ3ZXV3crTVJHSjdNQzV0YlJTM3Y1cERlOFV4Y2hsTENhOVZuMXNw?= =?utf-8?B?R3cyengzZHEzL3ZuNzJ4VnllTEJjRUxZYUpRQm91eVFUZ3dwZEtRYWJCbmdC?= =?utf-8?B?S0hyTTJxQUYwT0hxekhRaHNIc2ovZ05QMnV5dXpsR204Sko4aUxJUmE3a2JF?= =?utf-8?B?UVJHa2wyNURVMUhjRUR0MUpKOXNXeDljRW9vQmhZc2dGMm9HVC9yRDdKdVBo?= =?utf-8?B?alFvaURVUm9UZ1FnUndSY1l3OTlzZTN3QXhFQUlQRjlDeldsQ3Zxb2hXaFp4?= =?utf-8?Q?vhIpV+4r5Abc2TKqPjoYhyjDG?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2dcda72-27da-4039-ffb0-08de34357865 X-MS-Exchange-CrossTenant-AuthSource: IA0PPF9A76BB3A6.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2025 19:35:39.2946 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zVimZDZRjkug7OOb/E6QK9dhTNo7eb89ZjnQf0TkaASqfECwPDr02N79/chRor8V X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB999090 Hi Aaron, On 11/26/2025 11:16 AM, Aaron Tomlin wrote: > This patch introduces two helpers to validate io_alloc support and > whether it is enabled. This reduces code duplication, clarifies > intent, and preserves existing semantics and messages. > > Signed-off-by: Aaron Tomlin > --- > fs/resctrl/ctrlmondata.c | 74 +++++++++++++++++++++++++++++----------- > 1 file changed, 54 insertions(+), 20 deletions(-) > > diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c > index b2d178d3556e..5f6f96d70e4a 100644 > --- a/fs/resctrl/ctrlmondata.c > +++ b/fs/resctrl/ctrlmondata.c > @@ -758,6 +758,50 @@ u32 resctrl_io_alloc_closid(struct rdt_resource *r) > return resctrl_arch_get_num_closid(r) - 1; > } > > +/* > + * check_io_alloc_support() - Establish if io_alloc is supported > + * > + * @s: resctrl resource schema. > + * > + * This function must be called under the cpu hotplug lock > + * and rdtgroup mutex > + * > + * Return: 0 on success, negative error code otherwise. > + */ > +static int check_io_alloc_support(struct resctrl_schema *s) For consistency, how about changing the name to resctrl_io_alloc_supported() and resctrl_io_alloc_enabled() Thanks Babu