From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752088AbdFHCnb (ORCPT ); Wed, 7 Jun 2017 22:43:31 -0400 Received: from mail-by2nam01on0040.outbound.protection.outlook.com ([104.47.34.40]:18208 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751764AbdFHCn1 (ORCPT ); Wed, 7 Jun 2017 22:43:27 -0400 Authentication-Results: quantenna.com; dkim=none (message not signed) header.d=none;quantenna.com; dmarc=none action=none header.from=quantenna.com; Subject: Re: linux-next: build failure after merge of the wireless-drivers-next tree To: Stephen Rothwell , Kalle Valo , Wireless , David Miller , Networking Cc: Linux-Next Mailing List , Linux Kernel Mailing List , Dmitrii Lebed , Sergei Maksimenko , Sergey Matyukevich , Bindu Therthala , Huizhao Wang , Kamlesh Rath , Avinash Patil References: <20170608122759.7ffda0c3@canb.auug.org.au> From: Igor Mitsyanko Message-ID: <3594bd0d-e2b4-a380-ba06-8dedbbcbe11f@quantenna.com> Date: Wed, 7 Jun 2017 19:43:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170608122759.7ffda0c3@canb.auug.org.au> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [12.131.200.68] X-ClientProxiedBy: MWHPR18CA0038.namprd18.prod.outlook.com (10.175.9.152) To SN1PR0501MB2045.namprd05.prod.outlook.com (10.163.227.18) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PR0501MB2045: X-MS-Office365-Filtering-Correlation-Id: 3d188847-5c96-4298-c0bd-08d4ae182270 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:SN1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0501MB2045;3:fTkJ/Hbobl43zqCGWlrmxaYVBpF3x52UnwQcon7kNvR/LOD+gBMHQCCXn3PJYYBQFCM35EAdLlBopNAeKrf1U6BlS0BpjwKWrQhsnwoQlPwj85YxUjkZ0gg4vefvO2RCpW6H6l8EFjuaU85vj/H8QOkEaouEUDeM+ob0KD/g58mcsbD0oePnzuzBH4pkyxkjj738feY4A8SU6h6zRYp57oGdN0fCvOMSXRvtET2gpnRQCqQDH03PqxVdNYWoB9oPzsjfG5MC6eIJYCg5qT0VbENKzV/dMDP0KE2jtMai5slPof93vXCyCSvoqwjI8JQhK4BmHMDF1c64DEgeeuiIcQ==;25:jKU4g7xPi4JNSPusNnxBMlLsaI2lnQC1uyrYoklh/mA3+sLk7gaIKTMW9BuczBMlvVUb8fuFjCl0E0OQM2TvFYGq/WwOMO+GAZnWmgW2Yrf2lqU4pIONGNjNN/qdeZZYdBpR4uzE0eudRQSjOkYZSZlpEqR1phR+AxmxxE+A4zV2T09kpw2oIpdCAx/mVSG1dubP6smJPSlw71DRAl/k7V73hcM0TzQyEYif8l46rc2/0qrv7gCA/1aMa6xej0UbCY9O/f7zD4qzvW+ySBZ8ZwPvdDKUFrkeIPYipB/ObGVGBF00JR6E/yn19SVdKDgo4H9NkTa1hrkH657RKLgRTMKcq0+i5G9CHSBAu46PbZAUct9XS+BcoAJ7PfiM2UgiUW44RcGEUePE5dGiJmEQ8mrFz2Z0lZOZ7RsNjhIhIQBSx+CA1e09jWuVig/Pt5+LaPeuuaTfTetPz4Ilzns7b2Yw8rSZqcddAqHf4a21DdU= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0501MB2045;31:4hF/AnxVrvVZKWnwzLmamshfgPYoc+CzocQDjjMW48C84nh8k57KOFnKqik/CkikYKhwLzBwNGc7BYa24Fv2PkH4cYhrqM3PaCC7X0JWkiaJxjlsqRVAIrvBJBCcgkNIcR3I9IKNGHuUY+Y/q9gM1p+IxneXwIkcHp6w0fag5KZwmPsb3/8Cm5ZUZKt1JdvGHkVQVDI3/Kll0O7q6XLkJeeB5CVCx3Mt4qCrWAgghck=;20:0189Sme3nGIFtPcxaRMv0untsGmbYaGFQX2K8PRYPSZgbqLIHB/qrr7QjicSIGosQXsyUsNQo7CuvFJ2/NrEHhIVhI8ULqCeHfAesM2BxSnwR3QGIc2thix7KaCwKu2ISfOIP8uMWBAu4aVozVmO91uMVh/neY1lZicbzr1DW0v0YzTd8MkAL0L2+rZEe8Y9GTpOTwamtp2BVUyd8Z1X49lkvzMpWaVXKzON5aHPK7HIOXgRAkiHOw++N2JRuEEsrI5ABwDZStY7nX7f/2T8ZHdjW8Is7oNxYQQWIco2DLjcTll+Arrs3AqonYflgfleyKbeVit4H9Pk2CPC88UV7jQPkBbbss3XAOpU4IZIHwAumQKU2mIgW1LxPoD2sPTepeQ7se5cPFrzjs9L3mhR9vZ4D17O/XkMRH8rBX+bL7FxmnpAzuJ7YJyRdiV26RAh7DQWGDQNHMgIMJqepkJicCek3RrIcKARJOelLD0LBob7JcbLnzAmKf+GWCRUi8T63sEq8Kerb/Q2CKSdSKd6pnwFiIhQLoagnZIh/npnuNS2oiIco8h7a+z2B6kop0rOluqWtW0ia2u7aUuZpUpYaQ2XEv1uoqYLgyyHJ0PdrdU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123555025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR0501MB2045;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjA1MDFNQjIwNDU7NDpxWDRQVGZndjlHVUFYZ3lBSEIzdmk1WG9O?= =?utf-8?B?aDI0REdpUEp4TDN3bSt0bFAvTlhKSHI5cjI4ODNlVnVkRy9OMEZMbEZtWlR1?= =?utf-8?B?TEVrQldpQ3lwaUJwRDQwOVF6a2lFRmhHS0xnbWVjdVJWNGFseGRRUkhkelV6?= =?utf-8?B?R28rMi9hQkVXK1NwM3d4ck42UTlzd1B4OUtVYWpvdksrci85M3I0QnJKSFUy?= =?utf-8?B?U1FFeGJ3ZENJNi8vSUZCZ00rUk1WVlhFZnV6dmh4S3NLU3lLaEZNbldPamhs?= =?utf-8?B?SnByclovTXMyRXNYaGh2YmxuaGVqSmFXZ0dZa2U4K2FiZ1pjNmFBV2hWUk1x?= =?utf-8?B?bkU1anV0dXlPV21BRCtqU1oydGJBeXJrNGJRZ2Nxd0NVWUFxK0lna1ViZ25J?= =?utf-8?B?YWd1L1huUTlkaXhPZnpGRjZ3VnNRMWZUOWUvbjNMRHoxakhLS0RseDZSNjBK?= =?utf-8?B?dXN4VDN0Y2hVWUE0OFRDWkhBUXlXR1EwWEJ3YVVzUUsvNlJkZkJTbU9NZVYx?= =?utf-8?B?alRnaFlzRWJ0QTMxcWxtQSsreEpMV04zV1dIVjJvUmplM3hBVStYQyt3UnNz?= =?utf-8?B?NDdCMlhSVzM5ZzZGdmNjL1JUZHEydzNYTFpMRzFOL21Kc2VNZW8vMzJtcFhC?= =?utf-8?B?T1I5cjVqL09kZmt4b2dnUmNJT3VSM3JMZlpkRnZZdlQ3Vzk4Vitva1phNm5J?= =?utf-8?B?bVFjU1JUTjhqME81Q2hKZ2h1am9TbU1OUm41dVdINERMSFg5c3BHK3U3WDdY?= =?utf-8?B?ckZrNVh1NVdIcEkyMW5jYmxwV2xqdE9UdFI2V1VkMk1TWnMwaGkxaWhxODA4?= =?utf-8?B?S1pZcFJndDkwVVpsd2htZGNPK2RXQmFGQVFtMXk0bFo5djRFZjJzTTBxMG9I?= =?utf-8?B?cTlQSFpaZ2R0dEZJYjdlcURLWktCbkVTRm5QU1hhR3pDS0hxQThGaU84U2Nv?= =?utf-8?B?SjZlT3BJYkN2d1hHNTFLV3llWm5wT0l2RXduWWFuc2R3a2NVRzl3N0JxT1Nk?= =?utf-8?B?UXRuazl3NWFLMUhlL3U5Q2xDZUorRXVPcE1Td0RKWDdoYXlZbG42Y2tNN0xw?= =?utf-8?B?NVNtMXhyVnpvdk5jMEJWUWh3WlI2M3R6akx5VEMyUnlYcC9ranJRaHVzeVV5?= =?utf-8?B?K0RHZXlsbVFqMHNUSXNTWU9oZkZCenlYMTQ1MitZaDlsaFlYSEdWS1V2KzZH?= =?utf-8?B?RlBhUUhjWk1rOGZvenhaSzhQWXhxMGdOeUdNTFkxVnIvMHhEZ0JROEJ5Ympy?= =?utf-8?B?Nk16VlB5THhWZ0xZSzEzd0IvNTY0TE1wamVaRFNGWU9kYTlVYjUxMGt6UHVF?= =?utf-8?B?VlFwd3VVVTVBZCtjTnBPTnpOcUtqZXEzeThaUURVMG5zcjRqQUVjc2J4N1k2?= =?utf-8?B?UUg4SEcxUkc3NmlxdEx2SjdmUGJMNmdYaThEanRYRHdMcHNONG9GUkcxMlky?= =?utf-8?B?RERHaVZlTlZ2MThvL0tOdFpYanRkSzJTaWNnTDVZbEgyamZGUXVRYTBXdVNN?= =?utf-8?Q?IjsZ8WCQst2DhAweIdjhcylAcTAJWjTj8CBi/tXq3/zQvVx?= X-Forefront-PRVS: 0332AACBC3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39410400002)(39450400003)(39830400002)(39400400002)(24454002)(53754006)(377454003)(31686004)(6486002)(229853002)(77096006)(230783001)(2950100002)(230700001)(6666003)(4326008)(53546009)(86362001)(25786009)(575784001)(42186005)(31696002)(47776003)(8676002)(76176999)(3846002)(305945005)(7736002)(6116002)(54356999)(81166006)(50986999)(23676002)(5660300001)(65956001)(66066001)(107886003)(5890100001)(50466002)(36756003)(478600001)(53936002)(38730400002)(83506001)(33646002)(4001350100001)(189998001)(6246003)(54906002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0501MB2045;H:[10.10.121.34];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjA1MDFNQjIwNDU7MjM6MWVyTHhjVVdQTmM0WTl1TFpJK2l3ejJR?= =?utf-8?B?bktLNHdjY2pjSEVjZ3ZMdExVQ1hHbllabm4wMm5KcHNaV3ArcGpJMmdiRzg4?= =?utf-8?B?c21rZUdRb0l5STdnV1preldFQ2N4UUEyQWxJZUVHNkdodzlGRk9nbmh6TGFs?= =?utf-8?B?Y0FhY0p2amlXUmRmeG9yMllMWXFnUjBCRHJBbncralZnd1JMcjZsVDJpa2ZX?= =?utf-8?B?ZWQyU0RKbk5aZW00TUVpVlg1bTF6YVdnNzFZbFd5SCt2clRjeC90dzRVUFpC?= =?utf-8?B?a08zWWFGaTYrb1Y3WnN1T3FWaE5DVHNJTS9MS1NiNHAzbG1nejhtWFUyOVdt?= =?utf-8?B?S0lhTXNoeFJmVUVsVWpFNHNNdjBJRGNrSnpuTDN1VUhCZzYxZDNXQjd2YWlN?= =?utf-8?B?YlIvQlI3UnQzY05hRmVmbDZSZi9YU2ovT3RVM25hYUpkdWg2Wkp3bncxdFU1?= =?utf-8?B?d3ZWUkNwbWtJU1ZpOFR0Yi9jR2VET1R6OEpDNStYRlBlajUxYXJVRHNiL0Ft?= =?utf-8?B?bGNsY2tndi9TQmJhL25vZVRGZ3Z0azBTNnU3ZFRRNjQ0R3c3cFkwTjhhdHRz?= =?utf-8?B?L1JkNjlycFVEanJzaE80VUI5dXRlbDR4SFFMcFpFRFd4RkdobnhYeWhmc2k2?= =?utf-8?B?T1NaaGtORDh2b2NVZDV1ZjFxdFRQV3pabUFyRklLS0w1b3YzUENNU1k2Mnhl?= =?utf-8?B?b0NuUCs2M294VVFwZEVEQXlPMXZoS3M2VWZQU3ZSOXpSSmNJeml4dllLQU9h?= =?utf-8?B?aHlzNlJ2Z2ZWM3VEVlUwcndtemVOMmMvK0RkRzgwbmZvcEFhVjlOSUlnbzF3?= =?utf-8?B?WkRNRER3bllOV0pKNGRQWUdCQjgxY0N2SGxlUTlTQW5tOG95Z29wTDZEL0Rv?= =?utf-8?B?ZC8vVnArOGcvWjc5bmJMZTUxQ2FkOHBZUUdqRFdwekcxcmFaRWZ1eVJuMy9m?= =?utf-8?B?eHIwU0hWZVFrMEhEZzhxTzMrMHFuN3hnYjUzT1QwU0FsNndXVVVRRm5BaC9R?= =?utf-8?B?WGQ0WkRBN2lRc1hObFF2WEUrMmkzZmFWeGY0QWxGNnJDQnZUc0dKajBrRGZD?= =?utf-8?B?aW9nNDZEMXVhK0RIT2RlZngxKzVsTFl0Szc3UTQ3bXRMYVJkdmZ4QmFzdTAx?= =?utf-8?B?R2NRa1R0Y0Z5dyszVCtEVEVFZkpRNitSNEhZeHo4WTlvQ0JYM0VJcjkxVE5H?= =?utf-8?B?c0J0blJ6NlBmQzlKdGVKWG9veXM4SVJwdEdDRlV3YTRkd0lMaXcyL2xqVXZC?= =?utf-8?B?ZVlOcnJVRnNyVzBLRmtOV3ovVTRFREw1UXdhVXRiVnhtL21HZlhSR2lvNGdY?= =?utf-8?B?VHg3YW80b0FSclkvcDYwdWVQYURIVmFZZWF3TE5zZ3VvSlBhYzJOM3hURlR0?= =?utf-8?B?NHBRREZueEpqK2ZZbzZoYnJOQU9CZ2YwQzhUcm9yMzZ3bEdkZ1RSbGk0UVF3?= =?utf-8?B?cGxGMk4rTlhOVzBkZDR5a05LL29RcjFENXY1dlR1b3dRSFJadE5ZSWtoelhl?= =?utf-8?B?ZTgrT0k0SnR5bGlkQVhhdHFBWWFQT0FBNWZraStnWThqREp6Rnk3cUppU3F4?= =?utf-8?B?dWp4a0xqdWVhMGdWdFJ1WlBNYW5rZDBCbzN1YUVud1ZvWHVFNkk5c1ZXYUZ6?= =?utf-8?B?Z3hyamhLeFZEc291ay9yUFlCTVZCZ3VMc3Bmb21vT3pTeERGd01XQVdUTzVw?= =?utf-8?B?K2NJU0JmOE0vcXJnK1pZRlhwOENMYkZkOEZpdnJIKzk4Y3VKcEhYa0gwL0JL?= =?utf-8?B?TUFQQSszZ1hUSjVZVEZ4bVV3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0501MB2045;6:rkKrsYkEO8ZxgXWO4YzuxIGsnjoGCaBFgi8kUKufpdPWI7hd6qZ8KDSnOSH2cNdESmpQpYRjpOPZU07Rm0Pq9sxfqBy6kZAgksDwfawn9dw5l5W4+iB/NDnnzHiqpdLqzBWYGRb7puyKnAZQZSd8PUoS3nD2QA03m9v43JcSjn1XTIV3mqFISMkprqG3OM0nNlXqFmDQdWF4/toEG6joe5MiqgSbHERmBASl5w0l9lspfb/PfIT37o5nJ7MmpoomWnjnlig1Q0Iz++71Jb+DjZ7sKO+dBtOqb0MU/72YZo5oInMcCznc/+8VktdtwlcosMvMQSn3VoS10usrgQAmBiJ7Ls25L+kANr8abvMj0KkITrOLsLoglnGNm7iYUsvepBxOQG7+ZWyvcYYCJ4ChblTCyLNgSk4lTnxSixpHJ1fUMN+0+dLM0HnbPYq2RMOvTzIX86+tta4k5+Jj145Pr20FLmCROhxFv04k3m4ZBT4LVQQl854XDTzeGJyTpBpbnzZuuKwYb3+cJT+BMJsILw== X-Microsoft-Exchange-Diagnostics: 1;SN1PR0501MB2045;5:TBCyJ2N6UbNk6FVdHQkcaL5oQQxrfVEO9BjX3rmr+D2H4qtb+cp8JblhxKLmx9HL89w7IRDFd5/Uop5J9n8mDUwJuWsajhaSflGFjUUjJNcwP++NHGcLbeeq5FhgPo0vif6lhsdn4J/qY3lnbj+upWdbUTZnRFLhoLSkfServOQAWnrK523lfINTpjZA3GUAcza+YpQDB72BPVZXpO2Ljy/n64ivxs+rQi5IaQp+OiPk+Ua1C7jv34pOzVqbO42ukFttkFpfyusBhbBXBbXw82pUNbsaorzDlBmnVejryUQEfhhgHd2JZYar8A02YjwUq93eYzUgLqxIsVocW+/bgBRpTz+e7gbyFJro4TUGQBEYOGH0UblGTVPwZIIpVwCZAVsNiXI7KCOGgquvWs2Eb4F57dt1fGjDNHX9nuYVjilqBrYTV1zu8G3CkiJX9+QZrIp4032DBYxMjoA++MGatkJGAvGGqT61Lda6xrM1fD+HX1bkm+YQR8c5LpWYb2LD;24:mR1HWhS5Q4QTl1JTyRV/7KbcJZNFxHU1nolj6sb++7prPsuH4hJo/QxrfX/COgTNpdiisAR5TB/9tSZBAjTInsbyBZ6NsEm9/aM4PtiNAdo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR0501MB2045;7:sxXA0RNkQJ3GFLJetU4GJgSt+2DitQYWdIOo61EVfVJVkiif8roK6zge4P+tNG+TQJEcPJAJ2nBCLXIxlZ/QljMyr7+DQapl/9PiclhgdbxRBdAgCtUJF3Wdxe8cwuBLYHn6Hdnc9AXZokDse7VYt2mMbqeQy81Cl5iOjrV8iI6ouARTyFJROAJ33CqUjBAU9uklGaMRP8tEC1IpcsXidAGCpIKZv8MCLyR2xQ1LCYj8YdMoUYmWtNfghcHklMpNZ/82m8CYIVKpmLWZ8JeQECCqzKSMzsBzBFSO0Q0puY4NsyaNw3ygsssWZqV+Ay56moKYhETyU6IgveR8ZcxY8A== X-OriginatorOrg: quantenna.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2017 02:43:22.6501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0501MB2045 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2017 07:27 PM, Stephen Rothwell wrote: > > External Email > > > Hi all, > > After merging the wireless-drivers-next tree, today's linux-next build > (x86_64 allmodconfig) failed like this: > > drivers/net/wireless/quantenna/qtnfmac/core.c: In function 'qtnf_core_net_attach': > drivers/net/wireless/quantenna/qtnfmac/core.c:319:5: error: 'struct net_device' has no member named 'destructor' > dev->destructor = free_netdev; > ^ > > Caused by commit > > 98f44cb0655c ("qtnfmac: introduce new FullMAC driver for Quantenna chipsets") > > interacting with commit > > cf124db566e6 ("net: Fix inconsistent teardown and release of private netdev state.") > > from the net tree. > > I applied this merge fix patch for today. Hi Stephen, thanks. As I understand, you've applied this patch during a merge and no further actions are required, correct? > > From: Stephen Rothwell > Date: Thu, 8 Jun 2017 12:24:08 +1000 > Subject: [PATCH] qtnfmac: fix up for "net: Fix inconsistent teardown and > release of private netdev state." > > Signed-off-by: Stephen Rothwell Acked-by: Igor Mitsyanko > --- > drivers/net/wireless/quantenna/qtnfmac/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.c b/drivers/net/wireless/quantenna/qtnfmac/core.c > index c5ac252464f4..f053532c0e87 100644 > --- a/drivers/net/wireless/quantenna/qtnfmac/core.c > +++ b/drivers/net/wireless/quantenna/qtnfmac/core.c > @@ -316,7 +316,7 @@ int qtnf_core_net_attach(struct qtnf_wmac *mac, struct qtnf_vif *vif, > vif->netdev = dev; > > dev->netdev_ops = &qtnf_netdev_ops; > - dev->destructor = free_netdev; > + dev->needs_free_netdev = true; > dev_net_set(dev, wiphy_net(wiphy)); > dev->ieee80211_ptr = &vif->wdev; > dev->ieee80211_ptr->iftype = iftype; > -- > 2.11.0 > > -- > Cheers, > Stephen Rothwell >