mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: jacopo mondi <jacopo@jmondi.org>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	geert@linux-m68k.org, magnus.damm@gmail.com, robh+dt@kernel.org,
	mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node
Date: Wed, 21 Feb 2018 20:53:53 +0300	[thread overview]
Message-ID: <35959135-cb3b-040a-1944-26845e0c07b0@cogentembedded.com> (raw)
In-Reply-To: <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com>

On 02/21/2018 08:38 PM, Sergei Shtylyov wrote:

>>>>>> Populate the ethernet@e6800000 device node to enable Ethernet interface
>>>>>> for R-Car M3-N (r8a77965) SoC.
>>>>>>
>>>>>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>>>>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>>>
>>>>>> ---
>>>>>> v1 -> v2:
>>>>>> - Replace ALWAYS_ON power area identifier with numeric constant
>>>>>> ---
>>>>>>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43 ++++++++++++++++++++++++++++++-
>>>>>>  1 file changed, 42 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>>>>> index 55f05f7..c249895 100644
>>>>>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>>>>> @@ -520,7 +520,48 @@
>>>>>>  		};
>>>>>>
>>>>>>  		avb: ethernet@e6800000 {
>>>>>> -			/* placeholder */
>>>>>> +			compatible = "renesas,etheravb-r8a77965",
>>>>>> +				     "renesas,etheravb-rcar-gen3";
>>>>>> +			reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>;
>>>>>> +			interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>,
>>>>>> +				     <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
>>>>>> +			interrupt-names = "ch0", "ch1", "ch2", "ch3",
>>>>>> +					  "ch4", "ch5", "ch6", "ch7",
>>>>>> +					  "ch8", "ch9", "ch10", "ch11",
>>>>>> +					  "ch12", "ch13", "ch14", "ch15",
>>>>>> +					  "ch16", "ch17", "ch18", "ch19",
>>>>>> +					  "ch20", "ch21", "ch22", "ch23",
>>>>>> +					  "ch24";
>>>>>> +			clocks = <&cpg CPG_MOD 812>;
>>>>>> +			power-domains = <&sysc 32>;
>>>>>> +			resets = <&cpg 812>;
>>>>>> +			phy-mode = "rgmii-txid";
>>>>>
>>>>>    Why not just "rgmii"? TX delay is a board specific detail, no?
>>>>>
>>>> I admit I took this one straight from r8a7796 dtsi.
>>>> Would you like to me resend and change this?
>>>
>>>    Yes, unless Simon would fix it while merging...
>>
>> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
> 
>    Yes.

   Apparently that means that this prop should be overridden in the board file
(which may not be an easy task given the board is Salvator-XS again).

[...]

MBR, Sergei

  reply	other threads:[~2018-02-21 17:54 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 15:12 [PATCH v2 00/19] R-Car M3-N initial support Jacopo Mondi
2018-02-20 15:12 ` [PATCH v2 01/19] clk: renesas: cpg-mssr: Add support for R-Car M3-N Jacopo Mondi
2018-02-20 18:46   ` Geert Uytterhoeven
2018-02-26  8:14   ` Geert Uytterhoeven
2018-02-20 15:12 ` [PATCH v2 02/19] soc: renesas: rcar-rst: " Jacopo Mondi
2018-02-20 15:29   ` Geert Uytterhoeven
2018-02-21 16:45     ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 03/19] soc: renesas: Identify " Jacopo Mondi
2018-02-20 15:40   ` Geert Uytterhoeven
2018-02-21 16:50     ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 04/19] soc: renesas: rcar-sysc: Add R-Car M3-N support Jacopo Mondi
2018-02-20 15:44   ` Geert Uytterhoeven
2018-02-21 16:54   ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 05/19] pinctrl: sh-pfc: Initial " Jacopo Mondi
2018-02-20 18:35   ` Geert Uytterhoeven
2018-02-20 15:12 ` [PATCH v2 06/19] dt-bindings: arm: Document R-Car M3-N SoC DT bindings Jacopo Mondi
2018-02-21 16:58   ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 07/19] ARM64: Add Renesas R-Car M3-N config symbol Jacopo Mondi
2018-02-20 15:44   ` Geert Uytterhoeven
2018-02-21 17:03   ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 08/19] ARM64: dts: Add Renesas R8A77965 SoC support Jacopo Mondi
2018-02-20 15:45   ` Geert Uytterhoeven
2018-02-21 17:06     ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 09/19] ARM64: dts: Add R-Car Salvator-x M3-N support Jacopo Mondi
2018-02-20 15:46   ` Geert Uytterhoeven
2018-02-21 17:15     ` Simon Horman
2018-02-22 11:39       ` Arnd Bergmann
2018-02-22 13:28         ` Geert Uytterhoeven
2018-02-22 15:38           ` Simon Horman
2018-02-22 15:46             ` Arnd Bergmann
2018-02-20 15:12 ` [PATCH v2 10/19] dt-bindings: dmaengine: rcar-dmac: document R8A77965 support Jacopo Mondi
2018-03-01 21:50   ` Rob Herring
2018-04-16 11:09   ` Geert Uytterhoeven
2018-02-20 15:12 ` [PATCH v2 11/19] ARM64: dts: r8a77965: Add dmac device nods Jacopo Mondi
2018-02-21 17:18   ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 12/19] dt-bindings: serial: sh-sci: Add support for r8a77965 (H)SCIF Jacopo Mondi
2018-02-20 15:46   ` Geert Uytterhoeven
2018-02-21 17:18   ` Simon Horman
2018-03-01 21:50   ` Rob Herring
2018-02-20 15:12 ` [PATCH v2 13/19] pinctrl: sh-pfc: r8a77965: Add SCIFs groups/functions Jacopo Mondi
2018-02-20 18:36   ` Geert Uytterhoeven
2018-02-20 15:12 ` [PATCH v2 14/19] ARM64: dts: r8a77965: Add SCIF device nodes Jacopo Mondi
2018-02-21 17:20   ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 15/19] dt-bindings: gpio: Add support for r8a77965 Jacopo Mondi
2018-02-21 17:20   ` Simon Horman
2018-03-01 21:51   ` Rob Herring
2018-04-16 11:12   ` Geert Uytterhoeven
2018-04-16 13:07     ` jacopo mondi
2018-02-20 15:12 ` [PATCH v2 16/19] ARM64: dts: r8a77965: Add GPIO nodes Jacopo Mondi
2018-02-21 17:26   ` Simon Horman
2018-02-20 15:12 ` [PATCH v2 17/19] dt-bindings: net: ravb: Add support for r8a77965 SoC Jacopo Mondi
2018-03-01 21:52   ` Rob Herring
2018-02-20 15:12 ` [PATCH v2 18/19] pinctrl: sh-pfc: r8a77965: Add EtherAVB groups/functions Jacopo Mondi
2018-02-20 18:36   ` Geert Uytterhoeven
2018-02-20 15:12 ` [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node Jacopo Mondi
2018-02-20 15:30   ` Sergei Shtylyov
2018-02-21 10:07     ` jacopo mondi
2018-02-21 15:48       ` Sergei Shtylyov
2018-02-21 17:31         ` Simon Horman
2018-02-21 17:38           ` Sergei Shtylyov
2018-02-21 17:53             ` Sergei Shtylyov [this message]
2018-02-21 18:23               ` Simon Horman
2018-02-21 18:53                 ` Sergei Shtylyov
2018-02-22 15:54                   ` Simon Horman
2018-02-22 19:08                     ` Sergei Shtylyov
2018-02-23  7:06                     ` Geert Uytterhoeven
2018-02-23 15:07                       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35959135-cb3b-040a-1944-26845e0c07b0@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=jacopo+renesas@jmondi.org \
    --cc=jacopo@jmondi.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®