From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A76C7EE29 for ; Fri, 2 Jun 2023 19:11:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236936AbjFBTLi (ORCPT ); Fri, 2 Jun 2023 15:11:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237106AbjFBTLf (ORCPT ); Fri, 2 Jun 2023 15:11:35 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DBDA1BE; Fri, 2 Jun 2023 12:11:32 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-75b01271ad4so231746885a.1; Fri, 02 Jun 2023 12:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685733091; x=1688325091; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=opFi1JTQYsq9CCCUgt1EEOObmcMhgBVZV9dRUuWuSGw=; b=pIxmdQ9XfmOIJbx8yTczNiD0X4sZxgFu6m69eJeQcAmnOTkyt13Ysou4KnDPwWGX+T Z96wFpf/1GVU9lau6s1oWmMzsU1+EA+ev3oelwbYB6NCTd6oCZ7L6WvEA4THlQNO5oH2 6eln1MDKzfP1KUyDqB/Me61IBYPvdTcipm1mIFA1/zcC6eMyOBnfCgwhhsynmOEUjPPB J8ak6QzjrT8n+2qgwkhN2gJAkY2/A3xqRAfDHKREYrS5XYzZWxvdFPGrhG8r/L+7pv9/ Fwl+t5BNiO7Jq4vXmaQBRLF7IW1cZIFaS52KHotah1KIgcXTSgtW0OpMm/WXgiwWT0GK 062A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685733091; x=1688325091; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=opFi1JTQYsq9CCCUgt1EEOObmcMhgBVZV9dRUuWuSGw=; b=lxyswwKpNflAiICsr2HmG/xsVZoODxNPz7/ZhUs0eKT0bmukNg7V+VcNghar4Goxnu ZuVEHFrYt4JiTfZ1RocIIjOqlHmhj05Kcv9MI8o7N4j0DtvZKLKUA3PJulSfp+AOLhjq 7D1DgloV9zwU+ZJBi60G2i22spuLlOBgMgOKQq87lJXzxbXcTpBZZULQ1yFzagWGA8N9 Zt/UqCK8tav9eIoV7jP7XpIP8sxA9so9Bw/RGsgauV+3XqsLEte+zHVj28kHzxFS1Bt3 uAQusB8sH/S99mPW4gcYRwkbWlypMYvjmr9rzMgjZl3Qoa8TBuGMR17Vj6oh5NLP9m/4 m1Qw== X-Gm-Message-State: AC+VfDxU8NkDkgeeuR6yejP43WOWdr+JX8pPiRawWrg29QWySUHW9QoP nWG2j1Yzy5UyjHNx8mC9ufQ= X-Google-Smtp-Source: ACHHUZ6YnUoaCGLE6lsrpxVhurfAkr9IE0o/Fi5tnPsc12SxFMiaxgHFvtsALAFo4/50VjKKYKOnPg== X-Received: by 2002:a05:620a:4003:b0:75b:23a1:8347 with SMTP id h3-20020a05620a400300b0075b23a18347mr17217065qko.66.1685733091668; Fri, 02 Jun 2023 12:11:31 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id t7-20020a05620a004700b0075b327a2988sm936705qkt.133.2023.06.02.12.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 12:11:30 -0700 (PDT) Message-ID: <3597b0be-2dc9-5dbd-a773-6dd5704ef4a9@gmail.com> Date: Fri, 2 Jun 2023 12:11:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 3/3] net: phy: realtek: Disable clock on suspend Content-Language: en-US To: Detlev Casanova , linux-kernel@vger.kernel.org Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, devicetree@vger.kernel.org References: <20230602182659.307876-1-detlev.casanova@collabora.com> <20230602182659.307876-4-detlev.casanova@collabora.com> From: Florian Fainelli In-Reply-To: <20230602182659.307876-4-detlev.casanova@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/23 11:26, Detlev Casanova wrote: > For PHYs that call rtl821x_probe() where an external clock can be > configured, make sure that the clock is disabled > when ->suspend() is called and enabled on resume. > > The PHY_ALWAYS_CALL_SUSPEND is added to ensure that the suspend function > is actually always called. > > Signed-off-by: Detlev Casanova Reviewed-by: Florian Fainelli -- Florian