From: Maurice Hieronymus <mhi@mailbox.org>
To: Danilo Krummrich <dakr@kernel.org>, Benno Lossin <lossin@kernel.org>
Cc: aliceryhl@google.com, acourbot@nvidia.com, airlied@gmail.com,
simona@ffwll.ch, nouveau@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
ojeda@kernel.org, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, a.hindborg@kernel.org,
tmgross@umich.edu, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 1/2] rust: macros: Add derive Display for enums
Date: Mon, 05 Jan 2026 16:23:20 +0100 [thread overview]
Message-ID: <3599677c19457baf5a68ddff563b6c9d8effdca6.camel@mailbox.org> (raw)
In-Reply-To: <DFGQUPHJVF5M.3EZ2KL4XIMDJH@kernel.org>
On Mon, 2026-01-05 at 16:00 +0100, Danilo Krummrich wrote:
> On Mon Jan 5, 2026 at 3:42 PM CET, Benno Lossin wrote:
> > I'm still skeptical about having a derive macro for `Display`. What
> > about adding & deriving the following trait instead:
> >
> > pub trait EnumVariantName {
> > fn variant_name(&self) -> &'static str;
> > }
>
> With a derive macro for this trait, that sounds absolutely reasonable
> -- a
> corresponding Display implementation becomes trivial with this.
Sounds good to me too. I will change my implementation and send a V3
shortly.
next prev parent reply other threads:[~2026-01-05 15:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 20:07 [PATCH v2 0/2] " Maurice Hieronymus
2026-01-04 20:07 ` [PATCH v2 1/2] " Maurice Hieronymus
2026-01-05 9:02 ` Benno Lossin
2026-01-05 10:29 ` Danilo Krummrich
2026-01-05 14:42 ` Benno Lossin
2026-01-05 15:00 ` Danilo Krummrich
2026-01-05 15:23 ` Maurice Hieronymus [this message]
2026-01-05 16:11 ` Gary Guo
2026-01-05 21:11 ` Maurice Hieronymus
2026-01-05 22:03 ` Danilo Krummrich
2026-01-06 5:56 ` Maurice Hieronymus
2026-01-06 12:56 ` Benno Lossin
2026-01-04 20:07 ` [PATCH v2 2/2] gpu: nova-core: Use derive Display for Chipset enum Maurice Hieronymus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3599677c19457baf5a68ddff563b6c9d8effdca6.camel@mailbox.org \
--to=mhi@mailbox.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®