From: Heng Qi <hengqi@linux.alibaba.com>
To: gaoxingwang <gaoxingwang1@huawei.com>
Cc: idosch@nvidia.com, kuba@kernel.org, liaichun@huawei.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
yanan@huawei.com, Jiri Pirko <jiri@resnulli.us>,
mkubecek@suse.cz
Subject: Re: [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()
Date: Tue, 2 Apr 2024 20:19:52 +0800 [thread overview]
Message-ID: <359c5369-da09-49ba-a900-415f41911fa8@linux.alibaba.com> (raw)
In-Reply-To: <20240402121618.3575706-1-gaoxingwang1@huawei.com>
在 2024/4/2 下午8:16, gaoxingwang 写道:
> Add missing colon in coalesce_reply_cb()
>
> Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
> Signed-off-by: Gao Xingwang <gaoxingwang1@huawei.com>
> ---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c
> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> - show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> + show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> show_cr();
>
Reviewed-by: Heng Qi <hengqi@linux.alibaba.com>
prev parent reply other threads:[~2024-04-02 12:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 7:24 [PATCH] netlink: fix typo gaoxingwang
2024-03-22 7:58 ` Jason Xing
2024-03-22 8:13 ` Jiri Pirko
2024-03-22 8:49 ` Michal Kubecek
2024-03-23 7:16 ` gaoxingwang
2024-03-23 7:27 ` [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb() gaoxingwang
2024-03-22 8:14 ` [PATCH] netlink: fix typo Jiri Pirko
2024-03-22 15:07 ` Jakub Kicinski
2024-04-02 11:16 ` Jiri Pirko
2024-04-02 12:16 ` [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb() gaoxingwang
2024-04-02 12:19 ` Heng Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=359c5369-da09-49ba-a900-415f41911fa8@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=gaoxingwang1@huawei.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=liaichun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=yanan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®