From: Jani Nikula <ext-jani.1.nikula@nokia.com>
To: David Brownell <david-b@pacbell.net>
Cc: "Daniel Glöckner" <dg@emlix.com>,
"Ben Nizette" <bn@niasdigital.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] gpiolib: allow poll(2) on gpio value
Date: Fri, 3 Jul 2009 00:37:26 +0300 [thread overview]
Message-ID: <359ed6810907021437m4417d4bfhc3d49b19387dbf96@mail.gmail.com> (raw)
In-Reply-To: <200907021157.33250.david-b@pacbell.net>
On Thu, Jul 2, 2009 at 21:57, David Brownell<david-b@pacbell.net> wrote:
> On Thursday 02 July 2009, Jani Nikula wrote:
>> > Looks pretty clean. Comments from anyone else?
>>
>> I'd appreciate a kernel side interface to gpio_setup_irq functionality
>> as well; now gpio_export from kernel won't setup support for poll(2)
>> nor is there any possibility to do so.
>
> I don't understand what you mean by this... there's no
> file descriptor open at that time, so there's no poll()
> that could be done.
I'm trying to say that if you call gpio_export() to create a sysfs
node, a subsequent poll() in user space won't work because there is no
irq set up, and sysfs_notify_dirent() won't be called. The patch
doesn't provide an interface for setting that up from kernel after
gpio_export() call - it's only possible to set up edge triggering and
sysfs notify by writing to the "edge" node from user space. That may
well be deemed sufficient, at least for now, and can be fixed later if
need be.
BR,
Jani.
next prev parent reply other threads:[~2009-07-02 21:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 14:36 [PATCH] gpiolib: allow poll " Daniel Glöckner
2009-06-06 3:46 ` Ben Nizette
2009-06-06 3:53 ` Ben Nizette
2009-06-06 6:01 ` David Brownell
2009-06-06 6:51 ` Ben Nizette
2009-06-06 5:41 ` David Brownell
2009-06-10 12:36 ` [PATCH v2] gpiolib: allow poll(2) " Daniel Glöckner
2009-07-01 23:05 ` David Brownell
2009-07-02 0:19 ` Ben Nizette
2009-07-02 11:15 ` Jani Nikula
2009-07-02 18:57 ` David Brownell
2009-07-02 21:37 ` Jani Nikula [this message]
2009-07-02 22:16 ` David Brownell
2009-07-14 19:26 ` [PATCH v3] " Daniel Glöckner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=359ed6810907021437m4417d4bfhc3d49b19387dbf96@mail.gmail.com \
--to=ext-jani.1.nikula@nokia.com \
--cc=bn@niasdigital.com \
--cc=david-b@pacbell.net \
--cc=dg@emlix.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®