From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932664AbbJPT1W (ORCPT <rfc822;w@1wt.eu>);
	Fri, 16 Oct 2015 15:27:22 -0400
Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.217]:19727 "EHLO
	mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753550AbbJPT1U (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 16 Oct 2015 15:27:20 -0400
X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcKdUCnXG6JabOfSXKWrat+g9PvyuWM
X-RZG-CLASS-ID: mo00
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: [PATCH v3 3/3] misc: Add w2sg0004 gps receiver driver
From: "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <3951119.loGSTxYIZb@wuerfel>
Date: Fri, 16 Oct 2015 21:27:11 +0200
Cc: Jiri Slaby <jslaby@suse.cz>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Jonathan Corbet <corbet@lwn.net>,
        Sergei Zviagintsev <sergei@s15v.net>,
        Peter Hurley <peter@hurleysoftware.com>,
        One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Sebastian Reichel <sre@kernel.org>, NeilBrown <neil@brown.name>,
        Grant Likely <grant.likely@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>, linux-serial@vger.kernel.org,
        Marek Belisko <marek@goldelico.com>, devicetree@vger.kernel.org,
        linux-doc@vger.kernel.org
Content-Transfer-Encoding: 7bit
Message-Id: <35C9DA36-55B3-44BC-8553-FCBEA2799B7D@goldelico.com>
References: <cover.1445018912.git.hns@goldelico.com> <c53ab7a3ca68f8b9f802c1ea799d72e1cb04a1eb.1445018913.git.hns@goldelico.com> <3951119.loGSTxYIZb@wuerfel>
To: Arnd Bergmann <arnd@arndb.de>
X-Mailer: Apple Mail (2.1878.6)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 16.10.2015 um 21:06 schrieb Arnd Bergmann <arnd@arndb.de>:

> On Friday 16 October 2015 20:08:35 H. Nikolaus Schaller wrote:
>> +
>> +static int w2sg_data_probe(struct platform_device *pdev)
>> +{
>> +       struct w2sg_pdata *pdata = dev_get_platdata(&pdev->dev);
>> +       struct w2sg_data *data;
>> +       struct rfkill *rf_kill;
>> +       int err;
>> +
>> +       pr_debug("%s()\n", __func__);
>> +
>> +       if (pdev->dev.of_node) {
>> +               struct device *dev = &pdev->dev;
>> +               enum of_gpio_flags flags;
>> +
>> +               pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
>> +               if (!pdata)
>> 
> 
> Why is this a platform_device and not a serio_device?

I can't find a struct serio_device. What is that?

BR and thanks,
Nikolaus