From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00444227BA4 for ; Tue, 27 Jan 2026 09:20:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769505622; cv=none; b=desnmNTMoiPW8gPDwxO4Zw+1fd/XFXPFRxnRcDcitdxgVOgX/3gSCtSifOUt0kJrNeauE1EdZzcsKFFHSzOJfDPG9vPDZ4hz3DlkpV7wn/h3i4VqvVoWRmYoJKw4n3qVf1F9LsvIYPf5/Hfb75D84bNvo0pzdd6DEBT2wOERzcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769505622; c=relaxed/simple; bh=NRaJIBsOgwkV+eg1RM+W3L4+CnbMHXTkmYHk3spsKPM=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=r1+R6+jYJXmk6XjCPuxYH2B6tDQLVfbl/OXPqdFpGJ9wEMekW38FPbx2H+t/eh4l93y9o8k4j1uk5GnkiVlcSES0OVb3+5X/Q46feDSO7k0lP65jaq4i2e13OC8G6sl27rWurtPrbnr1VuSCD1wF1XfA9AxtbZ9vsZklWNqIv08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UXEzkjDm; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UXEzkjDm" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b8863db032dso635708866b.0 for ; Tue, 27 Jan 2026 01:20:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769505619; x=1770110419; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NRaJIBsOgwkV+eg1RM+W3L4+CnbMHXTkmYHk3spsKPM=; b=UXEzkjDm6qwK1BqyIrUwDRCx/k+zmjBTxPxSbmozC/Tklkhc1tiNOBK3lC+UOXQEkR TqocH+sDDld736nY/D1Osoz4iNDo6/nayIILqksJKNPefHaVqWKuWgoMI/1CCOONWyNJ rFj+6LpEoEx2VpnPzwz1aN4fdYdcp7lhyO4i1dtE86qw8VLbZtPSmRPX9Io6RbGw91IK dboawPT3z2Tev8GLTA0g3e1vW+5ZmoG1Uo3gs4VHny+6M3yrjEuTpRWrLZ6rNtuzFRBs 5J5jufiQ5lLQLOGLhdVX7Z7ykMv4OYWvIJtepSqWGHkng05C1crl3vceAKOWvJDnACRl VfLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769505619; x=1770110419; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NRaJIBsOgwkV+eg1RM+W3L4+CnbMHXTkmYHk3spsKPM=; b=I7I8ZzgG92jvDW0a0Ewuha8flvi0AeklsE4istFqM/OKmrSU1ZTkGsP7u96WqkuPrp WH7BqE6rAVf29Nh1Aly5rXw25tWCQDogzX/grZOfVdEVhgTUCRj3HMmAgtSwvR/3Cq1j 4sGpGepwOHvXvJGtsQ2ogcNoMVVi/HHxDjwLxEJLwIWzp2njDA5d/CWFG9sig3ts4FxV zxjk4yDgrLMCQB2yLn761J7evFv2U8vSIhB3jEzJGre8qDRrvFKsUIifdwF6PzW7apJw S4075pW7mY4QvhATII/YXdFXcNZ/turFiyjri1ysjnioqrM0ICe/+Z8fB0P0eCAx71i8 BEhg== X-Forwarded-Encrypted: i=1; AJvYcCUu4qYfChfarHqjS3Z/dqb1k0Ge2Es1YOSPcRXPggOUsuatt/MMZjveYAsWbs5qAV79g74z3QBfapiKuhM=@vger.kernel.org X-Gm-Message-State: AOJu0YxmNQh5z0d134rOcmdt2bQFAxkP+utT0kCanrkH/NLOw0tgHMMZ oJ2CRJhkSYx2YRHRZdrO81nobcXbGuQZ1JFzzmw+h6qWhggAxp1aBBedZ78ggw== X-Gm-Gg: AZuq6aKsf4piCERP+uJb6SX/RpCbrF6HLBieilme2ucbcppzExm8b8xaJ3PPMIeMSvT xMBJUPyDD5I6MP9ERkLNZlmxFUoZHPkc9CkdMNKGVdqHRjTUTHpb4U5b53DO14wa3qReUqfyN7I KVKRmxuvC8P7Zrko0o/Dvc3DLa3UJJqt2xVPXyPK+PyC/w78QyXcXOT4y36C5N8H68khCSX1txg zokJ0v6aWdIMeaOsQVxt18DC7u90Iig8O3ReSwT1Y/nbGpyhFeZ9UAODd5UXqcW4nNClM0HhjCB bJvYtC02PTiI5N2g8iGG+grt6Mzv05M22VIqx2fFk+haa/d7Hp4A6gxP7ckQO/sHAf5RCoriTzN EhHD/CQOJAKWmWjeyW8FXTU3sLNwT056nJSZB53N9e4+iSQstPyEaObJwSG7aZTiPjKSDP/E2JP gnmxqnA+TcskI7Kh0wquUMSswILQb7ZyXSMddLrTbV/xMd4OzNOarmYTV/cZT5fzT/ X-Received: by 2002:a17:907:7287:b0:b88:5b35:914b with SMTP id a640c23a62f3a-b8dab3d056bmr95912366b.59.1769505619057; Tue, 27 Jan 2026 01:20:19 -0800 (PST) Received: from smtpclient.apple (89-66-237-154.dynamic.play.pl. [89.66.237.154]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b885b700d43sm776257066b.41.2026.01.27.01.20.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jan 2026 01:20:18 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: [PATCH v6 0/5] Add support for S4 audio From: Piotr Oniszczuk In-Reply-To: <20260126-audio_drvier-v6-0-99e350855bc2@amlogic.com> Date: Tue, 27 Jan 2026 10:20:03 +0100 Cc: Jerome Brunet , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Michael Turquette , Stephen Boyd , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com Content-Transfer-Encoding: quoted-printable Message-Id: <35CAE0E9-4C3F-4B41-BA1A-19761671F392@gmail.com> References: <20260126-audio_drvier-v6-0-99e350855bc2@amlogic.com> To: jiebing.chen@amlogic.com X-Mailer: Apple Mail (2.3826.700.81.1.4) > Wiadomo=C5=9B=C4=87 napisana przez Jiebing Chen via B4 Relay = w dniu 26 sty 2026, o = godz. 07:01: >=20 > This series completes the end-to-end audio support > for S4 SoC from hardware bindings to driver implementation > and system integration. >=20 > 1 Device Tree Bindings Updates=20 > Added audio power domain and S4 audio clock support for S4 SoC. > Added S4 audio tocodec binding support. >=20 > 2 Driver Implementation > Implemented S4 tocodec driver for G12A architecture. > Added S4 audio clock support in AXG audio clock=20 >=20 > 3 Device Tree Integration > Add Amlogic S4 audio subsystem support in arm64 DTS. >=20 > Signed-off-by: jiebing chen > --- > Changes in v6: > - Fix the problem of string for = Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml > - Remove clock pad register, and it will be submitted as an = independent patch. > - Redescribe sound/soc/meson/g12a-toacodec.c > - Link to v5: = https://lore.kernel.org/r/20250710-audio_drvier-v5-0-d4155f1e7464@amlogic.= com >=20 Jiebing, FYI I applied this series over 6.18.7 and tested on s905w2 device. With audio routing like this: amixer cset numid=3D40,iface=3DMIXER,name=3D'FRDDR_A SINK 1 SEL' 0 amixer cset numid=3D73,iface=3DMIXER,name=3D'TDMOUT_A SRC SEL' 0 amixer cset numid=3D37,iface=3DMIXER,name=3D'FRDDR_A SRC 1 EN Switch' 1 amixer cset numid=3D61,iface=3DMIXER,name=3D'TOACODEC SRC' 0 amixer cset numid=3D1,iface=3DMIXER,name=3D'TOACODEC Lane Select' 0 amixer cset numid=3D62,iface=3DMIXER,name=3D'TOACODEC OUT EN Switch' 1 amixer cset numid=3D17,iface=3DMIXER,name=3D'ACODEC Playback Volume' 251 = 251 i'm getting working audio on analog headset. Great work!