mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wang, Yalin" <Yalin.Wang@sonymobile.com>
To: "'Rusty Russell'" <rusty@rustcorp.com.au>,
	"'akpm@linux-foundation.org'" <akpm@linux-foundation.org>,
	"'jani.nikula@intel.com'" <jani.nikula@intel.com>,
	"'hch@infradead.org'" <hch@infradead.org>,
	"'hare@suse.de'" <hare@suse.de>,
	"'keescook@chromium.org'" <keescook@chromium.org>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC] export module parameters even the permission is zero
Date: Thu, 22 Jan 2015 10:07:49 +0800	[thread overview]
Message-ID: <35FD53F367049845BC99AC72306C23D1044A02027DE0@CNBJMBX05.corpusers.net> (raw)
In-Reply-To: <87lhkyarnc.fsf@rustcorp.com.au>

> -----Original Message-----
> From: Rusty Russell [mailto:rusty@rustcorp.com.au]
> Sent: Tuesday, January 20, 2015 2:33 PM
> To: Wang, Yalin; 'akpm@linux-foundation.org'; 'jani.nikula@intel.com';
> 'hch@infradead.org'; 'hare@suse.de'; 'keescook@chromium.org'; 'linux-
> kernel@vger.kernel.org'
> Subject: Re: [RFC] export module parameters even the permission is zero
> 
> "Wang, Yalin" <Yalin.Wang@sonymobile.com> writes:
> > This patch make sure to export module parameters even the permission
> > is zero, this is useful for some platforms like Android, the init
> > process can change the parameter mode/owner by chmod/chown during
> > bootup
> >
> > Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com>
> 
> Hi!
> 
>         Unfortunately, this won't work.  Various parts of the code assume
> that 0 permissions means "cannot be changed or read", so this change would
> introduce many bugs (eg. the parameter could be __initdata).
> 
> Since these are owned by root at boot, changing mode and owner should still
> work.  However, you can't make a read-only field writable and expect it to
> work.
> 
Oh, I see,
This means kernel cmdline can change this module_parameter ignored permission,

Thanks for your comments.

      reply	other threads:[~2015-01-22  2:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14  2:16 Wang, Yalin
2015-01-14  5:46 ` Kees Cook
2015-01-20  6:32 ` Rusty Russell
2015-01-22  2:07   ` Wang, Yalin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35FD53F367049845BC99AC72306C23D1044A02027DE0@CNBJMBX05.corpusers.net \
    --to=yalin.wang@sonymobile.com \
    --cc=akpm@linux-foundation.org \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=jani.nikula@intel.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®