mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wang, Yalin" <Yalin.Wang@sonymobile.com>
To: "'Naoya Horiguchi'" <n-horiguchi@ah.jp.nec.com>
Cc: "'akpm@linux-foundation.org'" <akpm@linux-foundation.org>,
	"'kirill.shutemov@linux.intel.com'"
	<kirill.shutemov@linux.intel.com>,
	"'oleg@redhat.com'" <oleg@redhat.com>,
	"'gorcunov@openvz.org'" <gorcunov@openvz.org>,
	"'pfeiner@google.com'" <pfeiner@google.com>,
	"'aquini@redhat.com'" <aquini@redhat.com>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC V2] mm:change smaps/pagemap_read calculation behavior
Date: Fri, 30 Jan 2015 17:15:08 +0800	[thread overview]
Message-ID: <35FD53F367049845BC99AC72306C23D1044A02027E08@CNBJMBX05.corpusers.net> (raw)
In-Reply-To: <20150130082344.GA30837@hori1.linux.bs1.fc.nec.co.jp>

> -----Original Message-----
> From: Naoya Horiguchi [mailto:n-horiguchi@ah.jp.nec.com]
> Sent: Friday, January 30, 2015 4:24 PM
> To: Wang, Yalin
> Cc: 'akpm@linux-foundation.org'; 'kirill.shutemov@linux.intel.com';
> 'oleg@redhat.com'; 'gorcunov@openvz.org'; 'pfeiner@google.com';
> 'aquini@redhat.com'; 'linux-kernel@vger.kernel.org'
> Subject: Re: [RFC V2] mm:change smaps/pagemap_read calculation behavior
> 
> On Fri, Jan 30, 2015 at 03:47:54PM +0800, Wang, Yalin wrote:
> > This patch change smaps/pagemap_read pagetable walk behavior, to make
> > sure not skip VM_PFNMAP pagetables,
> > so that we can calculate COW pages of VM_PFNMAP as normal pages.
> >
> > Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com>
> 
> Hi Yalin,
> 
> The original motivation of the VM_PFNMAP code in pagewalk.c comes from the
> following patch:
> 
>   commit a9ff785e4437c83d2179161e012f5bdfbd6381f0
>   Author: Cliff Wickman <cpw@sgi.com>
>   Date:   Fri May 24 15:55:36 2013 -0700
> 
>       mm/pagewalk.c: walk_page_range should avoid VM_PFNMAP areas
> 
> , where Cliff stated that some kind of vma(VM_PFNMAP) caused kernel panic
> when walk_page_range() was called over it. So I don't think that re-
> enabling
> to walk over every vma(VM_PFNMAP) unexceptionally is a good idea.
> 
> If you really want to get some information from a vma(VM_PFNMAP) via these
> interfaces, I recommend you to implement proper judging code which returns
> 0 for your vma(VM_PFNMAP) and returns 1 for Cliff's vma(VM_PFNMAP).
> 
I see, but I am curious that why kernel panic when I just
access process pagetables in page_table_walk()?
Is it caused by hardware problem?

The reason that I want to enable it is to see some drivers map some COW pages 
With VM_PFNMAP, so that user space can get correct page allocation info for 
These COW special pages with VM_PFNMAP flag.

Thanks 


      reply	other threads:[~2015-01-30  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30  6:14 [RFC] mm:change /proc/smaps caculation behavior Wang, Yalin
2015-01-30  7:47 ` [RFC V2] mm:change smaps/pagemap_read calculation behavior Wang, Yalin
2015-01-30  8:23   ` Naoya Horiguchi
2015-01-30  9:15     ` Wang, Yalin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35FD53F367049845BC99AC72306C23D1044A02027E08@CNBJMBX05.corpusers.net \
    --to=yalin.wang@sonymobile.com \
    --cc=akpm@linux-foundation.org \
    --cc=aquini@redhat.com \
    --cc=gorcunov@openvz.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=oleg@redhat.com \
    --cc=pfeiner@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®