From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754784AbbCRBz6 (ORCPT ); Tue, 17 Mar 2015 21:55:58 -0400 Received: from cnbjrel02.sonyericsson.com ([219.141.167.166]:13656 "EHLO cnbjrel02.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754618AbbCRBzx convert rfc822-to-8bit (ORCPT ); Tue, 17 Mar 2015 21:55:53 -0400 From: "Wang, Yalin" To: "'David Rientjes'" CC: "akpm@linux-foundation.org" , "heiko.carstens@de.ibm.com" , "tglx@linutronix.de" , "linux-kernel@vger.kernel.org" Date: Wed, 18 Mar 2015 09:55:48 +0800 Subject: RE: [RFC] proc: change /proc/stat show Thread-Topic: [RFC] proc: change /proc/stat show Thread-Index: AdBhBmQDu+yRyShVQtCJvkpRhwLcEwAGCM0Q Message-ID: <35FD53F367049845BC99AC72306C23D104A310D42372@CNBJMBX05.corpusers.net> References: <35FD53F367049845BC99AC72306C23D104A310D42371@CNBJMBX05.corpusers.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: David Rientjes [mailto:rientjes@google.com] > Sent: Wednesday, March 18, 2015 7:02 AM > To: Wang, Yalin > Cc: akpm@linux-foundation.org; heiko.carstens@de.ibm.com; > tglx@linutronix.de; linux-kernel@vger.kernel.org > Subject: Re: [RFC] proc: change /proc/stat show > > On Tue, 17 Mar 2015, Wang, Yalin wrote: > > > diff --git a/fs/proc/stat.c b/fs/proc/stat.c > > index 510413eb..60b39e2 100644 > > --- a/fs/proc/stat.c > > +++ b/fs/proc/stat.c > > @@ -130,7 +130,7 @@ static int show_stat(struct seq_file *p, void *v) > > seq_put_decimal_ull(p, ' ', cputime64_to_clock_t(guest_nice)); > > seq_putc(p, '\n'); > > > > - for_each_online_cpu(i) { > > + for_each_present_cpu(i) { > > /* Copy values here to work around gcc-2.95.3, gcc-2.96 */ > > user = kcpustat_cpu(i).cpustat[CPUTIME_USER]; > > nice = kcpustat_cpu(i).cpustat[CPUTIME_NICE]; > > @@ -153,6 +153,7 @@ static int show_stat(struct seq_file *p, void *v) > > seq_put_decimal_ull(p, ' ', cputime64_to_clock_t(steal)); > > seq_put_decimal_ull(p, ' ', cputime64_to_clock_t(guest)); > > seq_put_decimal_ull(p, ' ', cputime64_to_clock_t(guest_nice)); > > + seq_printf(p, " %d", cpu_online(i)? 1 : 0); > > seq_putc(p, '\n'); > > } > > seq_printf(p, "intr %llu", (unsigned long long)sum); > > Makes sense, but why do we need to output the cpu state as part of > /proc/stat? This information should already be available elsewhere. Yeah, online / offline info can be read from /sys/devices/cpu . I can remove this line , if you think it is not needed . Thanks