mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chuck Lever" <cel@kernel.org>
To: "David Laight" <david.laight.linux@gmail.com>,
	"Chuck Lever" <chuck.lever@oracle.com>,
	"Jeff Layton" <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
	linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Greg Banks" <gnb@melbourne.sgi.com>
Cc: "Olga Kornievskaia" <okorniev@redhat.com>,
	"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
	"Andrew Morton" <akpm@osdl.org>,
	"Linus Torvalds" <torvalds@osdl.org>
Subject: Re: [PATCH net-next] fs: nfsd: Fix buffer overflow in write_pool_threads()
Date: Wed, 12 Aug 2026 16:19:22 -0400	[thread overview]
Message-ID: <35a12022-518b-4c66-b3d5-c850376bfca7@app.fastmail.com> (raw)
In-Reply-To: <20260812193349.13347-1-david.laight.linux@gmail.com>



On Wed, Aug 12, 2026, at 3:33 PM, David Laight wrote:
> write_pool_threads() writes the number of threads in each pool into a
> caller-supplied 'almost PAGE_SIZE' buffer.
> If there are enough pools to overflow the buffer the code continues
> writing beynd its end.
>
> Fix the overflow check so that it actually works.
>
> Fixes: eed2965af1bae "knfsd: allow admin to set nthreads per node"
> Signed-off-by: David Laight <david.laight.linux@gmail.com>
> ---
>
> I'm pretty sure this is 'root only' code.
> So you'd have to try very hard to actually get the overflow.
>
>  fs/nfsd/nfsctl.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 39e7012a60d8..b74048aa2402 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -483,8 +483,7 @@ static ssize_t write_pool_threads(struct file 
> *file, char *buf, size_t size)
>  		 * file, sorry.  Report zero threads.
>  		 */
>  		mutex_unlock(&nfsd_mutex);
> -		strcpy(buf, "0\n");
> -		return strlen(buf);
> +		return strscpy(buf, "0\n", SIMPLE_TRANSACTION_LIMIT);
>  	}
> 
>  	nthreads = kzalloc_objs(int, npools);
> @@ -523,13 +522,14 @@ static ssize_t write_pool_threads(struct file 
> *file, char *buf, size_t size)
> 
>  	mesg = buf;
>  	size = SIMPLE_TRANSACTION_LIMIT;
> -	for (i = 0; i < npools && size > 0; i++) {
> -		snprintf(mesg, size, "%d%c", nthreads[i], (i == npools-1 ? '\n' : ' '));
> -		len = strlen(mesg);
> +	for (i = 0; i < npools; i++) {
> +		len = scnprintf(mesg, size, "%d ", nthreads[i]);
>  		size -= len;
>  		mesg += len;
>  	}
>  	rv = mesg - buf;
> +	if (rv != SIMPLE_TRANSACTION_LIMIT - 1)
> +		msg[-1] = '\n';

Did you mean "mesg[-1] = '\n';" here?


>  out_free:
>  	kfree(nthreads);
>  	mutex_unlock(&nfsd_mutex);
> -- 
> 2.39.5

-- 
Chuck Lever

  reply	other threads:[~2026-08-12 20:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12 19:33 David Laight
2026-08-12 20:19 ` Chuck Lever [this message]
2026-08-12 21:04   ` David Laight
2026-08-16 17:43     ` Chuck Lever
2026-08-17  8:06       ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35a12022-518b-4c66-b3d5-c850376bfca7@app.fastmail.com \
    --to=cel@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=akpm@osdl.org \
    --cc=chuck.lever@oracle.com \
    --cc=david.laight.linux@gmail.com \
    --cc=gnb@melbourne.sgi.com \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®