From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 462623DE446 for ; Wed, 25 Mar 2026 14:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774447979; cv=none; b=Bkwvc31wG2F3BDUghILpDUR8vkTuVeh5+b8IjsPlWQLKlTVKVmF3y3Nvur4zQZEdykqdcX/RILndm+1M1iENRejXLlubPfQK3vInmPylZxVuUKSf7Dy0uQteTi9WXZUkAFun2SUgt+JjFBT5VGSeKw/xuL79lPOR4gmvnUxGxLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774447979; c=relaxed/simple; bh=8f5jDgxfOYWKqhtq/LueH8BWKoAZuBfi50Q/okS8QiE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j3RVq+uBuCTkNF107JQ5bHBHqIpe2dAtmY8GZH/Y+zZQjCuaYX0meqfIJ9Pw9eLRu6j+OXS1PLzDtciXNxsdUv1Hd6MHugjIwtNvc+riFXrrrBnZXAd8B6ED7OYhDgsGxyOyNadTAKX6NEByeE/PNeF6wrw4AczJ3yw45cSfBe4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q4v6m8lI; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q4v6m8lI" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2b4520f6b32so2861846eec.0 for ; Wed, 25 Mar 2026 07:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774447975; x=1775052775; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=xrtP2XKpL7jnk9JhdiacyJBzRuy/A4bB7Ft+VON4MHk=; b=q4v6m8lI793sCfDztVbLSVR/R6uBI5FfHwsTP8o47pSeZoBU2wFGjLElPFBRPXU6A9 p+ecbpgLl3L1z/7pXvVys8RxMTnd/mmwULHmskjVDjD4ykvs4UkDP4sUPc50CUmf1HqO G4Fs6QacoAlY5gm+ZdtEa5MazJP1TpmJkNcFlVZENO5aLig7vuoxvBMZ9GJuP+5gk6ZR 0CcEDGA2E3+j7d62CPHbZ91SNS75wU3SkrT4V3gxvDq8MWHNDB0OG5HBk4iALIlqfcOv 7Jr7DaFY1dpO2TG/AWq3Kh1xNBIGBTCGFZOVW6Kro4/ZzDl6wCThvJ/6gz76cQMp+gJJ Bdyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774447975; x=1775052775; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xrtP2XKpL7jnk9JhdiacyJBzRuy/A4bB7Ft+VON4MHk=; b=dlucLMnaooGu1HOhSxAfLNo3FlD6x8wXnFQ2CD+w59nhIm7Wsn0Pox1+tOentsyuyb tDM4dxDheVsjvAgUKMdJj/IOPJ4RMNTyZce1o8GJD2jlWS4CktYrVMoZfkP0FEcghLGf 7jM/c1mfgrEr2ZesAvuz2yy6rWdsTa/nmQ2WOE8ZinqIxWea04e2VtdjhhTQaR+JgaSH B0LLbZy2PFHx/ZS5J0V1r/x+OSo3WH2rINM+5TU4BsfJlml1NXUK15AUdVCY2D7ZHa66 D93BVAtPyFAdRypkLSWidLV89jDokViE2xDuUrHj9Wbjizs4VEct2ilI2Yn1+2czQ6CA IMpQ== X-Forwarded-Encrypted: i=1; AJvYcCVAF3OXnj8ADk2SUzXqpyMBiLEpeHbCaCjkKE/OWlRroixVOeE8ZiWZbmQztZDFV5i9iR2PMt4EWp7oqXU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4om8E4x+Ty5wVG/FwvbwCXQb33tMiSGNXVaQqyJLGbCwHUOMn 7lP/nFr2OS+uootB5IGRZZXmYvnmdIXKHAkPQPeExp86HRdv6GxQPRWh X-Gm-Gg: ATEYQzxQW8ApF27Sz3MhSMdCSyoXnvV08AO329cNlBHTNg/xFZHdVebCyOR6G+ejwTX pee1a7koH0Jnm4ctZ6f5ii4C1g1/vLk+NCXr9ouRRFPqIsRisEIUC/NFxtHr0Ewas76RWnFkGFy PP+rA4lhoxE2IRBSuUXLKCvpdtExR5nggwDBQnv+x+I/3oJCcP5s2P1XW9aCc2Wbbb2Zg/GKZap t9MwoQjvbF931rTnhdTQmOTmBq71fQ+LXWDFx2M8o9XwCAKZvm36Ti1VCzDBcoZTTwFH8qflerB nnelAG1w+CdmxgZNlaUpm5PMfgJ33i3Hfxv9z2Qf1NJPF/f7VydsA2xYzUdbRKpFwQg6swXZWNJ KH+x3vJ4Cz6D95+KETZ1xFhHSfzQ88mw6KNhGN0opuTeS7DIp+pcmijqQ7O2SHeHpNW5svquzSm ong4uIqWmKC6jgZlDerKc9EJXn28WmY1/UDzirXsd+f94X8gX2KXTsx2Qoxnsf0TduBgAsy7FH X-Received: by 2002:a05:7301:d87:b0:2ba:85d6:e777 with SMTP id 5a478bee46e88-2c15d28a868mr1781822eec.2.1774447975226; Wed, 25 Mar 2026 07:12:55 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b14bac4sm24526735eec.4.2026.03.25.07.12.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 07:12:54 -0700 (PDT) Sender: Guenter Roeck Message-ID: <35a21e8c-689c-433b-a4a2-6d7567c09d0b@roeck-us.net> Date: Wed, 25 Mar 2026 07:12:52 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943 To: Dawei Liu Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Geert Uytterhoeven , Magnus Damm , Grant Peltier , Linda Xin , Tabrez Ahmed , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260325041728.68-1-dawei.liu.jy@renesas.com> <20260325041728.68-3-dawei.liu.jy@renesas.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260325041728.68-3-dawei.liu.jy@renesas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/24/26 21:17, Dawei Liu wrote: > Add I2C device IDs for Renesas RAA228942 and RAA228943. > > At the Linux PMBus hwmon interface level currently supported by this > driver, these devices are compatible with the existing 2-rail non-TC > controllers, so devicetree will use fallback compatibles and no > dedicated OF match entries are needed. > The AI still has a couple of concerns: https://sashiko.dev/#/patchset/20260325090208.857-1-dawei.liu.jy%40renesas.com As it turns out, the concern about i2c_match_id() vs. i2c_get_match_data() has already been addressed in the hwmon-next branch. Given that, I'll apply the series and address Krzysztof's feedback to the first patch. No need to resend. Thanks, Guenter > Signed-off-by: Dawei Liu > --- > Documentation/hwmon/isl68137.rst | 20 ++++++++++++++++++++ > drivers/hwmon/pmbus/isl68137.c | 2 ++ > 2 files changed, 22 insertions(+) > > diff --git a/Documentation/hwmon/isl68137.rst b/Documentation/hwmon/isl68137.rst > index e77f582c2..0ce20d091 100644 > --- a/Documentation/hwmon/isl68137.rst > +++ b/Documentation/hwmon/isl68137.rst > @@ -394,6 +394,26 @@ Supported chips: > > Provided by Renesas upon request and NDA > > + * Renesas RAA228942 > + > + Prefix: 'raa228942' > + > + Addresses scanned: - > + > + Datasheet: > + > + Provided by Renesas upon request and NDA > + > + * Renesas RAA228943 > + > + Prefix: 'raa228943' > + > + Addresses scanned: - > + > + Datasheet: > + > + Provided by Renesas upon request and NDA > + > * Renesas RAA229001 > > Prefix: 'raa229001' > diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c > index 3346afdf3..03c9adc0e 100644 > --- a/drivers/hwmon/pmbus/isl68137.c > +++ b/drivers/hwmon/pmbus/isl68137.c > @@ -432,6 +432,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = { > {"raa228228", raa_dmpvr2_2rail_nontc}, > {"raa228244", raa_dmpvr2_2rail_nontc}, > {"raa228246", raa_dmpvr2_2rail_nontc}, > + {"raa228942", raa_dmpvr2_2rail_nontc}, > + {"raa228943", raa_dmpvr2_2rail_nontc}, > {"raa229001", raa_dmpvr2_2rail}, > {"raa229004", raa_dmpvr2_2rail}, > {"raa229141", raa_dmpvr2_2rail_pmbus},