Re: [PATCH 0/2] rtc: ds1685: power-off fixes

[Joshua Kinard <linux@kumba.dev>]

On 10/13/2026 05:49, Imre Kaloz wrote:
> Two fixes for ds1685_rtc_poweroff(), on SGI O2 and Octane machines.
> 
> Patch 1 arms the wake-up alarm only if an alarm is set, so that stale
> alarm registers no longer power the machine back on.
> 
> Patch 2 repeats the PAB write, clearing the kickstart and wake-up
> flags with it, until power is removed.
> 
> Patch 1 was tested on an O2, patch 2 on an Octane.
> 
> Imre Kaloz (2):
>    rtc: ds1685: arm the wake-up alarm at power-off only if an alarm is
>      set
>    rtc: ds1685: keep setting PAB until power is removed
> 
>   drivers/rtc/rtc-ds1685.c | 38 +++++++++++++++++++++++++-------------
>   1 file changed, 25 insertions(+), 13 deletions(-)
> 
> 
> base-commit: 24a19b953e2a3d0ea5a8c4951a0ab8f32720c907

Both of these look good.  I am unable to test them right now, but it sounds 
like the second patch might fix the sporadic issue of an Octane sometimes 
not powering off.

Thanks!

Acked-by: Joshua Kinard <linux@kumba.dev>