From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBotn0TDPf8okG7E49rzRD4r0YWcWSb3/jY8Zu0RHYs+d7De9IHzdzpYTQqgZMoCyO2xByXz7 ARC-Seal: i=1; a=rsa-sha256; t=1516293074; cv=none; d=google.com; s=arc-20160816; b=dHIvaIQYZXYOAyPEPZaFabDOrxBRK0AjjfpW4cL22/YP5NBSl5Bi6ssOfEYdojmXdV sHvmUnLHp6WKrgRN8XkxQhvNgce44I7fpKZGt2qb9pJ3QLIdinAencSKAPkVHaj8W2Xp f6XJWLQdbFgBvD+IO8mT+G1D/kUqOxMR3FxxTb+XK0YaA1zh/cPbezJslX4e9ttMhFRk ibIcULX2AdcLFBuKp15rrSopAtkSCHab4iLJgeZ4MYBR1L66M22+ESbRoUkE8UHfECyJ DW4Wb2mgh4UtLYKjjoG/xiDq0KYRXDUliMjxqXgk+n5lMZc9UmppHT4uzt1hdFACuiOQ c7QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=GcH/fE8fwG6tlgYpOlVc7ZCJwZwg0utFt5tmLtMaU0s=; b=NMGaE2OnBPK/+7jWKV8Y/Jsf4VpCMJsLeG1lkUQFIOfcjpfbbHjIV+OKsZ/21unRiq R5wxd95PIlcJaMOOV9ewwGSILdF43G4y7a5T1LCmPwMOOfGWDgOzDq6QHpR/plzv8F+c t3O571eiAEGcPmhViniXU/wMzUl/VLhlG5eDJvLIRKHyX8CFBrVscD0v54QZ4J242Ilh YXYSU3R4B9zApeHPy01m60x09qce3Ll6Eg1Qbhx4aWvU8pxn7XMNsUSffQZmRipWW2Y6 8apATp2wHr/lbb3OeCXoTQpiY8stxuC+7mseCw5hafujdgTugrRbeL7ftOHHwLmjMgrF aWfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=DANi4SIF; dkim=pass header.i=@codeaurora.org header.s=default header.b=P9LeTJe5; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=DANi4SIF; dkim=pass header.i=@codeaurora.org header.s=default header.b=P9LeTJe5; spf=pass (google.com: domain of okaya@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=okaya@codeaurora.org DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 32A5D601CF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC To: poza@codeaurora.org Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-4-git-send-email-poza@codeaurora.org> <733abfcb-5b31-7394-ab62-19a0888d71c2@codeaurora.org> <5cf7004e62a2979afb3c29e99d705c60@codeaurora.org> From: Sinan Kaya Message-ID: <35a9ce2b-156f-3235-c3b7-2c495fe9c52b@codeaurora.org> Date: Thu, 18 Jan 2018 11:31:11 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <5cf7004e62a2979afb3c29e99d705c60@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835690475100377?= X-GMAIL-MSGID: =?utf-8?q?1589948526841081045?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 1/18/2018 12:57 AM, poza@codeaurora.org wrote: > On 2018-01-18 10:47, poza@codeaurora.org wrote: >> On 2018-01-17 22:16, Sinan Kaya wrote: >>> On 1/17/2018 5:37 AM, Oza Pawandeep wrote: >>>> +++ b/include/linux/dpc.h >>>> @@ -0,0 +1,9 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0 */ >>>> + >>>> +#ifndef _DPC_H_ >>>> +#define _DPC_H_ >>>> + >>>> +#define DPC_FATAL        4 >>>> + >>>> +#endif //_DPC_H_ >>>> + >>> >>> can you keep this in drivers/pci.h and get rid of this file? >> >> I thought about this, but if I keep it in drivers/pci.h, >> then AER's defines have to be in that as well. (for unification) >> >> and then all the dependent files who are using AER_FATAL such as >> drivers/acpi/apei/ghees.c >> have to go on including this drivers file which is odd way of doing it. >> >> So I am not very sure about this....since AER_FATAL are in aer.h, I >> have made dpc.h >> >> >> Regards, >> Oza. > > Should I be doing in next patch-set series ? > I think you would put into include/linux/pci.h only if there is an external use of constant outside of drivers/pci directory. Otherwise, you should keep the setting inside one of the header files in drivers/pci directory. I don't see any other subsystem caring about DPC_FATAL definition. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.