mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sahil Chandna <chandna.sahil@gmail.com>
To: akpm@linux-foundation.org, david@redhat.com,
	lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz,
	rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org,
	shakeel.butt@linux.dev, zhengqi.arch@bytedance.com,
	Liam.Howlett@oracle.com, weixugc@google.com,
	axelrasmussen@google.com, yuanchu@google.com,
	yosry.ahmed@linux.dev, nphamcs@gmail.com,
	chengming.zhou@linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Cc: david@kernel.org, Sahil Chandna <chandna.sahil@gmail.com>,
	Matthew Wilcox <willy@infradead.org>,
	David Laight <david.laight.linux@gmail.com>
Subject: [PATCH v4 1/3] mm: pagewalk: simplify hugepage boundary calculation
Date: Fri, 28 Nov 2025 12:31:42 +0530	[thread overview]
Message-ID: <35ab82f052d248c0047c10bf01853e37e4f9b4e4.1764312627.git.chandna.sahil@gmail.com> (raw)
In-Reply-To: <cover.1764312627.git.chandna.sahil@gmail.com>

Replace hugepage boundary computation with ALIGN() helper instead of
an open coded expression. This helps to improves code readability.

This was flagged by Coccinelle (misc/minmax.cocci) as an opportunity
to use min(), after which the boundary computation was updated following
review suggestions.

Found by: make coccicheck MODE=report M=mm/
No functional change intended.

Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
Suggested-by: David Hildenbrand (Red Hat) <david@kernel.org>
Suggested-by: Matthew Wilcox <willy@infradead.org>
Suggested-by: David Laight <david.laight.linux@gmail.com>
Signed-off-by: Sahil Chandna <chandna.sahil@gmail.com>
---
 mm/pagewalk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/pagewalk.c b/mm/pagewalk.c
index 9f91cf85a5be..9fd59d517f37 100644
--- a/mm/pagewalk.c
+++ b/mm/pagewalk.c
@@ -312,8 +312,7 @@ static int walk_pgd_range(unsigned long addr, unsigned long end,
 static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr,
 				       unsigned long end)
 {
-	unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);
-	return boundary < end ? boundary : end;
+	return min(ALIGN(addr, huge_page_size(h)), end);
 }
 
 static int walk_hugetlb_range(unsigned long addr, unsigned long end,
-- 
2.50.1


  reply	other threads:[~2025-11-28  7:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28  7:01 [PATCH v4 0/3] mm: Coccinelle-driven cleanups across memory management code Sahil Chandna
2025-11-28  7:01 ` Sahil Chandna [this message]
2025-12-24  7:50   ` [PATCH v4 1/3] mm: pagewalk: simplify hugepage boundary calculation Baolin Wang
2025-12-24  9:23     ` [PATCH v4 1/3] mm: pagewalk: simplify hugepage boundary Lance Yang
2025-12-24 12:46       ` Sahil Chandna
2025-12-24 14:08       ` David Laight
2025-12-24 18:06         ` Matthew Wilcox
2025-12-25  9:32           ` David Hildenbrand (Red Hat)
2025-12-25 10:01             ` David Laight
2026-01-30 10:34               ` Sahil Chandna
2025-11-28  7:01 ` [PATCH v4 2/3] mm/vmscan: use %pe to print error pointers Sahil Chandna
2025-11-28  7:01 ` [PATCH v4 3/3] mm/zswap: " Sahil Chandna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35ab82f052d248c0047c10bf01853e37e4f9b4e4.1764312627.git.chandna.sahil@gmail.com \
    --to=chandna.sahil@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=chengming.zhou@linux.dev \
    --cc=david.laight.linux@gmail.com \
    --cc=david@kernel.org \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=nphamcs@gmail.com \
    --cc=rppt@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    --cc=weixugc@google.com \
    --cc=willy@infradead.org \
    --cc=yosry.ahmed@linux.dev \
    --cc=yuanchu@google.com \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®