From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46ADC315D45 for ; Mon, 8 Sep 2025 10:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757328432; cv=none; b=a3TA13T62wqeRevc8EkYHroGoCxY7BK1uYYHW5t263JI+5+zvVFcLCCPFerIjODWYzFAazMGRWwTzmYs10beczhzGYJrKvNz5ufewR14CoxDwLEiqlluUQXHCSiVCVtRtny7v2uSuUMO+Zg6ZjD2TfIlRvvIeTvjXJF+3vpz6Mw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757328432; c=relaxed/simple; bh=rwRIMaQjDUrsFv5+b76riH0+0sz3qVkQrVlJXYlUaTo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Gy8Y56C3LQBuKDmTbP9jTe5g62AEjrJK6tOEuOCJKGVGJUZHAfKaz7XBbtHnXG/DELGaL+bRXmCsVT+dzazRjt7OPJDa1PqB6+/lwpI1iP+BXR/OZj/tBibxnkNrGazJGWGW+YIR4obRlzqn7TkllD3FNklsgzlr+1IL52H1zNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cK780S4h; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cK780S4h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1757328430; x=1788864430; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=rwRIMaQjDUrsFv5+b76riH0+0sz3qVkQrVlJXYlUaTo=; b=cK780S4hm5iH/NQnne1pHyf8Pnw3f0VfP2ovkwEd9hJHTkPLFYLDHPf+ P7uzCopsKjm3cfKS/Mhp9JPoMLQnBSVlufhRxTb+X9kgGqzxWSEEP6imf 3E0uz0AdvnADn0s2gwh6+pHzCYUrl+ujubygGivsLtaV/0CtlYbCnke7J AWGHp0UDV2C4jjcxwKm5gM3amHOXdJqt9/7YSa4sEaGuKQGwQ34U8zoy8 xaKwCgPBqRaIOZj+RND6TwDt/3gSsANqVBOW2U6FhcO6zHC6uzOIhZGKH EKwaznnozbLHaQLuELV7Xi39GTqAMJsHD4OmQOj5NpDAUKV9AJNJ2Fryj A==; X-CSE-ConnectionGUID: mpEj/Xc4S4iuMAmPL0oiaQ== X-CSE-MsgGUID: /+5YHGPVTaS0JPigRRm6Kw== X-IronPort-AV: E=McAfee;i="6800,10657,11546"; a="63408479" X-IronPort-AV: E=Sophos;i="6.18,248,1751266800"; d="scan'208";a="63408479" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2025 03:47:09 -0700 X-CSE-ConnectionGUID: Ip4uDhsqSuuBXarMsAOqeQ== X-CSE-MsgGUID: 2x2OfDQdR86nFipbd6g4XQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,248,1751266800"; d="scan'208";a="173550305" Received: from carterle-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.204]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2025 03:47:05 -0700 From: Jani Nikula To: Liao Yuanhong , Zhenyu Wang , Zhi Wang , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Nitin Gote , Luca Coelho , Krzysztof Niemiec , "open list:DRM DRIVERS" , open list Cc: Liao Yuanhong Subject: Re: [PATCH] drm/i915/gvt: Remove redundant ternary operators In-Reply-To: <20250904112644.350512-1-liaoyuanhong@vivo.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250904112644.350512-1-liaoyuanhong@vivo.com> Date: Mon, 08 Sep 2025 13:47:02 +0300 Message-ID: <35ac1aad8feb977017d1d1a6eea86ed3754d8646@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, 04 Sep 2025, Liao Yuanhong wrote: > For ternary operators in the form of "a ? false : true", if 'a' itself > returns a boolean result, the ternary operator can be omitted. Remove > redundant ternary operators to clean up the code. > > Signed-off-by: Liao Yuanhong Pushed to drm-intel-next, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c > index a91e23c22ea1..d432fdd69833 100644 > --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c > +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c > @@ -1921,7 +1921,7 @@ static int perform_bb_shadow(struct parser_exec_state *s) > if (!bb) > return -ENOMEM; > > - bb->ppgtt = (s->buf_addr_type == GTT_BUFFER) ? false : true; > + bb->ppgtt = s->buf_addr_type != GTT_BUFFER; > > /* > * The start_offset stores the batch buffer's start gma's -- Jani Nikula, Intel