From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbdKIEzH convert rfc822-to-8bit (ORCPT ); Wed, 8 Nov 2017 23:55:07 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:50450 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430AbdKIEzD (ORCPT ); Wed, 8 Nov 2017 23:55:03 -0500 MIME-Version: 1.0 Message-ID: <35b094f6-70e0-49f2-803a-3333d7ee2524@default> Date: Wed, 8 Nov 2017 20:54:51 -0800 (PST) From: Zhenzhong Duan To: , , Cc: Srinivas REDDY Eeda , Joe Jin , Subject: [PATCH] tick/broadcast: Remove redundant code in tick_check_new_device() X-Mailer: Zimbra on Oracle Beehive Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no way a timer used as broadcast clockevent device is also used as percpu tick clockevent device currently. It's better to put related code in tick_install_broadcast_device(), but I feel it's harmless to give it back to the clockevents layer. Pls correct me if I'm wrong. Signed-off-by: Zhenzhong Duan --- kernel/time/tick-common.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c index 49edc1c..9bcc866 100644 --- a/kernel/time/tick-common.c +++ b/kernel/time/tick-common.c @@ -320,13 +320,8 @@ void tick_check_new_device(struct clock_event_device *newdev) /* * Replace the eventually existing device by the new - * device. If the current device is the broadcast device, do - * not give it back to the clockevents layer ! + * device. */ - if (tick_is_broadcast_device(curdev)) { - clockevents_shutdown(curdev); - curdev = NULL; - } clockevents_exchange_device(curdev, newdev); tick_setup_device(td, newdev, cpu, cpumask_of(cpu)); if (newdev->features & CLOCK_EVT_FEAT_ONESHOT) -- 1.7.3