From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file
Date: Wed, 29 Jul 2026 14:10:56 +0200 [thread overview]
Message-ID: <35b14c17-2953-4b74-af15-4677390aec9a@oss.qualcomm.com> (raw)
In-Reply-To: <20260724-08-dts-v4-2-65e61a1061f0@oss.qualcomm.com>
On 7/24/26 11:54 AM, Varadarajan Narayanan wrote:
> RDP504 has USB, PCIe and SPI NAND devices populated. EMMC and NAND
> share the GPIOs. The board has to be reworked to change from EMMC
> to NAND variant. Rename ipq5210-rdp504.dts as ipq5210-rdp504-common.dtsi
> and include it in variant specific DTS file.
>
> Describe the fixed USB regulators, PCIe reset GPIOs, QPIC SPI NAND flash
> and required pinctrl states. Enable QPIC BAM, USB and PCIe for the board.
>
> Remove ipq5210-rdp504.dtb from Makefile to avoid build break.
You're essentially removing support for the board for this commit
Instead, this commit could be:
create .dtsi (90% of the current .dts)
add #include .dtsi to .dts
and patch 3 could be:
create another dts
preferably then, all new additions would be done in patch 4 altering
just the dtsi
Konrad
next prev parent reply other threads:[~2026-07-29 12:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 9:54 [PATCH v4 0/3] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan
2026-07-24 9:54 ` [PATCH v4 1/3] arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals Varadarajan Narayanan
2026-07-29 12:08 ` Konrad Dybcio
2026-07-24 9:54 ` [PATCH v4 2/3] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file Varadarajan Narayanan
2026-07-29 12:10 ` Konrad Dybcio [this message]
2026-07-30 6:38 ` Varadarajan Narayanan
2026-07-30 7:32 ` Konrad Dybcio
2026-07-24 9:54 ` [PATCH v4 3/3] arm64: dts: qcom: ipq5210: Introduce RDP504 variant specific " Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35b14c17-2953-4b74-af15-4677390aec9a@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=varadarajan.narayanan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®