Re: [PATCH 4/4] KVM: SVM: Delay legacy platform initialization on SNP

["Kalra, Ashish" <ashish.kalra@amd.com>]

On 10/29/2024 1:39 PM, Dionna Glaze wrote:
> When no SEV or SEV-ES guests are active, then the firmware can be
> updated while (SEV-SNP) VM guests are active.
> 
> CC: Sean Christopherson <seanjc@google.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Thomas Gleixner <tglx@linutronix.de>
> CC: Ingo Molnar <mingo@redhat.com>
> CC: Borislav Petkov <bp@alien8.de>
> CC: Dave Hansen <dave.hansen@linux.intel.com>
> 
> Co-authored-by: Ashish Kalra <ashish.kalra@amd.com>
> Change-Id: I3efb5fbbd0da05ab29f85504a86693f5cdf49050
> Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
> ---
>  arch/x86/kvm/svm/sev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index f6e96ec0a5caa..8d365e2e3c1b1 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -445,6 +445,8 @@ static int __sev_guest_init(struct kvm *kvm, struct kvm_sev_cmd *argp,
>  		goto e_no_asid;
>  
>  	init_args.probe = false;
> +	init_args.supports_download_firmware_ex =
> +		vm_type != KVM_X86_SEV_VM && vm_type != KVM_X86_SEV_ES_VM;
>  	ret = sev_platform_init(&init_args);
>  	if (ret)
>  		goto e_free;

Reviewed-by: Ashish Kalra <ashish.kalra@amd.com>

Thanks,
Ashish